From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3EDF5A0351; Sat, 29 Jan 2022 18:30:28 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0EA40407FF; Sat, 29 Jan 2022 18:30:27 +0100 (CET) Received: from out162-62-57-252.mail.qq.com (out162-62-57-252.mail.qq.com [162.62.57.252]) by mails.dpdk.org (Postfix) with ESMTP id 7BF8340041 for ; Sat, 29 Jan 2022 18:30:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1643477422; bh=d/sBBsCwPKJoy/Q/OdICWNDj5apHy6rz1pzXc2HPFmI=; h=From:To:Cc:Subject:Date; b=NZVl82ErGxZZ+DvAnw8H09D7V9kfDIAEz56lwRtzUm67PHf4vtKjA/rF3H3nkNaIm s0puQCqhbyV9K4nraq92/a3tPMjWCHc3dUC2ge78ZSMldT3BrBM5GSnu6xAdrqUU+r BWnzFipLBSrVYjD0emZa86wX/tsHAHWnvQa6dbV8= Received: from liwg-ubuntu.lan ([111.193.130.237]) by newxmesmtplogicsvrszc8.qq.com (NewEsmtp) with SMTP id 78CA2C63; Sun, 30 Jan 2022 01:30:12 +0800 X-QQ-mid: xmsmtpt1643477412tkjuv8rr2 Message-ID: X-QQ-XMAILINFO: ObFHHlrAm440Idg/NPoP3pDBhwi5p0DW3Jwph5rTqVecVSGpPeuDb7PrYcaIRX 0/oGZZ1vJB1C610kAfBkIX3XFWwnhoKnn9bIA9ltR17+9sS2FlNcxifz3arLIvEHZqHUle2Jv5Lf 6z8qv9INrsnRUhe5Wvn9SUxb1wS9oFyNNGlHUYDA22Xamb8PqDF/e47l+0vESnIQ8AY4JYvzfn8O e5+eDL302CmOHnly2NVNKmt3KLBhAzAq+4NEHMQ0Iv6OECosVMu/hqvgB+B2dBXezxqB3Z6tGFGM eUQFKgqXxlNqiQq6I2DPC88PsDjUNx6+5Np30ee3h5gnsr1WgA1n/JRzRN0jbzwqbqhh7u7H98K7 xfZNDFKV1Phm+atQAw6bBM8oQCi0nT79pzSROzCnUguP5zq1t5ORCpLPhdysI+N+HyD0gVKMkWBj en+ENcQwOc1c4ZJH6iD6cgShRB4xLukUkku8KQknGbw7iFzIVu+KL7cr2cduQg77bFc22E+ICNn4 q1FSjEyI5NfRW+ZCzfc3B33MIesuVkw/srfwzGWJ2L69eXIrSJDXUZxJlO3nCDxmIs5yOIVfesV+ 1PmHFe1U/l5InGj0FIezHMppgsfJV0pigKGmbQLG5vOAPrfNGcCuwn/l2Qh/68g8MjJ2T31cf4s0 gMs8OJ+oOcwe/v0aW5fA3RRYoMOhMJlIK7Ruklg919MkKYe0I1aE9BuppsD9YBSR4/OdZsJsnrWx vvOpuqiOVRwnQE6G6I5/Lpmw3l6hdLUWGSedF3liwRleC2k8REaDBlOkUiw/RZLeNebsVt/T/EOQ eLKh9KqpQO4T2rcFXFc2USD4Jc1KNwl+DhPhw8JFUDfG6fwrTPeZt28C9mnxy69mY= From: Weiguo Li To: vsrivast@xilinx.com Cc: dev@dpdk.org Subject: [PATCH] vdpa/sfc: fix null pointer dereference Date: Sun, 30 Jan 2022 01:30:12 +0800 X-OQ-MSGID: <20220129173012.666945-1-liwg06@foxmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When sva is null, sfc_vdpa_info(sva, ...) will cause a null dereference. Use SFC_VDPA_GENERIC_LOG() to avoid that. See macros sfc_vdpa_info and SFC_VDPA_GENERIC_LOG defined in drivers/vdpa/sfc/sfc_vdpa_log.h for detail. Fixes: 5e7596ba7cb3 ("vdpa/sfc: introduce Xilinx vDPA driver") Signed-off-by: Weiguo Li --- drivers/vdpa/sfc/sfc_vdpa.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/vdpa/sfc/sfc_vdpa.c b/drivers/vdpa/sfc/sfc_vdpa.c index fccdd8c687..53f598facc 100644 --- a/drivers/vdpa/sfc/sfc_vdpa.c +++ b/drivers/vdpa/sfc/sfc_vdpa.c @@ -328,7 +328,8 @@ sfc_vdpa_pci_remove(struct rte_pci_device *pci_dev) sva = sfc_vdpa_get_adapter_by_dev(pci_dev); if (sva == NULL) { - sfc_vdpa_info(sva, "invalid device: %s", pci_dev->name); + SFC_VDPA_GENERIC_LOG(INFO, + "Invalid device: %s.", pci_dev->name); return -1; } -- 2.25.1