From: Weiguo Li <liwg06@foxmail.com>
To: jiawenwu@trustnetic.com
Cc: dev@dpdk.org
Subject: [PATCH] net/txgbe: fix a bit with boolean operator
Date: Tue, 1 Mar 2022 14:08:30 +0800 [thread overview]
Message-ID: <tencent_D18B07E35425224027E35B6E6441A439E605@qq.com> (raw)
Since boolean value is in 0 and 1, it's strange to combines a boolean
value with a bit operator.
Thus it's highly possible a typo error with "if (A & !B)", and more
probably to use "if (A & ~B)" instead.
Fixes: c1d4e9d37abdc6 ("net/txgbe: add queue stats mapping")
Signed-off-by: Weiguo Li <liwg06@foxmail.com>
---
drivers/net/txgbe/txgbe_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c
index 19d4444748..f0994f028d 100644
--- a/drivers/net/txgbe/txgbe_ethdev.c
+++ b/drivers/net/txgbe/txgbe_ethdev.c
@@ -376,7 +376,7 @@ txgbe_dev_queue_stats_mapping_set(struct rte_eth_dev *eth_dev,
if (hw->mac.type != txgbe_mac_raptor)
return -ENOSYS;
- if (stat_idx & !QMAP_FIELD_RESERVED_BITS_MASK)
+ if (stat_idx & ~QMAP_FIELD_RESERVED_BITS_MASK)
return -EIO;
PMD_INIT_LOG(DEBUG, "Setting port %d, %s queue_id %d to stat index %d",
--
2.25.1
next reply other threads:[~2022-03-01 6:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 6:08 Weiguo Li [this message]
2022-03-02 8:02 ` Jiawen Wu
2022-03-02 17:23 ` Ferruh Yigit
2022-03-03 13:31 ` Weiguo Li
2022-03-03 15:18 ` Ferruh Yigit
2022-03-03 16:16 ` Stephen Hemminger
2022-03-02 17:34 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_D18B07E35425224027E35B6E6441A439E605@qq.com \
--to=liwg06@foxmail.com \
--cc=dev@dpdk.org \
--cc=jiawenwu@trustnetic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).