From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D155BA034F; Tue, 1 Mar 2022 07:08:46 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BEA6B4113C; Tue, 1 Mar 2022 07:08:46 +0100 (CET) Received: from out203-205-251-73.mail.qq.com (out203-205-251-73.mail.qq.com [203.205.251.73]) by mails.dpdk.org (Postfix) with ESMTP id 328AA407FF for ; Tue, 1 Mar 2022 07:08:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1646114923; bh=pSNLZif8gExoRbkb4B/mvuxZdx763mYbSH8kjmxcRn0=; h=From:To:Cc:Subject:Date; b=Jr/S3KQHPwTGj0rQTfL+THVDOd+voc1Id/zm67qyxvZ875STSQzEcYeSKLEGTCB3+ 6ZOZNpVLJ4ijvtjzOFti2Hx5QSjo8/WIld9W2OnS5Kc8cok9UNECZDnXX60Lwbhe6k kEQyU69t8wd7loUimi4k/uN2RmeNmFauq8pMC/5U= Received: from localhost.localdomain ([111.193.130.237]) by newxmesmtplogicsvrsza5.qq.com (NewEsmtp) with SMTP id 21F0C4D6; Tue, 01 Mar 2022 14:08:31 +0800 X-QQ-mid: xmsmtpt1646114911tex9ysdma Message-ID: X-QQ-XMAILINFO: MsbTJfWJ9ga5v73luZHIW0HLKdj+69L8ToMElhmUYr3sedFamf3Fvze0Udsqe5 LkRqr2tzIWJ5HHp6ZGrppcchuNK5SsIjWTu+y+SeWnizDcA6o6Nt845FWdw808au6UlOP3CgjphA Zy+PmAkoHX6sJYIcOiwZ+1Y2GRWl6xWcvz6aaV4Te2Hb98Z4tIAymZrkFPvSvaiuVhA8rDbaQ1zk Sm3A8Gy2vpGpbcANmLELrQziPdYrLgh5uf8zSg8AO3X48EmSC0/pxVOSB5rS9Lxgl4eUi0TSUISE MYch2ynNwGjbhVB8C/L+f28x/YQQnDSurvxO4sECkRhjSWxvtcn8TjinXJQRB94l7mkyu3T639K9 DY+HMYe+h/cSL0VhDyojZT5LBKVgi0pAkhLEUUXIjTQZEzbioN7qMLXkdGrm6KA5E6fmsxZlXr5p I4GGQxaWIGIyv7txmu4NQJI837Uzu3UF5kX/fGsVRXcLYv4yD3+89jstS42EFnnWY5JFR/nzkHTi vlKtMmqGxODoISatDVZGr118BudxxFsvUEHG9sgJTb46rhAqpQxukl9fp/lYa1k/fHmuP0EjX5GR tuoFyo0DRCOInVbCJXMtmgpfHjRhKoTv9n2uAy/SyeWZaaV2xu+4uY7HxDuMuYUulFapqr4RWujV Yc04Kgg5yXWXtIT6wbFZsnjkBr7BE1Y3QnZ9a7U5E2Qis8gd7lccCV9ygM4DIr+6Z5qj4tyHerTD 2YRRazLwzIDUpD7tXJXRYt5Sn5It6F6LCJBfBNvP2mht+YzI/pRSz2fYmq90ZdHM8iGSn35t1UuL NbuM59EsOf2DazwF1z6JHNmg5vUSAw3iFQ1znvu1ayqGcpbYrdp9mDveKaByGvGqCLGsNPBEN4TE 8gYdfkFbVDZ1xDm5cE4Ij3o8svawFcLNz3TiRXkW8tokHpfHj8qoNB9GXDJw1yig== From: Weiguo Li To: jiawenwu@trustnetic.com Cc: dev@dpdk.org Subject: [PATCH] net/txgbe: fix a bit with boolean operator Date: Tue, 1 Mar 2022 14:08:30 +0800 X-OQ-MSGID: <20220301060830.480947-1-liwg06@foxmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Since boolean value is in 0 and 1, it's strange to combines a boolean value with a bit operator. Thus it's highly possible a typo error with "if (A & !B)", and more probably to use "if (A & ~B)" instead. Fixes: c1d4e9d37abdc6 ("net/txgbe: add queue stats mapping") Signed-off-by: Weiguo Li --- drivers/net/txgbe/txgbe_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index 19d4444748..f0994f028d 100644 --- a/drivers/net/txgbe/txgbe_ethdev.c +++ b/drivers/net/txgbe/txgbe_ethdev.c @@ -376,7 +376,7 @@ txgbe_dev_queue_stats_mapping_set(struct rte_eth_dev *eth_dev, if (hw->mac.type != txgbe_mac_raptor) return -ENOSYS; - if (stat_idx & !QMAP_FIELD_RESERVED_BITS_MASK) + if (stat_idx & ~QMAP_FIELD_RESERVED_BITS_MASK) return -EIO; PMD_INIT_LOG(DEBUG, "Setting port %d, %s queue_id %d to stat index %d", -- 2.25.1