From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B46A1A04B5; Fri, 2 Oct 2020 16:25:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6E9B71D8DF; Fri, 2 Oct 2020 16:25:45 +0200 (CEST) Received: from qq.com (out203-205-221-242.mail.qq.com [203.205.221.242]) by dpdk.org (Postfix) with ESMTP id 6B2FF1C29D; Fri, 2 Oct 2020 16:25:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1601648737; bh=jdTBuRr79VzJHqUZlXfs0uu54/J43p528Vw56Q+c014=; h=From:To:Cc:References:In-Reply-To:Subject:Date; b=f2oE4rZeJ0lI+EfbXOjopPmqB6LYcLG9eCrhqquDYLNYM1IUGuUOe5OqMfOdFCCUX 2uM5H1zNKSOUt0PkrIRix0O6F3PNLIQxSSao7gZfaBXgqnwIxX/NCFG1D7p8ceWlCv wDJjNyD4q37h3xfbPINrQ4f1qWdXAmCOM0dQxDI8= Received: from LAPTOPRI25L84I ([112.10.197.249]) by newxmesmtplogicsvrszc9.qq.com (NewEsmtp) with SMTP id 662AB419; Fri, 02 Oct 2020 22:25:34 +0800 X-QQ-mid: xmsmtpt1601648734taf38pvz0 Message-ID: X-QQ-XMAILINFO: Md1+5jvuxHHtKofT1IoHsBZmkoI2JK6wYKqqKPqDtFR1HoDW1S9Sm98IhGYY/a xnHpVCyBcx7HqZlDTdkP/7JHB/xT3pc7qD/vcwr/G4/mDMUwjdW9/fHbjUTi4iR+/RAIryNyO3PA GLMypDGevHfEox3ODGs0jdBn/jnkwIvRdkbv+AzVcZTkN6jFfxUJOHE7171/eebVnDc6qf6KEkPd q1bNSrR0RqBJ6aozUwZmSZTId4J4qAS3VdDLO5cWHrctOJazcIvZYQl08rZfzSL81dXXO9saz0V+ jROaO4M6G9SrXvaqmDBJAStxR5iByzBNvnroGYsVHh4JJ60UR87Sf9tAHESaBsXg7RMt+Vzz/+mF /S9RbXPfqjwh1sMJLwey8JM6N6ZI6UabqZgU8++e5+frygPQnWx77O8Gqb3PAUA06Xv7yf0E4E9M bknWNdVhPVwLJAsBm/htHBvy4aw6Ub1WlCTuk8U+xgbQ8yV/qQcYC2f/wJp6/hxuIHcC/+TUSc8m xny8+15+HlrxFfm7L/6RKZt8lT1hEylI8+akcAuuvfzz3OinE9K5OewBMQ9++c6tYQexBsh5UJlg 1H/+a/tk5QrgYihVNku1RE8XqTokdT1LotlWaB8U4EP1UwlZgDba1d4os+moTPdoakRCSM7aUX+r B35GcxSdT9pkkOrPEPozz+IHH9A643ypPiciCfFhJvdBrvFNyAMt5BdYguFsjInNL5bP4K51eSBu Lx9HNgMg0iD+tpfSB7UU+7zUam0uIy5fDewby/lkKOpFs= From: "Yunjian Wang" To: "'Long Li'" , "'wangyunjian'" , Cc: "'Stephen Hemminger'" , "'KY Srinivasan'" , "'Haiyang Zhang'" , , , References: In-Reply-To: Date: Fri, 2 Oct 2020 22:25:33 +0800 X-OQ-MSGID: <000601d698c7$e4753a10$ad5fae30$@foxmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 15.0 Content-Language: zh-cn Thread-Index: AQFOCDw6BOFsCwayu2DSv7JjqwkUKgG+J8W8qoeNwwA= Subject: Re: [dpdk-dev] [PATCH] net/netvsc: fix txq leak in error path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Long Li > Sent: Thursday, October 1, 2020 6:27 AM > To: wangyunjian ; dev@dpdk.org > Cc: Stephen Hemminger ; KY Srinivasan > ; Haiyang Zhang ; > jerry.lilijun@huawei.com; xudingke@huawei.com; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/netvsc: fix txq leak in error path > > >Subject: [dpdk-dev] [PATCH] net/netvsc: fix txq leak in error path > > > >From: Yunjian Wang > > > >In hn_dev_tx_queue_setup() allocated memory for txq, we should free it > >when error happens, otherwise it will lead to memory leak. > > > >Fixes: cc0251813277 ("net/netvsc: split send buffers from Tx > >descriptors") > >Cc: stable@dpdk.org > > > >Signed-off-by: Yunjian Wang > >--- > > drivers/net/netvsc/hn_rxtx.c | 1 + > > 1 file changed, 1 insertion(+) > > > >diff --git a/drivers/net/netvsc/hn_rxtx.c > >b/drivers/net/netvsc/hn_rxtx.c index 65f1abae5..8c94e7ee3 100644 > >--- a/drivers/net/netvsc/hn_rxtx.c > >+++ b/drivers/net/netvsc/hn_rxtx.c > >@@ -273,6 +273,7 @@ hn_dev_tx_queue_setup(struct rte_eth_dev *dev, > > " (tx_free_thresh=%u port=%u queue=%u)\n", > > nb_desc - 3, > > tx_free_thresh, dev->data->port_id, queue_idx); > >+ rte_free(txq); > > return -EINVAL; > > } > > > >-- > >2.23.0 > > How about checking for tx_free_thresh at the beginning of the function, > before calling txq = rte_zmalloc_socket()? > > This way, you don't' need to call rte_free() on error. OK, I will fix it in next version. Thanks, Yunjian > > Long