From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1925FA0032; Fri, 18 Feb 2022 18:33:20 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DDDB34014E; Fri, 18 Feb 2022 18:33:19 +0100 (CET) Received: from out203-205-221-202.mail.qq.com (out203-205-221-202.mail.qq.com [203.205.221.202]) by mails.dpdk.org (Postfix) with ESMTP id 9CEFE40141 for ; Fri, 18 Feb 2022 18:33:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1645205580; bh=RKqshjpQ2Fbr05qMdo3QCy4zqvQbujEpdwLqI3S80Iw=; h=From:To:Cc:Subject:Date; b=sqZmRiZ5EnfADETYtt6UKLFAjzgIihOU5uFuBRGxenp3jQ2UX3WLejgo2dXsjnM+R ObMRV857TEzhfQbyrL6TcUiqGTgTYIT6gN9pvlVf9dwXhvn2KiAtIk7rqWPyBYslXY LkGLRfR+IAcTqf3sBOcbrbab8fx6wPTDWOWQbVhA= Received: from localhost.localdomain ([111.193.130.237]) by newxmesmtplogicsvrszc9.qq.com (NewEsmtp) with SMTP id 831092CB; Sat, 19 Feb 2022 01:32:49 +0800 X-QQ-mid: xmsmtpt1645205569tx1afuq9p Message-ID: X-QQ-XMAILINFO: OGnvtX49Nnpxql+XddExwmUTsVptEYLwPvkxHGPHmVwkRA723sOMH4UuEDMr3p gw6gJ4Pt3brWl7/WC9wOdxHj1XGuv+YsGZOEDNiQbgtaYVRYVE80zCZa3HgJwBwonskqgjKg1Z9y NUDvgC4GYE9Cu+ZiKYuhbh3Nk3C/rnSu0OpszEGx6KmNL0zjNlDt9znUB3OHJg1KxWlQeaBIPHvb UKUQ+BX50drJsNG6Jm2p2Xb/kinCuLGCgraRaIy5a0GerAYEEA4NBsrA27fBoMBJAxwS4D28immt UYtQ0hKoI1oykAWhmRgn9sF1A8UI4CiV7iJROvR4jib2h8flK0WJ0zF+wi24oX4Xrtx4Wc1vRlLd XvETwOgKMm15svsD/NINtC6CHr1WR4Y5pxspUKnNAIexXnZqp1wAHiljD2guLxJX9tNnm+g3Zi3q h0Hq8hqLk9fIhixfq+7MKmspLnQnDEER90yC/lh2DxIPhri5ngjq+jFDLdjFgT12K/DFssE4g5on 3wEBaBYrZb7mpalW5B30CJwe3yIXC1mBcq+vNUjZpqoBGT7m9uwVYE25U0hcDYI+1TDntD5kx8ya a3pIvuOly2xc5IQmXKNimmHkLukWsDmbDZjS1vu856M7cVVlEuMecVUp6xL/4Xcoi/PZvT/ykCti AcltAAggye21buzhXCZR9UDf5v8ZEV3lMfisbnCbH13380s5Uaep1xyUCagvsM/VK7ZcWba9hEsR WRR2C4QxfaD6h4TIIhXTYuc+WzacrI0N9EQDNiep4evYPToaRzwhtMsGUT4X1oblgddvmfk7I8/n a+GRsU0baj0B1NoLNZwWLMVwVZkPhCJ0eNBYusGPLD9BpRGl2jWoUzmSaoE5krm8/IBuryxv3OwD dYeepz6lGMMUovSovIorr9euuEH9CsOVqXzot0zc6h From: Weiguo Li To: hemant.agrawal@nxp.com Cc: shreyansh.jain@nxp.com, dev@dpdk.org Subject: [PATCH] common/dpaax: fix a memory leak in iterate dir Date: Sat, 19 Feb 2022 01:32:48 +0800 X-OQ-MSGID: <20220218173248.493656-1-liwg06@foxmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Release the memory when error occur. Fixes: 2183c6f69d7e ("bus/dpaa: add OF parser for device scanning") Signed-off-by: Weiguo Li --- drivers/common/dpaax/dpaa_of.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/common/dpaax/dpaa_of.c b/drivers/common/dpaax/dpaa_of.c index bb2c8fc66b..a827b42efa 100644 --- a/drivers/common/dpaax/dpaa_of.c +++ b/drivers/common/dpaax/dpaa_of.c @@ -126,8 +126,10 @@ iterate_dir(struct dirent **d, int num, struct dt_dir *dt) d[loop]->d_name); subdir->parent = dt; ret = process_dir(subdir->node.node.full_name, subdir); - if (ret) + if (ret) { + free(subdir); return ret; + } list_add_tail(&subdir->node.list, &dt->subdirs); break; default: -- 2.25.1