DPDK patches and discussions
 help / color / mirror / Atom feed
From: chengtcli@qq.com
To: dev@dpdk.org
Cc: lic121 <lic121@chinatelecom.cn>
Subject: [PATCH] eal: zero out new added memory
Date: Sat, 27 Aug 2022 09:25:47 +0000	[thread overview]
Message-ID: <tencent_F3597A23B9EE72C7633E44F78D66D01F1109@qq.com> (raw)

From: lic121 <lic121@chinatelecom.cn>

When RTE_MALLOC_DEBUG not configured, rte_zmalloc_socket() doens't
zero oute allocaed memory. Because memory are zeroed out when free
in malloc_elem_free(). But seems the initial allocated memory is
not zeroed out as expected.

This patch zero out initial allocated memory in
malloc_heap_add_memory().

With dpdk 20.11.5, "QLogic Corp. FastLinQ QL41000" probe triggers
this problem.
```
  Stack trace of thread 412780:
  #0  0x0000000000e5fb99 ecore_int_igu_read_cam (dpdk-testpmd)
  #1  0x0000000000e4df54 ecore_get_hw_info (dpdk-testpmd)
  #2  0x0000000000e504aa ecore_hw_prepare (dpdk-testpmd)
  #3  0x0000000000e8a7ca qed_probe (dpdk-testpmd)
  #4  0x0000000000e83c59 qede_common_dev_init (dpdk-testpmd)
  #5  0x0000000000e84c8e qede_eth_dev_init (dpdk-testpmd)
  #6  0x00000000009dd5a7 rte_pci_probe_one_driver (dpdk-testpmd)
  #7  0x00000000009734e3 rte_bus_probe (dpdk-testpmd)
  #8  0x00000000009933bd rte_eal_init (dpdk-testpmd)
  #9  0x000000000041768f main (dpdk-testpmd)
  #10 0x00007f41a7001b17 __libc_start_main (libc.so.6)
  #11 0x000000000067e34a _start (dpdk-testpmd)
```

Signed-off-by: lic121 <lic121@chinatelecom.cn>
---
 lib/librte_eal/common/malloc_heap.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/lib/librte_eal/common/malloc_heap.c b/lib/librte_eal/common/malloc_heap.c
index f4e20ea..1607401 100644
--- a/lib/librte_eal/common/malloc_heap.c
+++ b/lib/librte_eal/common/malloc_heap.c
@@ -96,11 +96,19 @@
 		void *start, size_t len)
 {
 	struct malloc_elem *elem = start;
+	void *ptr;
+	size_t data_len
+
 
 	malloc_elem_init(elem, heap, msl, len, elem, len);
 
 	malloc_elem_insert(elem);
 
+	/* Zero out new added memory. */
+	*ptr = RTE_PTR_ADD(elem, MALLOC_ELEM_HEADER_LEN);
+	data_len = elem->size - MALLOC_ELEM_OVERHEAD;
+	memset(ptr, 0, data_len);
+
 	elem = malloc_elem_join_adjacent_free(elem);
 
 	malloc_elem_free_list_insert(elem);
-- 
1.8.3.1


             reply	other threads:[~2022-08-27  9:26 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-27  9:25 chengtcli [this message]
2022-08-27  9:57 ` Dmitry Kozlyuk
2022-08-27 13:31   ` lic121
2022-08-27 14:56     ` Dmitry Kozlyuk
2022-08-29  1:18       ` lic121
2022-08-29 11:37         ` lic121
2022-08-29 11:57           ` David Marchand
2022-08-29 12:37             ` Morten Brørup
2022-08-29 12:43               ` David Marchand
2022-08-29 12:49               ` Dmitry Kozlyuk
2022-08-30  1:11                 ` lic121
2022-08-30  9:49                   ` lic121
2022-08-30 10:59                     ` Dmitry Kozlyuk
2022-08-30 12:47                       ` lic121
2022-08-30 12:53                       ` lic121
2022-09-03 13:53                         ` lic121

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_F3597A23B9EE72C7633E44F78D66D01F1109@qq.com \
    --to=chengtcli@qq.com \
    --cc=dev@dpdk.org \
    --cc=lic121@chinatelecom.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).