From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Matan Azrad <matan@mellanox.com>
Cc: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 1/2] net/mlx5: link status update separation
Date: Mon, 11 Sep 2017 17:12:16 +0100 [thread overview]
Message-ID: <df25e036-c9af-f527-c686-205d2a85670d@intel.com> (raw)
In-Reply-To: <20170906151414.GY4301@6wind.com>
On 9/6/2017 4:14 PM, Adrien Mazarguil wrote:
> On Wed, Sep 06, 2017 at 06:03:57PM +0300, Matan Azrad wrote:
>> Link status is sometimes inconsistent during a LSC event.
>> When it occurs, the PMD refrains from immediately notifying
>> the application; instead, an alarm is scheduled to check
>> link status later and notify the application once it has settled.
>>
>> In the previous code the alarm callback calls to the interrupt
>> handler for link status recheck and may cause to unnecessary
>> interrupt events check.
>>
>> This patch separates the link status update and the interrupt event
>> handler to avoid the unnecessary check and arranges the interrupt
>> handler for more interrupt supports in the future.
>>
>> Comment was added in the new function to explain the inconsistent
>> link status reason.
>>
>> Signed-off-by: Matan Azrad <matan@mellanox.com>
>
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2017-09-11 16:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 15:03 Matan Azrad
2017-09-06 15:03 ` [dpdk-dev] [PATCH v4 2/2] net/mlx5: support device removal event Matan Azrad
2017-09-06 15:14 ` Adrien Mazarguil
2017-09-08 10:05 ` Ferruh Yigit
2017-09-08 10:47 ` [dpdk-dev] [PATCH v5] " Matan Azrad
2017-09-11 16:12 ` Ferruh Yigit
2017-09-06 15:14 ` [dpdk-dev] [PATCH v4 1/2] net/mlx5: link status update separation Adrien Mazarguil
2017-09-11 16:12 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df25e036-c9af-f527-c686-205d2a85670d@intel.com \
--to=ferruh.yigit@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=nelio.laranjeiro@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).