From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Keith Wiles <keith.wiles@intel.com>
Cc: Thomas Monjalon <thomas@monjalon.net>, dpdk-dev <dev@dpdk.org>,
Luca Boccassi <bluca@debian.org>
Subject: Re: [dpdk-dev] [PATCH v2] usertools: script to output version string
Date: Wed, 23 Jan 2019 19:16:11 +0000 [thread overview]
Message-ID: <df924d39-5d67-27fb-a666-48a8207e9158@intel.com> (raw)
In-Reply-To: <AAE7E39C-ECAE-488D-B69C-F9D644C7AC9C@intel.com>
On 8/7/2017 6:31 PM, keith.wiles at intel.com (Wiles, Keith) wrote:
>> On Aug 7, 2017, at 11:49 AM, Thomas Monjalon <thomas at monjalon.net> wrote:
>>
>> 07/08/2017 15:17, Wiles, Keith:
>>>
>>>> On Aug 7, 2017, at 6:35 AM, Thomas Monjalon <thomas at monjalon.net> wrote:
>>>>
>>>> Hi,
>>>>
>>>> 06/07/2017 16:56, Keith Wiles:
>>>>> +# Locate the rte_version.h file and parse out the version strings.
>>>>
>>>> I think this script is not needed because we have already
>>>> something in mk/rte.sdkconfig.mk.
>>>> Example:
>>>> % make showversion
>>>> 17.08.0-rc4
>>>
>>> Executing make to find out a version seems to bit of over kill to me and a simple script would be much easier IMO. I do not really see harm in having this script that can output the version into different formats is helpful when running external scripts. Also in the future we are most like going to replace the build system and then we would need to add this support to that build system and having it in a standalone script is easier manage in the long run.
>>
>> "make showversion" is here for several years.
>> Usually we do not implement the same thing in several places
>> without a good reason.
>> And some users can use the old command.
>> Especially when talking about versions, it is very convenient
>> to use the same command in every versions.
>
> I grep?d the repo and found couple references to showversion.
>
> ./devtools/git-log-fixes.sh:72: make showversion | cut -d'.' -f-2
> ./doc/guides/conf.py:67:version = subprocess.check_output(['make', '-sRrC', '../../', 'showversion'])
> ./mk/rte.sdkconfig.mk:32:.PHONY: showversion
> ./mk/rte.sdkconfig.mk:33:showversion:
> ./mk/rte.sdkconfig.mk:45:.PHONY: showversionum
> ./mk/rte.sdkconfig.mk:46:showversionum:
> ./mk/rte.sdkdoc.mk:76: $(MAKE) -rRs showversion && \
> ./mk/rte.sdkroot.mk:91:.PHONY: config defconfig showconfigs showversion showversionum
> ./mk/rte.sdkroot.mk:92:config defconfig showconfigs showversion showversionum:
>
>
> Which means to me this was a completely undocumented feature, which is why I created this shell script. This also means the feature was not used widely. Then I suggest we remove the 'make showversion' and use the script in the usertools dir, which is easier to find and does not require the use of Make or Makefile at all. The script allows you to print the version from any directory as long as RTE_SDK is defined or if you are located in a SDK directory. Also allows the developer/user to execute dpdk-version.sh from the installed location or the RTE_SDK/usertools directory. I have the changes already to install dpdk-version.h tool during build like the other tools, but have not submitted it yet. I can also update the documents to help users find the tool.
Hi Keith,
This patch is also sitting in the patchwork for a long time without a decision.
I am not against this script explicitly, but we already has a solution what this
script does and I don't see the motivation to replace it.
Perhaps we may need it when switched to meson, I don't know if we have a
solution in meson, cc'ed Luca for comment.
Unless there is a demand/need for it, I am for updating it as rejected.
Thanks,
ferruh
>
>>
>> That's why I insist: why implementing it differently?
>> If it is only about the new build system, it should be part
>> of the build system migration plan (long term).
>
> Regards,
> Keith
>
>
next prev parent reply other threads:[~2019-01-23 19:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 14:56 Keith Wiles
2017-08-07 11:35 ` Thomas Monjalon
2017-08-07 13:17 ` Wiles, Keith
2017-08-07 16:49 ` Thomas Monjalon
2017-08-07 17:31 ` Wiles, Keith
2019-01-23 19:16 ` Ferruh Yigit [this message]
2019-03-01 16:46 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df924d39-5d67-27fb-a666-48a8207e9158@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bluca@debian.org \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).