From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Levend Sayar <levendsayar@gmail.com>, junfeng.guo@intel.com
Cc: dev@dpdk.org
Subject: Re: [PATCH v2 1/4] net/gve: change offloading capability
Date: Fri, 17 Feb 2023 12:43:06 +0000 [thread overview]
Message-ID: <dfd7c61d-db86-4b01-cca8-a9c3c0d62a5e@amd.com> (raw)
In-Reply-To: <20230216181025.23485-1-levendsayar@gmail.com>
On 2/16/2023 6:10 PM, Levend Sayar wrote:
> Google Virtual NIC is not doing IPv4 checksummimg.
> Removed that capability from PMD.
>
> Signed-off-by: Levend Sayar <levendsayar@gmail.com>
> ---
> drivers/net/gve/gve_ethdev.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c
> index 97781f0ed3..e357f16e16 100644
> --- a/drivers/net/gve/gve_ethdev.c
> +++ b/drivers/net/gve/gve_ethdev.c
> @@ -282,7 +282,6 @@ gve_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
> dev_info->rx_offload_capa = 0;
> dev_info->tx_offload_capa =
> RTE_ETH_TX_OFFLOAD_MULTI_SEGS |
> - RTE_ETH_TX_OFFLOAD_IPV4_CKSUM |
> RTE_ETH_TX_OFFLOAD_UDP_CKSUM |
> RTE_ETH_TX_OFFLOAD_TCP_CKSUM |
> RTE_ETH_TX_OFFLOAD_SCTP_CKSUM |
Hi Levend,
there are multiple version of same patch, it is confusing for reviewers
and maintainers.
Can you please:
- User versions tag, and keep increasing it. Like this one has v2, which
is good, but next one sent after this doesn't have any version tag.
- Use git send-email '--in-reply-to' parameter to keep all versions in
same email thread. More details on documentation:
https://doc.dpdk.org/guides/contributing/patches.html#sending-patches
- Clean patchwork after a new version sent by marking old version
appropriately (most of times as 'superseded')
https://patches.dpdk.org/project/dpdk/list/?submitter=1813
Thanks,
ferruh
next prev parent reply other threads:[~2023-02-17 12:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 18:10 Levend Sayar
2023-02-16 18:10 ` [PATCH v2 2/4] net/gve: add standard and extended statistics Levend Sayar
2023-02-17 12:49 ` Ferruh Yigit
2023-02-16 18:10 ` [PATCH v2 3/4] " Levend Sayar
2023-02-16 18:10 ` [PATCH v2 4/4] " Levend Sayar
2023-02-17 12:43 ` Ferruh Yigit [this message]
2023-02-18 6:28 ` [PATCH v2 1/4] net/gve: change offloading capability Levend Sayar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfd7c61d-db86-4b01-cca8-a9c3c0d62a5e@amd.com \
--to=ferruh.yigit@amd.com \
--cc=dev@dpdk.org \
--cc=junfeng.guo@intel.com \
--cc=levendsayar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).