test suite reviews and discussions
 help / color / mirror / Atom feed
* Re: [dts] [PATCH] Remove RSS on sctp packets test due to fm10k HW unsupport
       [not found] <1470909839-30634-1-git-send-email-xlin15@shecgisg005.sh.intel.com>
@ 2016-08-12  5:32 ` Liu, Yong
  2016-08-12  5:51   ` Lin, Xueqin
  0 siblings, 1 reply; 2+ messages in thread
From: Liu, Yong @ 2016-08-12  5:32 UTC (permalink / raw)
  To: xueqin.lin, dts; +Cc: Lin, Xueqin

Hi Xueqin,
There's one more clear and easy way to remove sctp RSS validation.

if self.kdriver in ["fm10k"]:
	iptypes.pop('ipv6-sctp')

> -----Original Message-----
> From: xueqin.lin [mailto:xlin15@ecsmtp.sh.intel.com]
> Sent: Thursday, August 11, 2016 6:04 PM
> To: Liu, Yong; dts@dpdk.org
> Cc: Lin, Xueqin
> Subject: [dts][PATCH] Remove RSS on sctp packets test due to fm10k HW
> unsupport
> 
> From: Xueqin Lin <xueqin.lin@intel.com>
> 
> Refer to fm10k datasheet 11.27.2.30,RSS on sctp packets is not supported
> by HW.
> 
> ---
>  tests/TestSuite_pmdrss_hash.py | 38 ++++++++++++++++++++++++-------------
> -
>  1 file changed, 24 insertions(+), 14 deletions(-)
> 
> diff --git a/tests/TestSuite_pmdrss_hash.py
> b/tests/TestSuite_pmdrss_hash.py
> index 0cb703b..14e6596 100644
> --- a/tests/TestSuite_pmdrss_hash.py
> +++ b/tests/TestSuite_pmdrss_hash.py
> @@ -545,20 +545,30 @@ class TestPmdrssHash(TestCase):
>          localPort = self.tester.get_local_port(dutPorts[0])
>          itf = self.tester.get_interface(localPort)
>          global reta_num
> -        iptypes = {'ipv4-sctp': 'sctp',
> -                   'ipv4-other': 'ip',
> -                   'ipv4-frag': 'ip',
> -                   'ipv4-udp': 'udp',
> -                   'ipv4-tcp': 'tcp',
> -                   # this hass not support in dpdk 2.0
> -                   # 'l2_payload':'ether',
> -                   'ipv6-other': 'ip',
> -                   'ipv6-sctp': 'ip',
> -                   'ipv6-udp': 'udp',
> -                   'ipv6-tcp': 'tcp',
> -                   'ipv6-frag': 'ip'
> -                   }
> -
> +        if self.kdriver not in ["fm10k"]:
> +            iptypes = { 'ipv4-sctp': 'sctp',
> +                        'ipv4-other': 'ip',
> +                        'ipv4-frag': 'ip',
> +                        'ipv4-udp': 'udp',
> +                        'ipv4-tcp': 'tcp',
> +                        # this hass not support in dpdk 2.0
> +                        # 'l2_payload':'ether',
> +                        'ipv6-other': 'ip',
> +                        'ipv6-sctp': 'ip',
> +                        'ipv6-udp': 'udp',
> +                        'ipv6-tcp': 'tcp',
> +                        'ipv6-frag': 'ip'
> +                        }
> +        else:
> +            iptypes = { 'ipv4-other': 'ip',
> +                        'ipv4-frag': 'ip',
> +                        'ipv4-udp': 'udp',
> +                        'ipv4-tcp': 'tcp',
> +                        'ipv6-other': 'ip',
> +                        'ipv6-udp': 'udp',
> +                        'ipv6-tcp': 'tcp',
> +                        'ipv6-frag': 'ip'
> +                        }
>          self.dut.kill_all()
> 
>          # test with different rss queues
> --
> 2.5.5

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH] Remove RSS on sctp packets test due to fm10k HW unsupport
  2016-08-12  5:32 ` [dts] [PATCH] Remove RSS on sctp packets test due to fm10k HW unsupport Liu, Yong
@ 2016-08-12  5:51   ` Lin, Xueqin
  0 siblings, 0 replies; 2+ messages in thread
From: Lin, Xueqin @ 2016-08-12  5:51 UTC (permalink / raw)
  To: Liu, Yong, xueqin.lin, dts

Great.  I will use this API and send patch again, thanks.

> -----Original Message-----
> From: Liu, Yong
> Sent: Friday, August 12, 2016 1:33 PM
> To: xueqin.lin; dts@dpdk.org
> Cc: Lin, Xueqin
> Subject: RE: [dts][PATCH] Remove RSS on sctp packets test due to fm10k HW
> unsupport
> 
> Hi Xueqin,
> There's one more clear and easy way to remove sctp RSS validation.
> 
> if self.kdriver in ["fm10k"]:
> 	iptypes.pop('ipv6-sctp')
> 
> > -----Original Message-----
> > From: xueqin.lin [mailto:xlin15@ecsmtp.sh.intel.com]
> > Sent: Thursday, August 11, 2016 6:04 PM
> > To: Liu, Yong; dts@dpdk.org
> > Cc: Lin, Xueqin
> > Subject: [dts][PATCH] Remove RSS on sctp packets test due to fm10k HW
> > unsupport
> >
> > From: Xueqin Lin <xueqin.lin@intel.com>
> >
> > Refer to fm10k datasheet 11.27.2.30,RSS on sctp packets is not supported
> > by HW.
> >
> > ---
> >  tests/TestSuite_pmdrss_hash.py | 38 ++++++++++++++++++++++++---------
> ----
> > -
> >  1 file changed, 24 insertions(+), 14 deletions(-)
> >
> > diff --git a/tests/TestSuite_pmdrss_hash.py
> > b/tests/TestSuite_pmdrss_hash.py
> > index 0cb703b..14e6596 100644
> > --- a/tests/TestSuite_pmdrss_hash.py
> > +++ b/tests/TestSuite_pmdrss_hash.py
> > @@ -545,20 +545,30 @@ class TestPmdrssHash(TestCase):
> >          localPort = self.tester.get_local_port(dutPorts[0])
> >          itf = self.tester.get_interface(localPort)
> >          global reta_num
> > -        iptypes = {'ipv4-sctp': 'sctp',
> > -                   'ipv4-other': 'ip',
> > -                   'ipv4-frag': 'ip',
> > -                   'ipv4-udp': 'udp',
> > -                   'ipv4-tcp': 'tcp',
> > -                   # this hass not support in dpdk 2.0
> > -                   # 'l2_payload':'ether',
> > -                   'ipv6-other': 'ip',
> > -                   'ipv6-sctp': 'ip',
> > -                   'ipv6-udp': 'udp',
> > -                   'ipv6-tcp': 'tcp',
> > -                   'ipv6-frag': 'ip'
> > -                   }
> > -
> > +        if self.kdriver not in ["fm10k"]:
> > +            iptypes = { 'ipv4-sctp': 'sctp',
> > +                        'ipv4-other': 'ip',
> > +                        'ipv4-frag': 'ip',
> > +                        'ipv4-udp': 'udp',
> > +                        'ipv4-tcp': 'tcp',
> > +                        # this hass not support in dpdk 2.0
> > +                        # 'l2_payload':'ether',
> > +                        'ipv6-other': 'ip',
> > +                        'ipv6-sctp': 'ip',
> > +                        'ipv6-udp': 'udp',
> > +                        'ipv6-tcp': 'tcp',
> > +                        'ipv6-frag': 'ip'
> > +                        }
> > +        else:
> > +            iptypes = { 'ipv4-other': 'ip',
> > +                        'ipv4-frag': 'ip',
> > +                        'ipv4-udp': 'udp',
> > +                        'ipv4-tcp': 'tcp',
> > +                        'ipv6-other': 'ip',
> > +                        'ipv6-udp': 'udp',
> > +                        'ipv6-tcp': 'tcp',
> > +                        'ipv6-frag': 'ip'
> > +                        }
> >          self.dut.kill_all()
> >
> >          # test with different rss queues
> > --
> > 2.5.5

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-08-12  5:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1470909839-30634-1-git-send-email-xlin15@shecgisg005.sh.intel.com>
2016-08-12  5:32 ` [dts] [PATCH] Remove RSS on sctp packets test due to fm10k HW unsupport Liu, Yong
2016-08-12  5:51   ` Lin, Xueqin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).