test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Lin, Xueqin" <xueqin.lin@intel.com>
To: "Liu, Yong" <yong.liu@intel.com>,
	xueqin.lin <xlin15@ecsmtp.sh.intel.com>,
	 "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH] tests ftag: add get_glortid_bymac function for Boulder Rapid
Date: Tue, 16 Aug 2016 05:11:01 +0000	[thread overview]
Message-ID: <0D300480287911409D9FF92C1FA2A3351A7C3BAC@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E2226ED94@SHSMSX103.ccr.corp.intel.com>

OK, thanks. Will fix and send patch again.

> -----Original Message-----
> From: Liu, Yong
> Sent: Tuesday, August 16, 2016 9:08 AM
> To: xueqin.lin; dts@dpdk.org
> Cc: Lin, Xueqin
> Subject: RE: [dts][PATCH] tests ftag: add get_glortid_bymac function for
> Boulder Rapid
> 
> Hi Xueqin, one comment.
> 
> > -----Original Message-----
> > From: xueqin.lin [mailto:xlin15@ecsmtp.sh.intel.com]
> > Sent: Monday, August 15, 2016 4:42 PM
> > To: Liu, Yong; dts@dpdk.org
> > Cc: Lin, Xueqin
> > Subject: [dts][PATCH] tests ftag: add get_glortid_bymac function for
> > Boulder Rapid
> >
> > From: Xueqin Lin <xueqin.lin@intel.com>
> >
> > Enable ftag funtion test on Boulder Rapid, need to strip port logic value
> > from mac table
> > then strip port glort ID from stacking information.
> >
> > diff --git a/nics/br.py b/nics/br.py
> > index 5b6e778..0151fbb 100644
> > --- a/nics/br.py
> > +++ b/nics/br.py
> > @@ -29,6 +29,7 @@
> >  # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF
> THE USE
> >  # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
> DAMAGE.
> >
> > +import re
> >  from crb import Crb
> >  from config import PortConf, PORTCONF
> >  from exception import PortConfigParseException
> > @@ -243,3 +244,32 @@ class BoulderRapid(NetDevice):
> >              self.ctrl_crb.send_expect("set port config 1
> > max_frame_size %d" % framesize, "<0>%")
> >          else:
> >              self.ctrl_crb.send_expect("set port config 5
> > max_frame_size %d" % framesize, "<0>%")
> > +
> > +    def get_glortid_bymac(self, dmac):
> > +        out = self.ctrl_crb.send_expect("show mac table all", "<0>%")
> > +        pattern = r"([0-9a-f]{2}:){5}([0-9a-f]{2})"
> > +        s = re.compile(pattern)
> > +        res = s.search(dmac)
> > +        if res is None:
> > +            print "search none mac filter"
> > +            return None
> > +        else:
> > +            mac_filter = res.group(2)
> > +        pattern = r"(?<=%s)+([\sA-Za-z0-9/])+([0-9]{4})" %mac_filter
> > +        s = re.compile(pattern)
> > +        res = s.search(out)
> > +        if res is None:
> > +            print "search none port value"
> > +            return None
> > +        else:
> > +            port_value = res.group(2)
> > +        out = self.ctrl_crb.send_expect("show stacking logical-port all",
> > "<0>%",10000)
> It's impossible to wait some long for expected output. Most of times, we will
> leave it to default value.
> 
> > +        pattern = r"([0-9a-z]{6})+(\s)+(%s)+" %port_value
> > +        s = re.compile(pattern)
> > +        res = s.search(out)
> > +        if res is None:
> > +            print "search none port glort id"
> > +            return None
> > +        else:
> > +            port_glortid = res.group(1)
> > +            return port_glortid
> > --
> > 2.5.5

  reply	other threads:[~2016-08-16  5:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1471250498-20380-1-git-send-email-xlin15@shecgisg005.sh.intel.com>
2016-08-16  1:07 ` Liu, Yong
2016-08-16  5:11   ` Lin, Xueqin [this message]
     [not found] <1471500774-2748-1-git-send-email-xlin15@shecgisg005.sh.intel.com>
2016-08-18  7:39 ` Liu, Yong
2016-08-18  7:53   ` Lin, Xueqin
     [not found] <1471508360-29089-1-git-send-email-xlin15@shecgisg005.sh.intel.com>
2016-08-19  2:57 ` Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0D300480287911409D9FF92C1FA2A3351A7C3BAC@SHSMSX103.ccr.corp.intel.com \
    --to=xueqin.lin@intel.com \
    --cc=dts@dpdk.org \
    --cc=xlin15@ecsmtp.sh.intel.com \
    --cc=yong.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).