From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id DAB61A0096 for ; Thu, 14 Mar 2019 11:20:17 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A7DAB3572; Thu, 14 Mar 2019 11:20:17 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id D64A92C28 for ; Thu, 14 Mar 2019 11:20:15 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Mar 2019 03:20:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,478,1544515200"; d="scan'208";a="131574658" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga008.fm.intel.com with ESMTP; 14 Mar 2019 03:20:13 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 14 Mar 2019 03:20:12 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 14 Mar 2019 03:20:10 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.74]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.57]) with mapi id 14.03.0415.000; Thu, 14 Mar 2019 18:20:08 +0800 From: "Lin, Xueqin" To: "Tu, Lijuan" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH] test_plans/vf_rss: correct grammar and command Thread-Index: AQHU2kgKu1m+iduImUmUx1USRJm7lqYK6Z8w Date: Thu, 14 Mar 2019 10:20:08 +0000 Message-ID: <0D300480287911409D9FF92C1FA2A3355B4BBB42@SHSMSX104.ccr.corp.intel.com> References: <1551929701-124895-1-git-send-email-xueqin.lin@intel.com> <8CE3E05A3F976642AAB0F4675D0AD20E0BA42DEB@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <8CE3E05A3F976642AAB0F4675D0AD20E0BA42DEB@SHSMSX101.ccr.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH] test_plans/vf_rss: correct grammar and command X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" I didn't do any change for this part except correcting capital. Are you agr= ee to delete " Prerequisites " part? Best regards, Xueqin > -----Original Message----- > From: Tu, Lijuan > Sent: Thursday, March 14, 2019 5:27 PM > To: Lin, Xueqin ; dts@dpdk.org > Cc: Lin, Xueqin > Subject: RE: [dts] [PATCH] test_plans/vf_rss: correct grammar and command >=20 > Comments inline >=20 > > -----Original Message----- > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xueqin Lin > > Sent: Thursday, March 7, 2019 11:35 AM > > To: dts@dpdk.org > > Cc: Lin, Xueqin > > Subject: [dts] [PATCH] test_plans/vf_rss: correct grammar and command > > > > Signed-off-by: Xueqin Lin > > > > --- > > test_plans/vf_rss_test_plan.rst | 32 ++++++++++++++++---------------- > > 1 file changed, 16 insertions(+), 16 deletions(-) > > > > diff --git a/test_plans/vf_rss_test_plan.rst > > b/test_plans/vf_rss_test_plan.rst index c425227..40c2834 100644 > > --- a/test_plans/vf_rss_test_plan.rst > > +++ b/test_plans/vf_rss_test_plan.rst > > @@ -45,9 +45,9 @@ Prerequisites > > * 1x Fortville_spirit NIC (2x 40G) > > * 2x Fortville_spirit_single NIC (1x 40G) > > > > -The one port of the 82599 connect to the Fortville_eagle; -The one > > port of Fortville_spirit connect to Fortville_spirit_single. > > -The three kinds of NICs are the target NICs. the connected NICs can > > send packets > > +The one port of the 82599 connects to the Fortville_eagle; The one > > +port of Fortville_spirit connects to Fortville_spirit_single. > > +The three kinds of NICs are the target NICs, the connected NICs can > > +send packets > > to these three NICs using scapy. > [Lijuan] I think port connection should be more common, we don't require > the specific connection. It's ok for 82599 connecting to 82599 or X710. > > > > Network Traffic > > @@ -60,19 +60,19 @@ handled by a different logical core. > > #. The receive packet is parsed into the header fields used by the has= h > > operation (such as IP addresses, TCP port, etc.) > > > > -#. A hash calculation is performed. The Fortville supports three hash > function: > > +#. A hash calculation is performed. The Fortville supports three hash > function: > > Toeplitz, simple XOR and their Symmetric RSS. > > > > -#. Hash result are used as an index into a 128/512 entry > > +#. Hash results are used as an index into a 128/512 entry > > 'redirection table'. > > > > -#. Niantic VF only support simple default hash algorithm(simple). > > Fortville NIC > > +#. Niantic VF only supports simple default hash algorithm(simple). > > +Fortville NICs > > support all hash algorithm only used dpdk driver on host. when > > used kernel driver on host, > > - fortville nic only support default hash algorithm(simple). > > + fortville NICs only support default hash algorithm(simple). > > > > The RSS RETA update feature is designed to make RSS more flexible by > > allowing users to define the correspondence between the seven LSBs of > > hash result and - the queue id(RSS output index) by them self. > > +the queue id(RSS output index) by themself. > > > > > > Test Case: test_rss_hash > > @@ -100,7 +100,7 @@ interactive commands of the ``testpmd`` > application. > > > > 1. Got the pci device id of DUT, for example:: > > > > - ./dpdk_nic_bind.py --st > > + ./usertools/dpdk-devbind.py -s > > > > 0000:81:00.0 'Ethernet Controller X710 for 10GbE SFP+' > > if=3Dens259f0 drv=3Di40e unused=3D > > 0000:81:00.1 'Ethernet Controller X710 for 10GbE SFP+' > > if=3Dens259f1 drv=3Di40e unused=3D @@ -109,7 +109,7 @@ interactive > commands > > of the ``testpmd`` application. > > > > echo 1 > /sys/bus/pci/devices/0000\:81\:00.0/sriov_numvfs > > echo 1 > /sys/bus/pci/devices/0000\:81\:00.1/sriov_numvfs > > - ./dpdk_nic_bind.py --st > > + ./usertools/dpdk-devbind.py -s > > > > 0000:81:00.0 'Ethernet Controller X710 for 10GbE SFP+' > > if=3Dens259f0 drv=3Di40e unused=3D > > 0000:81:00.1 'Ethernet Controller X710 for 10GbE SFP+' > > if=3Dens259f1 drv=3Di40e unused=3D @@ -135,7 +135,7 @@ interactive > commands > > of the ``testpmd`` application. > > virsh nodedev-detach pci_0000_81_02_0; > > virsh nodedev-detach pci_0000_81_0a_0; > > > > - ./dpdk_nic_bind.py --st > > + ./usertools/dpdk-devbind.py -s > > > > 0000:81:00.0 'Ethernet Controller X710 for 10GbE SFP+' > > if=3Dens259f0 drv=3Di40e unused=3D > > 0000:81:00.1 'Ethernet Controller X710 for 10GbE SFP+' > > if=3Dens259f1 drv=3Di40e unused=3D @@ -155,7 +155,7 @@ interactive > commands > > of the ``testpmd`` application. > > bind them to igb_uio driver, and then start testpmd, set it in mac > forward > > mode:: > > > > - ./tools/dpdk_nic_bind.py --bind=3Digb_uio 00:06.0 00:07.0 > > + ./usertools/dpdk-devbind.py --bind=3Digb_uio 00:06.0 00:07.0 > > > > 6. Reta Configuration. 128 reta entries configuration:: > > > > @@ -167,7 +167,7 @@ interactive commands of the ``testpmd`` > application. > > > > 8. Rss received package type configuration two received packet types > > configuration:: > > > > - testpmd command: port config 0 rss ip/udp/tcp > > + testpmd command: port config all rss ip/udp/tcp > > > > 9. Verbose configuration:: > > > > @@ -177,8 +177,8 @@ interactive commands of the ``testpmd`` > application. > > > > testpmd command: start > > > > -11. Send packet and check rx port received packet by different queue. > > - different hash type send different packet, example hash type is ip= , > packet src > > and dts ip not different:: > > +11. Send different hash types' packets with different keywords, then > > +check rx > > port > > + could receive packets by different queues:: > > > > sendp([Ether(dst=3D"90:e2:ba:36:99:3c")/IP(src=3D"192.168.0.4", > > dst=3D"192.168.0.5")], iface=3D"eth3") > > sendp([Ether(dst=3D"90:e2:ba:36:99:3c")/IP(src=3D"192.168.0.5", > > dst=3D"192.168.0.4")], iface=3D"eth3") @@ -188,6 +188,6 @@ Test Case: > > test_reta > > > > This case test hash reta table, the test steps same with > > test_rss_hash except config hash reta table > > > > -Before send packet, config hash reta,512(niantic nic have 128 reta) > > reta entries > > configuration:: > > +Before send packet, config hash reta,512(niantic NICs have 128 reta) > > +reta > > entries configuration:: > > > > testpmd command: port config 0 rss reta (hash_index,queue_id) > > -- > > 2.5.5