test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Lin, Xueqin" <xueqin.lin@intel.com>
To: "Xu, Yanjie" <yanjie.xu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Xu, Yanjie" <yanjie.xu@intel.com>
Subject: Re: [dts] [PATCH] dynamic add hardware requirement
Date: Thu, 18 Apr 2019 08:18:47 +0000	[thread overview]
Message-ID: <0D300480287911409D9FF92C1FA2A3355B4D6BD1@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1555595465-174360-1-git-send-email-yanjie.xu@intel.com>

My comment as below.

Best regards,
Xueqin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xuyanjie
> Sent: Thursday, April 18, 2019 9:51 PM
> To: dts@dpdk.org
> Cc: Xu, Yanjie <yanjie.xu@intel.com>
> Subject: [dts] [PATCH] dynamic add hardware requirement
> 
> Signed-off-by: xuyanjie <yanjie.xu@intel.com>
> 
> diff --git a/test_plans/dynamic_config_test_plan.rst
> b/test_plans/dynamic_config_test_plan.rst
> index 4b6b1c7..38a7e83 100644
> --- a/test_plans/dynamic_config_test_plan.rst
> +++ b/test_plans/dynamic_config_test_plan.rst
> @@ -51,6 +51,10 @@ When promiscuous mode is disabled, packet must not
> be received. When  it is enabled, packets must be received. The change
> occurs without  stopping the device or restarting the application.
> 
> +Hardware
> +=============
> +
> +Any type NIC is supported

[Xueqin] The scope is too large, in /dpdk/drivers/net path, there are so many driver types, we may test this suite on e1000, ixgbe, i40e, not try all especially not try on some not-intel NICs.
"Any type NIC" is not make sense.  

> 
>  Prerequisites
>  =============
> --
> 2.7.4


  reply	other threads:[~2019-04-18  8:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-18 13:51 xuyanjie
2019-04-18  8:18 ` Lin, Xueqin [this message]
2019-04-18 10:32   ` Rami Rosen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0D300480287911409D9FF92C1FA2A3355B4D6BD1@SHSMSX104.ccr.corp.intel.com \
    --to=xueqin.lin@intel.com \
    --cc=dts@dpdk.org \
    --cc=yanjie.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).