test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Wang, Yinan" <yinan.wang@intel.com>
To: "Xiao, QimaiX" <qimaix.xiao@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH V1]tests/TestSuite_vhost_pmd_xstats: check multicast with multicast mac
Date: Wed, 8 Apr 2020 02:33:59 +0000	[thread overview]
Message-ID: <0fb4c4686b6e4209853832042aabcce6@intel.com> (raw)
In-Reply-To: <ece4d85b238d4dcaaf4bac580eed9441@intel.com>

Hi Qimai,

I sent another patch instead of your patch by changing self.dmac to keep the broadcast test.
Thanks!

BR,
Yinan

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Xiao, QimaiX
> Sent: 2020年4月6日 13:03
> To: dts@dpdk.org
> Subject: Re: [dts] [PATCH V1]tests/TestSuite_vhost_pmd_xstats: check multicast
> with multicast mac
> 
> Tested-by: Xiao, QimaiX <qimaix.xiao@intel.com>
> 
> -----Original Message-----
> From: Xiao, QimaiX <qimaix.xiao@intel.com>
> Sent: Monday, April 6, 2020 12:57 PM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts][PATCH V1]tests/TestSuite_vhost_pmd_xstats: check multicast
> with multicast mac
> 
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
>  tests/TestSuite_vhost_pmd_xstats.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_vhost_pmd_xstats.py
> b/tests/TestSuite_vhost_pmd_xstats.py
> index ad9e245..9b3b92c 100755
> --- a/tests/TestSuite_vhost_pmd_xstats.py
> +++ b/tests/TestSuite_vhost_pmd_xstats.py
> @@ -182,7 +182,7 @@ class TestVhostPmdXstats(TestCase):
>          date_new = date_old + datetime.timedelta(minutes=2)
>          while (1):
>              date_now = datetime.datetime.now()
> -            scope = 'broadcast'
> +            scope = 'multicast'
>              self.dmac = '01:00:00:33:00:01'
>              self.scapy_send_packet(64, self.dmac, 1)
>              if date_now >= date_new:
> @@ -327,4 +327,4 @@ class TestVhostPmdXstats(TestCase):
>          """
>          Run after each test suite.
>          """
> -        pass
> \ No newline at end of file
> +        pass
> --
> 1.8.3.1


      reply	other threads:[~2020-04-08  2:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-06  4:56 Xiao Qimai
2020-04-06  5:03 ` Xiao, QimaiX
2020-04-08  2:33   ` Wang, Yinan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0fb4c4686b6e4209853832042aabcce6@intel.com \
    --to=yinan.wang@intel.com \
    --cc=dts@dpdk.org \
    --cc=qimaix.xiao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).