test suite reviews and discussions
 help / color / mirror / Atom feed
* Re: [dts] [PATCH V1] tests/iavf_fdir: reload driver to reduce the interaction between cases
  2021-06-02 10:41 [dts] [PATCH V1] tests/iavf_fdir: reload driver to reduce the interaction between cases Qin Sun
@ 2021-06-02 10:20 ` Sun, QinX
  2021-06-09  7:16 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Sun, QinX @ 2021-06-02 10:20 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

> -----Original Message-----
> From: Sun, QinX <qinx.sun@intel.com>
> Sent: Wednesday, June 2, 2021 6:42 PM
> To: dts@dpdk.org
> Cc: Sun, QinX <qinx.sun@intel.com>
> Subject: [dts] [PATCH V1] tests/iavf_fdir: reload driver to reduce the interaction between cases

Tested-by: Qin Sun <qinx.sun@intel.com>


[-- Attachment #2: TestIAVFFdir.log --]
[-- Type: application/octet-stream, Size: 1957668 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts] [PATCH V1] tests/iavf_fdir: reload driver to reduce the interaction between cases
@ 2021-06-02 10:41 Qin Sun
  2021-06-02 10:20 ` Sun, QinX
  2021-06-09  7:16 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: Qin Sun @ 2021-06-02 10:41 UTC (permalink / raw)
  To: dts; +Cc: Qin Sun

some cases need to reload the driver to clear the packet count received by the network card,
so as to avoid the verification failure caused by other cases

Signed-off-by: Qin Sun <qinx.sun@intel.com>
---
 tests/TestSuite_iavf_fdir.py | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tests/TestSuite_iavf_fdir.py b/tests/TestSuite_iavf_fdir.py
index 27f92f8..e1f7c28 100644
--- a/tests/TestSuite_iavf_fdir.py
+++ b/tests/TestSuite_iavf_fdir.py
@@ -2986,6 +2986,9 @@ class TestIAVFFdir(TestCase):
         create same rules on pf and vf, no conflict
         """
         self.dut.kill_all()
+        self.dut.send_expect("rmmod ice", "# ", 15)
+        self.dut.send_expect("modprobe ice", "# ", 15)
+        self.setup_2pf_4vf_env()
         self.session_secondary = self.dut.new_session()
         self.session_third = self.dut.new_session()
 
@@ -3137,6 +3140,9 @@ class TestIAVFFdir(TestCase):
         create same input set but different action rules on pf and vf, no conflict.
         """
         self.dut.kill_all()
+        self.dut.send_expect("rmmod ice", "# ", 15)
+        self.dut.send_expect("modprobe ice", "# ", 15)
+        self.setup_2pf_4vf_env()
         self.session_secondary = self.dut.new_session()
         self.session_third = self.dut.new_session()
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/iavf_fdir: reload driver to reduce the interaction between cases
  2021-06-02 10:41 [dts] [PATCH V1] tests/iavf_fdir: reload driver to reduce the interaction between cases Qin Sun
  2021-06-02 10:20 ` Sun, QinX
@ 2021-06-09  7:16 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2021-06-09  7:16 UTC (permalink / raw)
  To: Sun, QinX, dts; +Cc: Sun, QinX

Reload driver is not a good idea, it will impact other devices which are not under test.

I think 'clear port stats' could help.

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Qin Sun
> Sent: 2021年6月2日 18:42
> To: dts@dpdk.org
> Cc: Sun, QinX <qinx.sun@intel.com>
> Subject: [dts] [PATCH V1] tests/iavf_fdir: reload driver to reduce the interaction
> between cases
> 
> some cases need to reload the driver to clear the packet count received by the
> network card, so as to avoid the verification failure caused by other cases
> 
> Signed-off-by: Qin Sun <qinx.sun@intel.com>
> ---
>  tests/TestSuite_iavf_fdir.py | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/tests/TestSuite_iavf_fdir.py b/tests/TestSuite_iavf_fdir.py index
> 27f92f8..e1f7c28 100644
> --- a/tests/TestSuite_iavf_fdir.py
> +++ b/tests/TestSuite_iavf_fdir.py
> @@ -2986,6 +2986,9 @@ class TestIAVFFdir(TestCase):
>          create same rules on pf and vf, no conflict
>          """
>          self.dut.kill_all()
> +        self.dut.send_expect("rmmod ice", "# ", 15)
> +        self.dut.send_expect("modprobe ice", "# ", 15)
> +        self.setup_2pf_4vf_env()
>          self.session_secondary = self.dut.new_session()
>          self.session_third = self.dut.new_session()
> 
> @@ -3137,6 +3140,9 @@ class TestIAVFFdir(TestCase):
>          create same input set but different action rules on pf and vf, no conflict.
>          """
>          self.dut.kill_all()
> +        self.dut.send_expect("rmmod ice", "# ", 15)
> +        self.dut.send_expect("modprobe ice", "# ", 15)
> +        self.setup_2pf_4vf_env()
>          self.session_secondary = self.dut.new_session()
>          self.session_third = self.dut.new_session()
> 
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-06-09  7:16 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-02 10:41 [dts] [PATCH V1] tests/iavf_fdir: reload driver to reduce the interaction between cases Qin Sun
2021-06-02 10:20 ` Sun, QinX
2021-06-09  7:16 ` Tu, Lijuan

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ https://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git