* [dts] [PATCH] framework: DUT and Tester coexisted in the same platform
@ 2015-01-26 4:52 Yong Liu
2015-01-26 5:03 ` Qiu, Michael
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Yong Liu @ 2015-01-26 4:52 UTC (permalink / raw)
To: dts
This patch based on "[PATCH 0/4] Support additional port configuration file".
And do not support to run softwore performance test in the same platform.
Fix one bug in pci numa parse.
Signed-off-by: Marvinliu <yong.liu@intel.com>
---
framework/config.py | 5 ++++-
framework/tester.py | 5 ++++-
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/framework/config.py b/framework/config.py
index 140c84b..948609a 100755
--- a/framework/config.py
+++ b/framework/config.py
@@ -79,7 +79,10 @@ class UserConf():
for param in port.split(','):
(key, _, value) = param.partition('=')
- portDict[key] = value
+ if key == 'numa':
+ portDict[key] = int(value)
+ else:
+ portDict[key] = value
return portDict
diff --git a/framework/tester.py b/framework/tester.py
index 345ab41..b35a359 100644
--- a/framework/tester.py
+++ b/framework/tester.py
@@ -287,6 +287,10 @@ class Tester(Crb):
if hits[localPort]:
continue
+ # skip ping self port
+ if (self.crb['IP'] == self.crb['tester IP']) and (self.dut.ports_info[dutPort]['pci'] == self.ports_info[localPort]['pci']):
+ continue
+
ipv6 = self.dut.get_ipv6_address(dutPort)
if ipv6 == "Not connected":
continue
@@ -440,7 +444,6 @@ class Tester(Crb):
"""
if not self.has_external_traffic_generator():
self.alt_session.send_expect('killall scapy 2>/dev/null; echo tester', '# ', 5)
- super(Tester, self).kill_all()
def close(self):
"""
--
1.8.1.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dts] [PATCH] framework: DUT and Tester coexisted in the same platform
2015-01-26 4:52 [dts] [PATCH] framework: DUT and Tester coexisted in the same platform Yong Liu
@ 2015-01-26 5:03 ` Qiu, Michael
2015-01-26 5:09 ` Qiu, Michael
2015-01-27 2:21 ` [dts] [PATCH] framework: enable DUT and Tester run " Yong Liu
2 siblings, 0 replies; 6+ messages in thread
From: Qiu, Michael @ 2015-01-26 5:03 UTC (permalink / raw)
To: Liu, Yong, dts
On 1/26/2015 12:53 PM, Yong Liu wrote:
> This patch based on "[PATCH 0/4] Support additional port configuration file".
> And do not support to run softwore performance test in the same platform.
>
> Fix one bug in pci numa parse.
>
> Signed-off-by: Marvinliu <yong.liu@intel.com>
> ---
> framework/config.py | 5 ++++-
> framework/tester.py | 5 ++++-
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/framework/config.py b/framework/config.py
> index 140c84b..948609a 100755
> --- a/framework/config.py
> +++ b/framework/config.py
> @@ -79,7 +79,10 @@ class UserConf():
>
> for param in port.split(','):
> (key, _, value) = param.partition('=')
> - portDict[key] = value
> + if key == 'numa':
> + portDict[key] = int(value)
> + else:
> + portDict[key] = value
> return portDict
>
>
> diff --git a/framework/tester.py b/framework/tester.py
> index 345ab41..b35a359 100644
> --- a/framework/tester.py
> +++ b/framework/tester.py
> @@ -287,6 +287,10 @@ class Tester(Crb):
> if hits[localPort]:
> continue
>
> + # skip ping self port
> + if (self.crb['IP'] == self.crb['tester IP']) and (self.dut.ports_info[dutPort]['pci'] == self.ports_info[localPort]['pci']):
Would you please make separate this line? To be sure the len is not
exceed 80.
Thanks,
Michael
> + continue
> +
> ipv6 = self.dut.get_ipv6_address(dutPort)
> if ipv6 == "Not connected":
> continue
> @@ -440,7 +444,6 @@ class Tester(Crb):
> """
> if not self.has_external_traffic_generator():
> self.alt_session.send_expect('killall scapy 2>/dev/null; echo tester', '# ', 5)
> - super(Tester, self).kill_all()
>
> def close(self):
> """
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dts] [PATCH] framework: DUT and Tester coexisted in the same platform
2015-01-26 4:52 [dts] [PATCH] framework: DUT and Tester coexisted in the same platform Yong Liu
2015-01-26 5:03 ` Qiu, Michael
@ 2015-01-26 5:09 ` Qiu, Michael
2015-01-26 5:12 ` Liu, Yong
2015-01-27 2:21 ` [dts] [PATCH] framework: enable DUT and Tester run " Yong Liu
2 siblings, 1 reply; 6+ messages in thread
From: Qiu, Michael @ 2015-01-26 5:09 UTC (permalink / raw)
To: Liu, Yong, dts
On 1/26/2015 12:53 PM, Yong Liu wrote:
> This patch based on "[PATCH 0/4] Support additional port configuration file".
> And do not support to run softwore performance test in the same platform.
>
> Fix one bug in pci numa parse.
>
> Signed-off-by: Marvinliu <yong.liu@intel.com>
> ---
> framework/config.py | 5 ++++-
> framework/tester.py | 5 ++++-
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/framework/config.py b/framework/config.py
> index 140c84b..948609a 100755
> --- a/framework/config.py
> +++ b/framework/config.py
> @@ -79,7 +79,10 @@ class UserConf():
>
> for param in port.split(','):
> (key, _, value) = param.partition('=')
> - portDict[key] = value
> + if key == 'numa':
> + portDict[key] = int(value)
> + else:
> + portDict[key] = value
> return portDict
>
>
Better to make another patch for this issue.
Thanks,
Michael
> diff --git a/framework/tester.py b/framework/tester.py
> index 345ab41..b35a359 100644
> --- a/framework/tester.py
> +++ b/framework/tester.py
> @@ -287,6 +287,10 @@ class Tester(Crb):
> if hits[localPort]:
> continue
>
> + # skip ping self port
> + if (self.crb['IP'] == self.crb['tester IP']) and (self.dut.ports_info[dutPort]['pci'] == self.ports_info[localPort]['pci']):
> + continue
> +
> ipv6 = self.dut.get_ipv6_address(dutPort)
> if ipv6 == "Not connected":
> continue
> @@ -440,7 +444,6 @@ class Tester(Crb):
> """
> if not self.has_external_traffic_generator():
> self.alt_session.send_expect('killall scapy 2>/dev/null; echo tester', '# ', 5)
> - super(Tester, self).kill_all()
>
> def close(self):
> """
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dts] [PATCH] framework: DUT and Tester coexisted in the same platform
2015-01-26 5:09 ` Qiu, Michael
@ 2015-01-26 5:12 ` Liu, Yong
0 siblings, 0 replies; 6+ messages in thread
From: Liu, Yong @ 2015-01-26 5:12 UTC (permalink / raw)
To: Qiu, Michael, dts
Thanks Michael. I'll apart this patch into two patches.
> -----Original Message-----
> From: Qiu, Michael
> Sent: Monday, January 26, 2015 1:10 PM
> To: Liu, Yong; dts@dpdk.org
> Subject: Re: [dts] [PATCH] framework: DUT and Tester coexisted in the same
> platform
>
> On 1/26/2015 12:53 PM, Yong Liu wrote:
> > This patch based on "[PATCH 0/4] Support additional port configuration
> file".
> > And do not support to run softwore performance test in the same platform.
> >
> > Fix one bug in pci numa parse.
> >
> > Signed-off-by: Marvinliu <yong.liu@intel.com>
> > ---
> > framework/config.py | 5 ++++-
> > framework/tester.py | 5 ++++-
> > 2 files changed, 8 insertions(+), 2 deletions(-)
> >
> > diff --git a/framework/config.py b/framework/config.py
> > index 140c84b..948609a 100755
> > --- a/framework/config.py
> > +++ b/framework/config.py
> > @@ -79,7 +79,10 @@ class UserConf():
> >
> > for param in port.split(','):
> > (key, _, value) = param.partition('=')
> > - portDict[key] = value
> > + if key == 'numa':
> > + portDict[key] = int(value)
> > + else:
> > + portDict[key] = value
> > return portDict
> >
> >
>
> Better to make another patch for this issue.
>
> Thanks,
> Michael
> > diff --git a/framework/tester.py b/framework/tester.py
> > index 345ab41..b35a359 100644
> > --- a/framework/tester.py
> > +++ b/framework/tester.py
> > @@ -287,6 +287,10 @@ class Tester(Crb):
> > if hits[localPort]:
> > continue
> >
> > + # skip ping self port
> > + if (self.crb['IP'] == self.crb['tester IP']) and
> (self.dut.ports_info[dutPort]['pci'] == self.ports_info[localPort]['pci']):
> > + continue
> > +
> > ipv6 = self.dut.get_ipv6_address(dutPort)
> > if ipv6 == "Not connected":
> > continue
> > @@ -440,7 +444,6 @@ class Tester(Crb):
> > """
> > if not self.has_external_traffic_generator():
> > self.alt_session.send_expect('killall scapy 2>/dev/null;
> echo tester', '# ', 5)
> > - super(Tester, self).kill_all()
> >
> > def close(self):
> > """
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dts] [PATCH] framework: enable DUT and Tester run in the same platform
2015-01-26 4:52 [dts] [PATCH] framework: DUT and Tester coexisted in the same platform Yong Liu
2015-01-26 5:03 ` Qiu, Michael
2015-01-26 5:09 ` Qiu, Michael
@ 2015-01-27 2:21 ` Yong Liu
2015-02-04 3:18 ` Qiu, Michael
2 siblings, 1 reply; 6+ messages in thread
From: Yong Liu @ 2015-01-27 2:21 UTC (permalink / raw)
To: dts
Skip to ping self port when DUT and Tester in the same platform.
Not support software performance in the same platform now.
Signed-off-by: Yong Liu <yong.liu@intel.com>
---
This patch based on "[PATCH 0/4] Support additional port configuration file".
framework/tester.py | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/framework/tester.py b/framework/tester.py
index 345ab41..9100967 100644
--- a/framework/tester.py
+++ b/framework/tester.py
@@ -73,6 +73,8 @@ class Tester(Crb):
self.scapyCmds = []
self.bgCmds = []
self.bgItf = ''
+ self.packet_gen = None
+ self.ixia_packet_gen = None
def init_ext_gen(self):
"""
@@ -287,6 +289,11 @@ class Tester(Crb):
if hits[localPort]:
continue
+ # skip ping self port
+ if (self.crb['IP'] == self.crb['tester IP']) and \
+ (self.dut.ports_info[dutPort]['pci'] == self.ports_info[localPort]['pci']):
+ continue
+
ipv6 = self.dut.get_ipv6_address(dutPort)
if ipv6 == "Not connected":
continue
@@ -440,6 +447,7 @@ class Tester(Crb):
"""
if not self.has_external_traffic_generator():
self.alt_session.send_expect('killall scapy 2>/dev/null; echo tester', '# ', 5)
+ if self.packet_gen:
super(Tester, self).kill_all()
def close(self):
--
1.9.3
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dts] [PATCH] framework: enable DUT and Tester run in the same platform
2015-01-27 2:21 ` [dts] [PATCH] framework: enable DUT and Tester run " Yong Liu
@ 2015-02-04 3:18 ` Qiu, Michael
0 siblings, 0 replies; 6+ messages in thread
From: Qiu, Michael @ 2015-02-04 3:18 UTC (permalink / raw)
To: Liu, Yong, dts
Hi, Marvin
Please send out with the pattern [PATCH v2] next time for new version patch.
Acked-by: Michael Qiu <michael.qiu@intel.com>
On 1/27/2015 10:21 AM, Yong Liu wrote:
> Skip to ping self port when DUT and Tester in the same platform.
> Not support software performance in the same platform now.
>
> Signed-off-by: Yong Liu <yong.liu@intel.com>
> ---
> This patch based on "[PATCH 0/4] Support additional port configuration file".
>
> framework/tester.py | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/framework/tester.py b/framework/tester.py
> index 345ab41..9100967 100644
> --- a/framework/tester.py
> +++ b/framework/tester.py
> @@ -73,6 +73,8 @@ class Tester(Crb):
> self.scapyCmds = []
> self.bgCmds = []
> self.bgItf = ''
> + self.packet_gen = None
> + self.ixia_packet_gen = None
>
> def init_ext_gen(self):
> """
> @@ -287,6 +289,11 @@ class Tester(Crb):
> if hits[localPort]:
> continue
>
> + # skip ping self port
> + if (self.crb['IP'] == self.crb['tester IP']) and \
> + (self.dut.ports_info[dutPort]['pci'] == self.ports_info[localPort]['pci']):
> + continue
> +
> ipv6 = self.dut.get_ipv6_address(dutPort)
> if ipv6 == "Not connected":
> continue
> @@ -440,6 +447,7 @@ class Tester(Crb):
> """
> if not self.has_external_traffic_generator():
> self.alt_session.send_expect('killall scapy 2>/dev/null; echo tester', '# ', 5)
> + if self.packet_gen:
> super(Tester, self).kill_all()
>
> def close(self):
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-02-04 3:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-26 4:52 [dts] [PATCH] framework: DUT and Tester coexisted in the same platform Yong Liu
2015-01-26 5:03 ` Qiu, Michael
2015-01-26 5:09 ` Qiu, Michael
2015-01-26 5:12 ` Liu, Yong
2015-01-27 2:21 ` [dts] [PATCH] framework: enable DUT and Tester run " Yong Liu
2015-02-04 3:18 ` Qiu, Michael
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).