test suite reviews and discussions
 help / color / mirror / Atom feed
From: Jingguo Fu <jingguox.fu@intel.com>
To: dts@dpdk.org
Cc: Jingguo Fu <jingguox.fu@intel.com>
Subject: [dts] [DTS][PATCH 1/3] ieee1588: fix sutie for framework update
Date: Tue, 26 May 2015 18:05:45 +0800	[thread overview]
Message-ID: <1432634747-20565-1-git-send-email-jingguox.fu@intel.com> (raw)

Signed-off-by: Jingguo Fu <jingguox.fu@intel.com>
---
 tests/TestSuite_ieee1588.py | 17 +++++------------
 1 file changed, 5 insertions(+), 12 deletions(-)

diff --git a/tests/TestSuite_ieee1588.py b/tests/TestSuite_ieee1588.py
index bf48188..6ee95e4 100644
--- a/tests/TestSuite_ieee1588.py
+++ b/tests/TestSuite_ieee1588.py
@@ -36,22 +36,16 @@ Test support of IEEE1588 Precise Time Protocol.
 
 import dts
 import time
-
-
 from test_case import TestCase
 from pmd_output import PmdOutput
 
-
 class TestIeee1588(TestCase):
 
     def set_up_all(self):
         """
         Run at the start of each test suite.
-
-
         IEEE1588 Prerequisites
         """
-
         dutPorts = self.dut.get_ports()
         self.verify(len(dutPorts) > 0, "No ports found for " + self.nic)
 
@@ -64,7 +58,7 @@ class TestIeee1588(TestCase):
         self.dut.build_install_dpdk(self.target)
 
         self.pmdout = PmdOutput(self.dut)
-        self.pmdout.start_testpmd("all")
+        self.pmdout.start_testpmd("Default")
 
     def set_up(self):
         """
@@ -76,10 +70,11 @@ class TestIeee1588(TestCase):
         """
         IEEE1588 Enable test case.
         """
-
         self.dut.send_expect("set fwd ieee1588", "testpmd> ")
-        self.dut.send_expect("start", ">", 5)  # Waiting for 'testpmd> ' Fails due to log messages, "Received non PTP packet", in the output
-        time.sleep(1)  # Allow the output from the "start" command to finish before looking for a regexp in expect
+        # Waiting for 'testpmd> ' Fails due to log messages, "Received non PTP packet", in the output
+        self.dut.send_expect("start", ">", 5)  
+        # Allow the output from the "start" command to finish before looking for a regexp in expect
+        time.sleep(1)
 
         # use the first port on that self.nic
         dutPorts = self.dut.get_ports()
@@ -92,7 +87,6 @@ class TestIeee1588(TestCase):
 
         # this is the output of sniff
         # [<Ether  dst=01:1b:19:00:00:00 src=00:00:00:00:00:00 type=0x88f7 |<Raw  load='\x00\x02' |>>]
-
         self.tester.scapy_foreground()
         self.tester.scapy_append('nutmac="01:1b:19:00:00:00"')
         self.tester.scapy_append('sendp([Ether(dst=nutmac,type=0x88f7)/"\\x00\\x02"], iface="%s")' % itf)
@@ -120,7 +114,6 @@ class TestIeee1588(TestCase):
         """
         IEEE1588 Disable test case.
         """
-
         self.dut.send_expect("stop", "testpmd> ")
         time.sleep(3)
 
-- 
2.1.0

             reply	other threads:[~2015-05-26 10:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-26 10:05 Jingguo Fu [this message]
2015-05-26 10:05 ` [dts] [DTS][PATCH 2/3] jumbo frame: " Jingguo Fu
2015-05-26 10:05 ` [dts] [DTS][PATCH 3/3] whitelist: " Jingguo Fu
2015-06-01  8:59 ` [dts] [DTS][PATCH 1/3] ieee1588: " Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432634747-20565-1-git-send-email-jingguox.fu@intel.com \
    --to=jingguox.fu@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).