* [dts] [DTS][PATCH 2/2] scatter: add scatter test plan
2015-05-28 5:14 [dts] [DTS][PATCH 1/2] scatter: add scatter test suite Jingguo Fu
@ 2015-05-28 5:14 ` Jingguo Fu
2015-05-28 5:44 ` [dts] [DTS][PATCH 1/2] scatter: add scatter test suite Xu, HuilongX
2015-06-01 9:16 ` Liu, Yong
2 siblings, 0 replies; 4+ messages in thread
From: Jingguo Fu @ 2015-05-28 5:14 UTC (permalink / raw)
To: dts; +Cc: Jingguo Fu
Signed-off-by: Jingguo Fu <jingguox.fu@intel.com>
---
test_plans/scatter_test_plan.rst | 119 +++++++++++++++++++++++++++++++++++++++
1 file changed, 119 insertions(+)
create mode 100644 test_plans/scatter_test_plan.rst
diff --git a/test_plans/scatter_test_plan.rst b/test_plans/scatter_test_plan.rst
new file mode 100644
index 0000000..b1f1299
--- /dev/null
+++ b/test_plans/scatter_test_plan.rst
@@ -0,0 +1,119 @@
+.. Copyright (c) <2010, 2011>, Intel Corporation
+ All rights reserved.
+
+ Redistribution and use in source and binary forms, with or without
+ modification, are permitted provided that the following conditions
+ are met:
+
+ - Redistributions of source code must retain the above copyright
+ notice, this list of conditions and the following disclaimer.
+
+ - Redistributions in binary form must reproduce the above copyright
+ notice, this list of conditions and the following disclaimer in
+ the documentation and/or other materials provided with the
+ distribution.
+
+ - Neither the name of Intel Corporation nor the names of its
+ contributors may be used to endorse or promote products derived
+ from this software without specific prior written permission.
+
+ THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+ FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+ COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+ INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+ SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+ HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
+ STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
+ OF THE POSSIBILITY OF SUCH DAMAGE.
+
+=================================================
+Support of Scattered Packets by Poll Mode Drivers
+=================================================
+
+The support of scattered packets by Poll Mode Drivers consists in making
+it possible to receive and to transmit scattered multi-segments packets
+composed of multiple non-contiguous memory buffers.
+To enforce the receipt of scattered packets, the DMA rings of port RX queues
+must be configured with mbuf data buffers whose size is lower than the maximum
+frame length.
+The forwarding of scattered input packets naturally enforces the transmission
+of scattered packets by PMD transmit functions.
+
+Configuring the size of mbuf data buffers
+=========================================
+
+The size of mbuf data buffers is configured with the parameter ``--mbuf-size``
+that is supplied in the set of parameters when launching the ``testpmd``
+application.
+The default size of the mbuf data buffer is 2048 so that a full 1518-byte
+(CRC included) Ethernet frame can be stored in a mono-segment packet.
+
+Functional Tests of Scattered Packets
+=====================================
+
+Testing the support of scattered packets in Poll Mode Drivers consists in
+sending to the test machine packets whose length is greater than the size
+of mbuf data buffers used to populate the DMA rings of port RX queues.
+
+First, the receipt and the transmission of scattered packets must be tested
+with the ``CRC stripping`` option enabled, which guarantees that scattered
+packets only contain packet data.
+
+In addition, the support of scattered packets must also be performed with
+the ``CRC stripping`` option disabled, to check the special cases of scattered
+input packets whose last buffer only contains the whole CRC or part of it.
+In such cases, PMD receive functions must free the last buffer when removing
+the CRC from the packet before returning it.
+
+As a whole, the following packet lengths (CRC included) must be tested to
+check all packet memory configurations:
+
+#. packet length < mbuf data buffer size
+
+#. packet length = mbuf data buffer size
+
+#. packet length = mbuf data buffer size + 1
+
+#. packet length = mbuf data buffer size + 4
+
+#. packet length = mbuf data buffer size + 5
+
+In cases 1) and 2), the hardware RX engine stores the packet data and the CRC
+in a single buffer.
+In case 3), the hardware RX engine stores the packet data and the 3 first bytes
+of the CRC in the first buffer, and the last byte of the CRC in a second buffer.
+In case 4), the hardware RX engine stores all the packet data in the first
+buffer, and the CRC in a second buffer.
+In case 5), the hardware RX engine stores part of the packet data in the first
+buffer, and the last data byte plus the CRC in a second buffer.
+
+Prerequisites
+=============
+
+Assuming that ports ``0`` and ``1`` of the test target are directly connected
+to a Traffic Generator, launch the ``testpmd`` application with the following
+arguments::
+
+ ./build/app/testpmd -cffffff -n 3 -- -i --rxd=1024 --txd=1024 \
+ --burst=144 --txpt=32 --txht=8 --txwt=8 --txfreet=0 --rxfreet=64 \
+ --mbcache=200 --portmask=0x3 --mbuf-size=1024
+
+The -n command is used to select the number of memory channels. It should match
+the number of memory channels on that setup.
+
+Setting the size of the mbuf data buffer to 1024 makes 1025-bytes input packets
+(CRC included) and larger packets to be stored in two buffers by the hardware
+RX engine.
+
+Test Case: Mbuf 1024 traffic
+============================
+
+Start packet forwarding in the ``testpmd`` application with the ``start`` command.
+Send 5 packets of lengths (CRC included) 1023, 1024, 1025, 1028, and 1029.
+Check that the same amount of frames and bytes are received back by the Traffic
+Generator from its port connected to the target's port 1.
+
--
2.1.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dts] [DTS][PATCH 1/2] scatter: add scatter test suite
2015-05-28 5:14 [dts] [DTS][PATCH 1/2] scatter: add scatter test suite Jingguo Fu
2015-05-28 5:14 ` [dts] [DTS][PATCH 2/2] scatter: add scatter test plan Jingguo Fu
@ 2015-05-28 5:44 ` Xu, HuilongX
2015-06-01 9:16 ` Liu, Yong
2 siblings, 0 replies; 4+ messages in thread
From: Xu, HuilongX @ 2015-05-28 5:44 UTC (permalink / raw)
To: Fu, JingguoX, dts
Hi jinguo,
Pls see my comments as blow.
Thanks a lot
> -----Original Message-----
> From: Fu, JingguoX
> Sent: Thursday, May 28, 2015 1:15 PM
> To: dts@dpdk.org
> Cc: Xu, HuilongX; Tang, HaifengX; Fu, JingguoX
> Subject: [DTS][PATCH 1/2] scatter: add scatter test suite
>
> Signed-off-by: Jingguo Fu <jingguox.fu@intel.com>
> ---
> tests/TestSuite_scatter.py | 140
> +++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 140 insertions(+)
> create mode 100644 tests/TestSuite_scatter.py
>
> diff --git a/tests/TestSuite_scatter.py b/tests/TestSuite_scatter.py
> new file mode 100644
> index 0000000..643fe4a
> --- /dev/null
> +++ b/tests/TestSuite_scatter.py
> @@ -0,0 +1,140 @@
> +# BSD LICENSE
> +#
> +# Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
> +# All rights reserved.
> +#
> +# Redistribution and use in source and binary forms, with or without
> +# modification, are permitted provided that the following conditions
> +# are met:
> +#
> +# * Redistributions of source code must retain the above copyright
> +# notice, this list of conditions and the following disclaimer.
> +# * Redistributions in binary form must reproduce the above copyright
> +# notice, this list of conditions and the following disclaimer in
> +# the documentation and/or other materials provided with the
> +# distribution.
> +# * Neither the name of Intel Corporation nor the names of its
> +# contributors may be used to endorse or promote products derived
> +# from this software without specific prior written permission.
> +#
> +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
> +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
> +# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
> +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
> +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
> +# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
> +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> +
> +"""
> +DPDK Test suite.
> +Test Scattered Packets.
> +"""
> +import dts
> +from test_case import TestCase
> +from pmd_output import PmdOutput
> +#
> +#
> +# Test class.
> +#
> +class TestScatter(TestCase):
> + #
> + #
> + #
> + # Test cases.
> + #
> + def set_up_all(self):
> + """
> + Run at the start of each test suite.
> + Scatter Prerequistites
> + """
> + dutPorts = self.dut.get_ports(self.nic)
> + # Verify that enough ports are available
> + self.verify(len(dutPorts) >= 2, "Insufficient ports")
> + self.pmdout = PmdOutput(self.dut)
> +
> + def scatter_pktgen_send_packet(self, sPortid, rPortid, pktsize,
> num=1):
> + """
> + Functional test for scatter packets.
> + """
> + sport = self.tester.get_local_port(sPortid)
> + sintf = self.tester.get_interface(sport)
> + smac = self.dut.get_mac_address(sPortid)
> + rport = self.tester.get_local_port(rPortid)
> + rintf = self.tester.get_interface(rport)
> + if self.nic in ["niantic", "fortville_eagle", "fortville_spirit",
> "fortville_spirit_single"]:
> + self.tester.send_expect("ifconfig %s mtu 9000" % sintf, "#")
> + self.tester.send_expect("ifconfig %s mtu 9000" % rintf, "#")
> +
> + self.tester.scapy_background()
> + self.tester.scapy_append(
> + 'p = sniff(filter="ip",iface="%s", count=%d)' % (rintf, num))
> + self.tester.scapy_append('RESULT = str(p)')
> +
The number 18 and 20 , I think 18 means ethtype head + crc size, 20 means IP head.
If yes, would you used the define from setting?
> + pktlen = pktsize - 18
> + padding = pktlen - 20
> +
> + self.tester.scapy_foreground()
> + self.tester.scapy_append(
> + 'sendp([Ether(dst="%s")/IP(len=%s)/Raw(load="\x50"*%s)],
> iface="%s")' % (smac, pktlen, padding, sintf))
> + self.tester.scapy_execute()
> + res = self.tester.scapy_get_result()
> + if self.nic in ["niantic", "fortville_eagle", "fortville_spirit",
> "fortville_spirit_single"]:
> + self.tester.send_expect("ifconfig %s mtu 1500" % sintf, "#")
> + self.tester.send_expect("ifconfig %s mtu 1500" % sintf, "#")
> + return res
> +
> + def set_up(self):
> + """
> + Run before each test case.
> + """
> + pass
> +
> + def test_scatter_mbuf_2048(self):
> + """
> + Scatter 2048 mbuf
> +
"""
Who will use coreMask, if not any need use, I think you can delete this code
> + cores = self.dut.get_core_list('1S/2C/2T')
> + coreMask = dts.create_mask(cores)
> + dutPorts = self.dut.get_ports(self.nic)
> + portMask = dts.create_mask(dutPorts[:2])
> +
> + # set the mbuf size to 1024
> + if self.nic in ["niantic", "fortville_eagle", "fortville_spirit",
> "fortville_spirit_single"]:
Would you usd "Default" replace "1S/2C/2T"
> + out = self.pmdout.start_testpmd(
> + "1S/2C/2T", "--mbcache=200 --mbuf-size=2048 --portmask=%s
> --max-pkt-len=9000" % portMask)
> + else:
> + out = self.pmdout.start_testpmd(
> + "1S/2C/2T", "--mbcache=200 --mbuf-size=1024 --
> portmask=%s" % portMask)
> + self.verify("Error" not in out, "launch error 1")
> +
> + if self.nic in ["niantic", "fortville_eagle", "fortville_spirit",
> "fortville_spirit_single"]:
> + self.dut.send_expect("set fwd mac", "testpmd> ", 120)
> + self.dut.send_expect("start", "testpmd> ")
> +
> + for offset in [-1, 0, 1, 4, 5]:
> + if self.nic in ["niantic", "fortville_eagle",
> "fortville_spirit", "fortville_spirit_single"]:
> + ret = self.scatter_pktgen_send_packet(
> + dutPorts[0], dutPorts[1], 2048 + offset)
> + else:
> + ret = self.scatter_pktgen_send_packet(
> + dutPorts[0], dutPorts[1], 1024 + offset)
> + self.verify("load='P" in ret, "packet receive error")
> +
> + self.dut.send_expect("stop", "testpmd> ")
> + self.dut.send_expect("quit", "# ", 30)
> +
> + def tear_down(self):
> + """
> + Run after each test case.
> + """
> + pass
> +
> + def tear_down_all(self):
> + """
> + Run after each test suite.
> + """
> + pass
> --
> 2.1.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dts] [DTS][PATCH 1/2] scatter: add scatter test suite
2015-05-28 5:14 [dts] [DTS][PATCH 1/2] scatter: add scatter test suite Jingguo Fu
2015-05-28 5:14 ` [dts] [DTS][PATCH 2/2] scatter: add scatter test plan Jingguo Fu
2015-05-28 5:44 ` [dts] [DTS][PATCH 1/2] scatter: add scatter test suite Xu, HuilongX
@ 2015-06-01 9:16 ` Liu, Yong
2 siblings, 0 replies; 4+ messages in thread
From: Liu, Yong @ 2015-06-01 9:16 UTC (permalink / raw)
To: Fu, JingguoX, dts; +Cc: Fu, JingguoX
Thanks, applied in 1.1 branch.
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Jingguo Fu
> Sent: Thursday, May 28, 2015 1:15 PM
> To: dts@dpdk.org
> Cc: Fu, JingguoX
> Subject: [dts] [DTS][PATCH 1/2] scatter: add scatter test suite
>
> Signed-off-by: Jingguo Fu <jingguox.fu@intel.com>
> ---
> tests/TestSuite_scatter.py | 140
> +++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 140 insertions(+)
> create mode 100644 tests/TestSuite_scatter.py
>
> diff --git a/tests/TestSuite_scatter.py b/tests/TestSuite_scatter.py
> new file mode 100644
> index 0000000..643fe4a
> --- /dev/null
> +++ b/tests/TestSuite_scatter.py
> @@ -0,0 +1,140 @@
> +# BSD LICENSE
> +#
> +# Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
> +# All rights reserved.
> +#
> +# Redistribution and use in source and binary forms, with or without
> +# modification, are permitted provided that the following conditions
> +# are met:
> +#
> +# * Redistributions of source code must retain the above copyright
> +# notice, this list of conditions and the following disclaimer.
> +# * Redistributions in binary form must reproduce the above copyright
> +# notice, this list of conditions and the following disclaimer in
> +# the documentation and/or other materials provided with the
> +# distribution.
> +# * Neither the name of Intel Corporation nor the names of its
> +# contributors may be used to endorse or promote products derived
> +# from this software without specific prior written permission.
> +#
> +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
> +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
> +# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
> +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
> +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
> +# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
> +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> +
> +"""
> +DPDK Test suite.
> +Test Scattered Packets.
> +"""
> +import dts
> +from test_case import TestCase
> +from pmd_output import PmdOutput
> +#
> +#
> +# Test class.
> +#
> +class TestScatter(TestCase):
> + #
> + #
> + #
> + # Test cases.
> + #
> + def set_up_all(self):
> + """
> + Run at the start of each test suite.
> + Scatter Prerequistites
> + """
> + dutPorts = self.dut.get_ports(self.nic)
> + # Verify that enough ports are available
> + self.verify(len(dutPorts) >= 2, "Insufficient ports")
> + self.pmdout = PmdOutput(self.dut)
> +
> + def scatter_pktgen_send_packet(self, sPortid, rPortid, pktsize,
> num=1):
> + """
> + Functional test for scatter packets.
> + """
> + sport = self.tester.get_local_port(sPortid)
> + sintf = self.tester.get_interface(sport)
> + smac = self.dut.get_mac_address(sPortid)
> + rport = self.tester.get_local_port(rPortid)
> + rintf = self.tester.get_interface(rport)
> + if self.nic in ["niantic", "fortville_eagle", "fortville_spirit",
> "fortville_spirit_single"]:
> + self.tester.send_expect("ifconfig %s mtu 9000" % sintf, "#")
> + self.tester.send_expect("ifconfig %s mtu 9000" % rintf, "#")
> +
> + self.tester.scapy_background()
> + self.tester.scapy_append(
> + 'p = sniff(filter="ip",iface="%s", count=%d)' % (rintf, num))
> + self.tester.scapy_append('RESULT = str(p)')
> +
> + pktlen = pktsize - 18
> + padding = pktlen - 20
> +
> + self.tester.scapy_foreground()
> + self.tester.scapy_append(
> + 'sendp([Ether(dst="%s")/IP(len=%s)/Raw(load="\x50"*%s)],
> iface="%s")' % (smac, pktlen, padding, sintf))
> + self.tester.scapy_execute()
> + res = self.tester.scapy_get_result()
> + if self.nic in ["niantic", "fortville_eagle", "fortville_spirit",
> "fortville_spirit_single"]:
> + self.tester.send_expect("ifconfig %s mtu 1500" % sintf, "#")
> + self.tester.send_expect("ifconfig %s mtu 1500" % sintf, "#")
> + return res
> +
> + def set_up(self):
> + """
> + Run before each test case.
> + """
> + pass
> +
> + def test_scatter_mbuf_2048(self):
> + """
> + Scatter 2048 mbuf
> + """
> + cores = self.dut.get_core_list('1S/2C/2T')
> + coreMask = dts.create_mask(cores)
> + dutPorts = self.dut.get_ports(self.nic)
> + portMask = dts.create_mask(dutPorts[:2])
> +
> + # set the mbuf size to 1024
> + if self.nic in ["niantic", "fortville_eagle", "fortville_spirit",
> "fortville_spirit_single"]:
> + out = self.pmdout.start_testpmd(
> + "1S/2C/2T", "--mbcache=200 --mbuf-size=2048 --portmask=%s
> --max-pkt-len=9000" % portMask)
> + else:
> + out = self.pmdout.start_testpmd(
> + "1S/2C/2T", "--mbcache=200 --mbuf-size=1024 --
> portmask=%s" % portMask)
> + self.verify("Error" not in out, "launch error 1")
> +
> + if self.nic in ["niantic", "fortville_eagle", "fortville_spirit",
> "fortville_spirit_single"]:
> + self.dut.send_expect("set fwd mac", "testpmd> ", 120)
> + self.dut.send_expect("start", "testpmd> ")
> +
> + for offset in [-1, 0, 1, 4, 5]:
> + if self.nic in ["niantic", "fortville_eagle",
> "fortville_spirit", "fortville_spirit_single"]:
> + ret = self.scatter_pktgen_send_packet(
> + dutPorts[0], dutPorts[1], 2048 + offset)
> + else:
> + ret = self.scatter_pktgen_send_packet(
> + dutPorts[0], dutPorts[1], 1024 + offset)
> + self.verify("load='P" in ret, "packet receive error")
> +
> + self.dut.send_expect("stop", "testpmd> ")
> + self.dut.send_expect("quit", "# ", 30)
> +
> + def tear_down(self):
> + """
> + Run after each test case.
> + """
> + pass
> +
> + def tear_down_all(self):
> + """
> + Run after each test suite.
> + """
> + pass
> --
> 2.1.0
^ permalink raw reply [flat|nested] 4+ messages in thread