test suite reviews and discussions
 help / color / mirror / Atom feed
From: changru <changrux.fan@intel.com>
To: dts@dpdk.org
Subject: [dts] [PATCH] Fix checksum_checking failed issue
Date: Thu, 17 Sep 2015 17:07:13 +0800	[thread overview]
Message-ID: <1442480833-42991-1-git-send-email-changrux.fan@intel.com> (raw)

In UDP packet, if the chksum is equal to 0, it means the receiver don't need to check.
But, we want to send a packet with an error checksum.
On the other hand, on 1G NICs, the packet received has the same length with the packet sent.   

Signed-off-by: changru <changrux.fan@intel.com>
---
 tests/TestSuite_pmd.py | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/tests/TestSuite_pmd.py b/tests/TestSuite_pmd.py
index afb2450..525ed02 100644
--- a/tests/TestSuite_pmd.py
+++ b/tests/TestSuite_pmd.py
@@ -375,7 +375,7 @@ class TestPmd(TestCase,IxiaPacketGenerator):
 
         checksum = ''
         if checksum_test:
-            checksum = 'chksum=0x0'
+            checksum = 'chksum=0x1'
 
         self.tester.scapy_foreground()
         self.tester.scapy_append('nutmac="%s"' % mac)
@@ -402,8 +402,12 @@ class TestPmd(TestCase,IxiaPacketGenerator):
                     "packet pass assert error, %d RX packets, %d TX packets" % (p1rx_pkts, p0tx_pkts))
 
         if checksum_test:
-            self.verify(p1rx_bytes == frame_size - 4,
-                        "packet pass assert error, expected %d RX bytes, actual %d" % (frame_size - 4, p1rx_bytes))
+            if self.nic in ["powerville", "springville", "kawela_4"]:
+            	self.verify(p1rx_bytes == frame_size,
+                        	"packet pass assert error, expected %d RX bytes, actual %d" % (frame_size, p1rx_bytes))
+            else:
+            	self.verify(p1rx_bytes == frame_size - 4,
+                        	"packet pass assert error, expected %d RX bytes, actual %d" % (frame_size - 4, p1rx_bytes))
         else:
             self.verify(p1rx_bytes == frame_size,
                         "packet pass assert error, expected %d RX bytes, actual %d" % (frame_size, p1rx_bytes))
-- 
2.1.0

             reply	other threads:[~2015-09-17  9:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-17  9:07 changru [this message]
2015-09-18 12:42 ` Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442480833-42991-1-git-send-email-changrux.fan@intel.com \
    --to=changrux.fan@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).