test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH] remove 1G nics & freebsd not support judgement from fdir, pmdrssreta, multiprocess
@ 2015-09-21  7:48 Yongjie
  2015-09-23  2:26 ` Liu, Yong
  0 siblings, 1 reply; 2+ messages in thread
From: Yongjie @ 2015-09-21  7:48 UTC (permalink / raw)
  To: dts; +Cc: GuYongjie

From: GuYongjie <yongjiex.gu@intel.com>

Fdir & pmdreereta will verify the nic before the check of checklist.
Also Fdir & multiprocess will verify whether the os is freebsd at set_up_all.And then the checklist 
will not work.
Remove the verification.

Signed-off-by: GuYongjie <yongjiex.gu@intel.com>
---
 conf/dpdk_test_case_checklist.xls |  Bin 31232 -> 31232 bytes
 tests/TestSuite_fdir.py           |   10 +++++-----
 tests/TestSuite_multiprocess.py   |    2 +-
 tests/TestSuite_pmdrssreta.py     |    6 +++---
 4 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/conf/dpdk_test_case_checklist.xls b/conf/dpdk_test_case_checklist.xls
index 0cb437cbcb62ce389428a77375794c7ecbb96d1e..821f43d2ac3fd7e621c6074ce6da25d25bb56211 100644
GIT binary patch
delta 1359
zcmZ|OJxo(k6ae6J-)oC~1z(6r3+3^r2#?ajD?b$wC{#e8g;o+67;quF=%NM}4GW2G
z#1ln>L>P>T#zgZ5L;P7_FfmbA;^d?WlaWCNjrZQ3wvWM~ulMIW=biiWmiF1wK6_cG
zvT@vS2k@5a{ZH$*TE}OesRn<3kWb<N=6$V8M6S5XG4AqZTg42#@Kyl;1>{t*0)ALw
z`2mrUXVFTXgJt-`RU#9Vq2|uE$}!^3CJkuC5;Kuf#P%0rMYqG*75RBZyp9299cB1i
z=Jj}}0E~Nh@%FgqQ>bCCo0kV3n7*{IaLrnVqcA<?7>SCJUF?fa7x|88d?{z`)u`8P
zZ^uHavC|3A<py}r1)zBV)?)yA5x~jQ0Qb??yXu|o1t=K>cx^xLU39ZX`^4aNg>~2u
z6UP)5#TUcFtQ~(1KV=%OjhMzM{^mcR@m*t}^P+M+h4(c4He%{cG!~G;!irJTXrr+T
z{yzj}z9({6IPVaZQZ$pOq#REiA}B?OM3BUuLsUu8LZXU<b*@l{Aw`&kL1NJ%s-=jK
zs3!5wA!?*(B~e2{9Wz;*9UePiMs6c&<y3B~YWdaEp%W7mCNuH!M38mjoe9&(ExG=X
zt|$GO>kuADeLQKh792>5$ho9x<d)HJD6)YfH@S}BN2$N_b}N>qL}WN+8vIho!)!Vf
z*+h|7Qznbyy3|`KQ|DJk>Sn1e{K+$jt0}I7I1U|p^1bZA#wH6w9ET44vPs`UIc_?H
zSceX0NQ6mjJA^n69r{Q_NO-3TZxP3#LqCaD5>pN#uA<JrzHA+BB<?wcB}JTsMdGVN
zM5P!c5hYQVF4WO3#Sn>h5*O2^p4+hwK9_(5K28T&Bfd$``cys==Rbfe`09K`U;|v>
z<9loHdR0F^6yRz6;K#{Kk}cS4nPsNzW$Z_p3(Ve`*<^QTw%oh(U%L10_cJ~9Y~DV&
HQN;cMR6Y6J

delta 1368
zcmZ|OO-vI(6ae5i+aF{>Hfn=NyHLQ^E``!A<wpeMul%)zS_~$hykI;VC4?A4NKA+a
zLwt!C<Dv0lVmzpO(Zq1#z=?2$gYjfI88yU6qTtN*m2MASwli<OdHde%boqcSAF#I#
z4)zjrt{Pl&l>cY6>S*9AuN^vnZpo+cM<?Fz6g$_P)i~g+$d4)+l*1<l02Gi*l?t4P
zHFgpZ8F?1<j6LYVedlSJz=NtQKdQ!vE1$GRt(2IFlwxmxaj%%h?NgDTSH$bMYOlkC
zzhz#xn+m`IH!t3rbZ>_POP6_h;D(tyb947%51|U?r)?2aME+o(Ia3xnrSeu1*1B2l
zVt#DvYP51)VTZok0g!Y7<T?S)x&hvG0W_5X___fe<9^S&x_AX3ItH*eg~!<!R-kv!
z$wKc3?<=gsnjb!=uy%ZuNU%8WBwn!~E{q!bC0@f{Q2F^W(0F-;nZjp5+!!@9gJLyO
znD~qDic#zW{~dznlbOh2V((Z{)JhR1QA;^iY{Dx=3kffYEt~L3(MrNcqH4VO7F~)6
z37y1so2ZkbjYJ)Z=QdF<MU+H6i7(>@i&^T#A=3*7;g?H=qw@1hs6i+ClLl+X$)uNc
z;%z<-<C+}5Ng8^gxu%kxO|<hT*RAMFiJjdkLoc)uDA57ZOI#G%2$qN-iOrP3qWDeb
zQ`3gduZjG`p%NV;ok<(48yC~!?N8H&Ca$Tt5Y1AXxXm;4P)vMA4frLKB22<FRTQFA
z4SGqmkhp0R;xlT{N1~NP&L%|v8uXKhkoam7qJNG5_wseLk!YDN)*(Kl1_LCbB<|XT
zxWXC?l8BM`U=yYkLnKTRM>f$e#W0C>5+fNyE1X!IuMNWpKFD}k2%lwcum=2|iB`n<
x=>zw1h-3I#N?FZV$Jtv9ce59jsw^LWR-Vj$bWLnVJU^_B*`7wWVjV7&v48QJ2p9kW

diff --git a/tests/TestSuite_fdir.py b/tests/TestSuite_fdir.py
index 94c5e0a..1372674 100644
--- a/tests/TestSuite_fdir.py
+++ b/tests/TestSuite_fdir.py
@@ -150,12 +150,12 @@ class TestFdir(TestCase, IxiaPacketGenerator):
         PMD prerequisites.
         """
         self.tester.extend_external_packet_generator(TestFdir, self)
-        self.verify('bsdapp' not in self.target, "FDIR not support freebsd")
+        #self.verify('bsdapp' not in self.target, "FDIR not support freebsd")
         # this feature support Fortville, Niantic
-        self.verify(self.nic in ["kawela_2", "niantic", "bartonhills", "82545EM",
-                                 "82540EM", "springfountain", "fortville_eagle",
-                                 "fortville_spirit", "fortville_spirit_single"],
-                    "NIC Unsupported: " + str(self.nic))
+        #self.verify(self.nic in ["kawela_2", "niantic", "bartonhills", "82545EM",
+        #                         "82540EM", "springfountain", "fortville_eagle",
+        #                         "fortville_spirit", "fortville_spirit_single"],
+        #            "NIC Unsupported: " + str(self.nic))
 
         # Based on h/w type, choose how many ports to use
         self.dut_ports = self.dut.get_ports(self.nic)
diff --git a/tests/TestSuite_multiprocess.py b/tests/TestSuite_multiprocess.py
index a19967c..6365892 100644
--- a/tests/TestSuite_multiprocess.py
+++ b/tests/TestSuite_multiprocess.py
@@ -53,7 +53,7 @@ class TestMultiprocess(TestCase, IxiaPacketGenerator):
             DUT core number >= 4
             multi_process build pass
         """
-        self.verify('bsdapp' not in self.target, "Multiprocess not support freebsd")
+        #self.verify('bsdapp' not in self.target, "Multiprocess not support freebsd")
 
         self.verify(len(self.dut.get_all_cores()) >= 4, "Not enough Cores")
         self.tester.extend_external_packet_generator(TestMultiprocess, self)
diff --git a/tests/TestSuite_pmdrssreta.py b/tests/TestSuite_pmdrssreta.py
index df9c16c..5e2d1b8 100644
--- a/tests/TestSuite_pmdrssreta.py
+++ b/tests/TestSuite_pmdrssreta.py
@@ -173,9 +173,9 @@ class TestPmdrssreta(TestCase):
         Run at the start of each test suite.
         """
 
-        self.verify(
-            self.nic in ["niantic", "fortville_eagle", "fortville_spirit", "fortville_spirit_single"],
-            "NIC Unsupported: " + str(self.nic))
+        #self.verify(
+        #    self.nic in ["niantic", "fortville_eagle", "fortville_spirit", "fortville_spirit_single"],
+        #    "NIC Unsupported: " + str(self.nic))
         ports = self.dut.get_ports(self.nic)
         self.ports_socket = self.dut.get_numa_id(ports[0])
         self.verify(len(ports) >= 1, "Not enough ports available")
-- 
1.7.4.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH] remove 1G nics & freebsd not support judgement from fdir, pmdrssreta, multiprocess
  2015-09-21  7:48 [dts] [PATCH] remove 1G nics & freebsd not support judgement from fdir, pmdrssreta, multiprocess Yongjie
@ 2015-09-23  2:26 ` Liu, Yong
  0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2015-09-23  2:26 UTC (permalink / raw)
  To: Gu, YongjieX, dts; +Cc: Gu, YongjieX

Applied. Thanks.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Yongjie
> Sent: Monday, September 21, 2015 3:48 PM
> To: dts@dpdk.org
> Cc: Gu, YongjieX
> Subject: [dts] [PATCH] remove 1G nics & freebsd not support judgement from
> fdir, pmdrssreta, multiprocess
> 
> From: GuYongjie <yongjiex.gu@intel.com>
> 
> Fdir & pmdreereta will verify the nic before the check of checklist.
> Also Fdir & multiprocess will verify whether the os is freebsd at
> set_up_all.And then the checklist
> will not work.
> Remove the verification.
> 
> Signed-off-by: GuYongjie <yongjiex.gu@intel.com>
> ---
>  conf/dpdk_test_case_checklist.xls |  Bin 31232 -> 31232 bytes
>  tests/TestSuite_fdir.py           |   10 +++++-----
>  tests/TestSuite_multiprocess.py   |    2 +-
>  tests/TestSuite_pmdrssreta.py     |    6 +++---
>  4 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/conf/dpdk_test_case_checklist.xls
> b/conf/dpdk_test_case_checklist.xls
> index
> 0cb437cbcb62ce389428a77375794c7ecbb96d1e..821f43d2ac3fd7e621c6074ce6da25d2
> 5bb56211 100644
> GIT binary patch
> delta 1359
> zcmZ|OJxo(k6ae6J-)oC~1z(6r3+3^r2#?ajD?b$wC{#e8g;o+67;quF=%NM}4GW2G
> z#1ln>L>P>T#zgZ5L;P7_FfmbA;^d?WlaWCNjrZQ3wvWM~ulMIW=biiWmiF1wK6_cG
> zvT@vS2k@5a{ZH$*TE}OesRn<3kWb<N=6$V8M6S5XG4AqZTg42#@Kyl;1>{t*0)ALw
> z`2mrUXVFTXgJt-`RU#9Vq2|uE$}!^3CJkuC5;Kuf#P%0rMYqG*75RBZyp9299cB1i
> z=Jj}}0E~Nh@%FgqQ>bCCo0kV3n7*{IaLrnVqcA<?7>SCJUF?fa7x|88d?{z`)u`8P
> zZ^uHavC|3A<py}r1)zBV)?)yA5x~jQ0Qb??yXu|o1t=K>cx^xLU39ZX`^4aNg>~2u
> z6UP)5#TUcFtQ~(1KV=%OjhMzM{^mcR@m*t}^P+M+h4(c4He%{cG!~G;!irJTXrr+T
> z{yzj}z9({6IPVaZQZ$pOq#REiA}B?OM3BUuLsUu8LZXU<b*@l{Aw`&kL1NJ%s-=jK
> zs3!5wA!?*(B~e2{9Wz;*9UePiMs6c&<y3B~YWdaEp%W7mCNuH!M38mjoe9&(ExG=X
> zt|$GO>kuADeLQKh792>5$ho9x<d)HJD6)YfH@S}BN2$N_b}N>qL}WN+8vIho!)!Vf
> z*+h|7Qznbyy3|`KQ|DJk>Sn1e{K+$jt0}I7I1U|p^1bZA#wH6w9ET44vPs`UIc_?H
> zSceX0NQ6mjJA^n69r{Q_NO-3TZxP3#LqCaD5>pN#uA<JrzHA+BB<?wcB}JTsMdGVN
> zM5P!c5hYQVF4WO3#Sn>h5*O2^p4+hwK9_(5K28T&Bfd$``cys==Rbfe`09K`U;|v>
> z<9loHdR0F^6yRz6;K#{Kk}cS4nPsNzW$Z_p3(Ve`*<^QTw%oh(U%L10_cJ~9Y~DV&
> HQN;cMR6Y6J
> 
> delta 1368
> zcmZ|OO-vI(6ae5i+aF{>Hfn=NyHLQ^E``!A<wpeMul%)zS_~$hykI;VC4?A4NKA+a
> zLwt!C<Dv0lVmzpO(Zq1#z=?2$gYjfI88yU6qTtN*m2MASwli<OdHde%boqcSAF#I#
> z4)zjrt{Pl&l>cY6>S*9AuN^vnZpo+cM<?Fz6g$_P)i~g+$d4)+l*1<l02Gi*l?t4P
> zHFgpZ8F?1<j6LYVedlSJz=NtQKdQ!vE1$GRt(2IFlwxmxaj%%h?NgDTSH$bMYOlkC
> zzhz#xn+m`IH!t3rbZ>_POP6_h;D(tyb947%51|U?r)?2aME+o(Ia3xnrSeu1*1B2l
> zVt#DvYP51)VTZok0g!Y7<T?S)x&hvG0W_5X___fe<9^S&x_AX3ItH*eg~!<!R-kv!
> z$wKc3?<=gsnjb!=uy%ZuNU%8WBwn!~E{q!bC0@f{Q2F^W(0F-;nZjp5+!!@9gJLyO
> znD~qDic#zW{~dznlbOh2V((Z{)JhR1QA;^iY{Dx=3kffYEt~L3(MrNcqH4VO7F~)6
> z37y1so2ZkbjYJ)Z=QdF<MU+H6i7(>@i&^T#A=3*7;g?H=qw@1hs6i+ClLl+X$)uNc
> z;%z<-<C+}5Ng8^gxu%kxO|<hT*RAMFiJjdkLoc)uDA57ZOI#G%2$qN-iOrP3qWDeb
> zQ`3gduZjG`p%NV;ok<(48yC~!?N8H&Ca$Tt5Y1AXxXm;4P)vMA4frLKB22<FRTQFA
> z4SGqmkhp0R;xlT{N1~NP&L%|v8uXKhkoam7qJNG5_wseLk!YDN)*(Kl1_LCbB<|XT
> zxWXC?l8BM`U=yYkLnKTRM>f$e#W0C>5+fNyE1X!IuMNWpKFD}k2%lwcum=2|iB`n<
> x=>zw1h-3I#N?FZV$Jtv9ce59jsw^LWR-Vj$bWLnVJU^_B*`7wWVjV7&v48QJ2p9kW
> 
> diff --git a/tests/TestSuite_fdir.py b/tests/TestSuite_fdir.py
> index 94c5e0a..1372674 100644
> --- a/tests/TestSuite_fdir.py
> +++ b/tests/TestSuite_fdir.py
> @@ -150,12 +150,12 @@ class TestFdir(TestCase, IxiaPacketGenerator):
>          PMD prerequisites.
>          """
>          self.tester.extend_external_packet_generator(TestFdir, self)
> -        self.verify('bsdapp' not in self.target, "FDIR not support
> freebsd")
> +        #self.verify('bsdapp' not in self.target, "FDIR not support
> freebsd")
>          # this feature support Fortville, Niantic
> -        self.verify(self.nic in ["kawela_2", "niantic", "bartonhills",
> "82545EM",
> -                                 "82540EM", "springfountain",
> "fortville_eagle",
> -                                 "fortville_spirit",
> "fortville_spirit_single"],
> -                    "NIC Unsupported: " + str(self.nic))
> +        #self.verify(self.nic in ["kawela_2", "niantic", "bartonhills",
> "82545EM",
> +        #                         "82540EM", "springfountain",
> "fortville_eagle",
> +        #                         "fortville_spirit",
> "fortville_spirit_single"],
> +        #            "NIC Unsupported: " + str(self.nic))
> 
>          # Based on h/w type, choose how many ports to use
>          self.dut_ports = self.dut.get_ports(self.nic)
> diff --git a/tests/TestSuite_multiprocess.py
> b/tests/TestSuite_multiprocess.py
> index a19967c..6365892 100644
> --- a/tests/TestSuite_multiprocess.py
> +++ b/tests/TestSuite_multiprocess.py
> @@ -53,7 +53,7 @@ class TestMultiprocess(TestCase, IxiaPacketGenerator):
>              DUT core number >= 4
>              multi_process build pass
>          """
> -        self.verify('bsdapp' not in self.target, "Multiprocess not
> support freebsd")
> +        #self.verify('bsdapp' not in self.target, "Multiprocess not
> support freebsd")
> 
>          self.verify(len(self.dut.get_all_cores()) >= 4, "Not enough
> Cores")
>          self.tester.extend_external_packet_generator(TestMultiprocess,
> self)
> diff --git a/tests/TestSuite_pmdrssreta.py b/tests/TestSuite_pmdrssreta.py
> index df9c16c..5e2d1b8 100644
> --- a/tests/TestSuite_pmdrssreta.py
> +++ b/tests/TestSuite_pmdrssreta.py
> @@ -173,9 +173,9 @@ class TestPmdrssreta(TestCase):
>          Run at the start of each test suite.
>          """
> 
> -        self.verify(
> -            self.nic in ["niantic", "fortville_eagle", "fortville_spirit",
> "fortville_spirit_single"],
> -            "NIC Unsupported: " + str(self.nic))
> +        #self.verify(
> +        #    self.nic in ["niantic", "fortville_eagle",
> "fortville_spirit", "fortville_spirit_single"],
> +        #    "NIC Unsupported: " + str(self.nic))
>          ports = self.dut.get_ports(self.nic)
>          self.ports_socket = self.dut.get_numa_id(ports[0])
>          self.verify(len(ports) >= 1, "Not enough ports available")
> --
> 1.7.4.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-09-23  2:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-21  7:48 [dts] [PATCH] remove 1G nics & freebsd not support judgement from fdir, pmdrssreta, multiprocess Yongjie
2015-09-23  2:26 ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).