test suite reviews and discussions
 help / color / mirror / Atom feed
From: Michael Qiu <michael.qiu@intel.com>
To: dts@dpdk.org
Subject: [dts] [PATCH] jumboframes: Fix bug for fm10k NIC
Date: Wed, 14 Oct 2015 11:15:09 +0800	[thread overview]
Message-ID: <1444792509-19136-1-git-send-email-michael.qiu@intel.com> (raw)

For Ruby Rapid, in Testpoint should run "set port config 1,5 max_frame_size 9000"
and "set port config 1,5,20,22 rx_cut_through off"

Singed-off-by: Michael Qiu <michael.qiu@intel.com>
---
 tests/TestSuite_jumboframes.py | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/tests/TestSuite_jumboframes.py b/tests/TestSuite_jumboframes.py
index c5c70b9..e9a6abf 100644
--- a/tests/TestSuite_jumboframes.py
+++ b/tests/TestSuite_jumboframes.py
@@ -93,7 +93,9 @@ class TestJumboframes(TestCase):
         p1rx_err -= gp1rx_err
 
         if received:
-            self.verify(p0tx_pkts == p1rx_pkts and p0tx_bytes == pktsize and p1rx_bytes == pktsize,
+            #some nic like RRC always strip CRC, so it should be pktsize - 4
+            size_equal = p0tx_bytes == p1rx_bytes and (p1rx_bytes == pktsize or  p1rx_bytes == pktsize - 4)
+            self.verify(p0tx_pkts == p1rx_pkts and size_equal,
                         "packet pass assert error")
         else:
             #self.verify(p0tx_pkts == p1rx_pkts and (p1rx_err == 1 or p1rx_pkts == 0),
@@ -152,10 +154,12 @@ class TestJumboframes(TestCase):
         This case aims to test transmitting jumbo frame packet on testpmd without
         jumbo frame support.
         """
-        self.pmdout.start_testpmd("Default", "--max-pkt-len=%d" % (ETHER_STANDARD_MTU))
+        # RRC has no ability to set the max pkt len to hardware
         if self.nic == "redrockcanyou":
-            self.dut.send_expect("set promisc all off", "testpmd> ")
-            self.dut.send_expect("set fwd mac", "testpmd> ")
+            print dts.RED("fm10k not support this case\n")
+            return
+        self.pmdout.start_testpmd("Default", "--max-pkt-len=%d" % (ETHER_STANDARD_MTU))
+        self.dut.send_expect("set fwd mac", "testpmd> ")
         self.dut.send_expect("start", "testpmd> ")
 
         self.jumboframes_send_packet(ETHER_STANDARD_MTU + 1, False)
-- 
1.9.3

             reply	other threads:[~2015-10-14  3:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-14  3:15 Michael Qiu [this message]
2015-10-14 10:19 ` Liu, Yong
2015-11-04  5:45   ` Qiu, Michael
2015-11-04  7:10     ` Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1444792509-19136-1-git-send-email-michael.qiu@intel.com \
    --to=michael.qiu@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).