test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH] fix queue start/stop case failed sometime print can't get received package info, used self.dut.get_session_output() replace self.dut.send_expect("\n", "testpmd>") get received package info
@ 2015-10-23  7:02 xu,huilong
  2015-10-23  7:33 ` Liu, Yong
  0 siblings, 1 reply; 2+ messages in thread
From: xu,huilong @ 2015-10-23  7:02 UTC (permalink / raw)
  To: dts

Signed-off-by: xu,huilong <huilongx.xu@intel.com>
---
 tests/TestSuite_queue_start_stop.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_queue_start_stop.py b/tests/TestSuite_queue_start_stop.py
index 83504ab..f59333c 100644
--- a/tests/TestSuite_queue_start_stop.py
+++ b/tests/TestSuite_queue_start_stop.py
@@ -164,7 +164,7 @@ class TestQueueStartStop(TestCase):
             self.dut.send_expect("port 1 txq 0 stop", "testpmd>")
             self.dut.send_expect("start", "testpmd>")
             self.check_forwarding([0, 1], self.nic, received=False)
-            out = self.dut.send_expect("\n", "testpmd>")
+            out = self.dut.get_session_output()
         except Exception, e:
             raise IOError("queue start/stop forward failure: %s" % e)
 
-- 
1.9.3

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH] fix queue start/stop case failed sometime print can't get received package info, used self.dut.get_session_output() replace self.dut.send_expect("\n", "testpmd>") get received package info
  2015-10-23  7:02 [dts] [PATCH] fix queue start/stop case failed sometime print can't get received package info, used self.dut.get_session_output() replace self.dut.send_expect("\n", "testpmd>") get received package info xu,huilong
@ 2015-10-23  7:33 ` Liu, Yong
  0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2015-10-23  7:33 UTC (permalink / raw)
  To: xu,huilong, dts

Huilong,
It's better to separated the commit into two parts. This first part just 
one simple line describe the patch.
The second part is the detail description of the patch. Below is one 
sample for commit log.

tests: fix queue start/stop case can't capture log

Sometime print can't get received package info, used 
self.dut.get_session_output() replace self.dut.send_expect("\n", 
"testpmd>")  to get received package info.

Signed-off-by: XXXXXXX@XXXXXX

On 10/23/2015 03:02 PM, xu,huilong wrote:
> Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> ---
>   tests/TestSuite_queue_start_stop.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/TestSuite_queue_start_stop.py b/tests/TestSuite_queue_start_stop.py
> index 83504ab..f59333c 100644
> --- a/tests/TestSuite_queue_start_stop.py
> +++ b/tests/TestSuite_queue_start_stop.py
> @@ -164,7 +164,7 @@ class TestQueueStartStop(TestCase):
>               self.dut.send_expect("port 1 txq 0 stop", "testpmd>")
>               self.dut.send_expect("start", "testpmd>")
>               self.check_forwarding([0, 1], self.nic, received=False)
> -            out = self.dut.send_expect("\n", "testpmd>")
> +            out = self.dut.get_session_output()
>           except Exception, e:
>               raise IOError("queue start/stop forward failure: %s" % e)
>   

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-10-23  7:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-23  7:02 [dts] [PATCH] fix queue start/stop case failed sometime print can't get received package info, used self.dut.get_session_output() replace self.dut.send_expect("\n", "testpmd>") get received package info xu,huilong
2015-10-23  7:33 ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).