test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH] fix shutdown api bug on 1G nics
@ 2015-11-11  8:45 yongjie
  0 siblings, 0 replies; 3+ messages in thread
From: yongjie @ 2015-11-11  8:45 UTC (permalink / raw)
  To: dts; +Cc: Gu yongjie

From: Gu yongjie <yongjiex.gu@intel.com>


Signed-off-by: Gu yongjie <yongjiex.gu@intel.com>
---
 tests/TestSuite_shutdown_api.py |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
index d672d50..2202ae1 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -147,8 +147,7 @@ class TestShutdownApi(TestCase):
                 rx_bytes_exp -= 4
                 tx_bytes_exp -= 4
         elif self.nic in ["fortville_eagle", "fortville_spirit",
-                        "fortville_spirit_single", "bartonhills",
-                        "powerville", "springville", "hartwell"]:
+                        "fortville_spirit_single", "bartonhills"]:
             # some NIC will always strip tx crc
             tx_bytes_exp -= 4
             if vlan is True:
@@ -156,7 +155,7 @@ class TestShutdownApi(TestCase):
                 tx_bytes_exp -= 4
         else:
             # some NIC will always include tx crc
-            if crcStrip is True:
+            if crcStrip is True and self.nic not in ["springville", "powerville"]:
                 rx_bytes_exp -= 4
             if vlan is True:
                 # vlan strip default is on
@@ -354,7 +353,7 @@ class TestShutdownApi(TestCase):
         self.dut.send_expect("port start all", "testpmd> ", 100)
         self.dut.send_expect("start", "testpmd> ")
 
-        if self.nic in ['niantic']:
+        if self.nic in ['niantic', 'twinpond', 'kawela_4', 'ironpond', 'springfountain', 'springville', 'powerville']:
             # nantic vlan length will not be calculated
             vlan_jumbo_size = jumbo_size + 4
         else:
-- 
1.7.4.4

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH] fix shutdown api bug on 1G nics
  2015-11-11  9:04 yongjie
@ 2015-11-11 14:46 ` Liu, Yong
  0 siblings, 0 replies; 3+ messages in thread
From: Liu, Yong @ 2015-11-11 14:46 UTC (permalink / raw)
  To: yongjie, dts

Applied. Thanks.

On 11/11/2015 05:04 PM, yongjie wrote:
> From: Gu yongjie <yongjiex.gu@intel.com>
>
>
> Signed-off-by: Gu yongjie <yongjiex.gu@intel.com>
> ---
>   tests/TestSuite_shutdown_api.py |    9 ++++++---
>   1 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
> index d672d50..3800669 100644
> --- a/tests/TestSuite_shutdown_api.py
> +++ b/tests/TestSuite_shutdown_api.py
> @@ -147,13 +147,16 @@ class TestShutdownApi(TestCase):
>                   rx_bytes_exp -= 4
>                   tx_bytes_exp -= 4
>           elif self.nic in ["fortville_eagle", "fortville_spirit",
> -                        "fortville_spirit_single", "bartonhills",
> -                        "powerville", "springville", "hartwell"]:
> +                        "fortville_spirit_single", "bartonhills"]:
>               # some NIC will always strip tx crc
>               tx_bytes_exp -= 4
>               if vlan is True:
>                   # vlan strip default is on
>                   tx_bytes_exp -= 4
> +        elif self.nic in ["springville", "powerville"]:
> +            if vlan is True:
> +                # vlan strip default is on
> +                tx_bytes_exp -= 4
>           else:
>               # some NIC will always include tx crc
>               if crcStrip is True:
> @@ -354,7 +357,7 @@ class TestShutdownApi(TestCase):
>           self.dut.send_expect("port start all", "testpmd> ", 100)
>           self.dut.send_expect("start", "testpmd> ")
>   
> -        if self.nic in ['niantic']:
> +        if self.nic in ['niantic', 'twinpond', 'kawela_4', 'ironpond', 'springfountain', 'springville', 'powerville']:
>               # nantic vlan length will not be calculated
>               vlan_jumbo_size = jumbo_size + 4
>           else:

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts] [PATCH] fix shutdown api bug on 1G nics
@ 2015-11-11  9:04 yongjie
  2015-11-11 14:46 ` Liu, Yong
  0 siblings, 1 reply; 3+ messages in thread
From: yongjie @ 2015-11-11  9:04 UTC (permalink / raw)
  To: dts; +Cc: Gu yongjie

From: Gu yongjie <yongjiex.gu@intel.com>


Signed-off-by: Gu yongjie <yongjiex.gu@intel.com>
---
 tests/TestSuite_shutdown_api.py |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
index d672d50..3800669 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -147,13 +147,16 @@ class TestShutdownApi(TestCase):
                 rx_bytes_exp -= 4
                 tx_bytes_exp -= 4
         elif self.nic in ["fortville_eagle", "fortville_spirit",
-                        "fortville_spirit_single", "bartonhills",
-                        "powerville", "springville", "hartwell"]:
+                        "fortville_spirit_single", "bartonhills"]:
             # some NIC will always strip tx crc
             tx_bytes_exp -= 4
             if vlan is True:
                 # vlan strip default is on
                 tx_bytes_exp -= 4
+        elif self.nic in ["springville", "powerville"]:
+            if vlan is True:
+                # vlan strip default is on
+                tx_bytes_exp -= 4
         else:
             # some NIC will always include tx crc
             if crcStrip is True:
@@ -354,7 +357,7 @@ class TestShutdownApi(TestCase):
         self.dut.send_expect("port start all", "testpmd> ", 100)
         self.dut.send_expect("start", "testpmd> ")
 
-        if self.nic in ['niantic']:
+        if self.nic in ['niantic', 'twinpond', 'kawela_4', 'ironpond', 'springfountain', 'springville', 'powerville']:
             # nantic vlan length will not be calculated
             vlan_jumbo_size = jumbo_size + 4
         else:
-- 
1.7.4.4

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-11-11 14:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-11  8:45 [dts] [PATCH] fix shutdown api bug on 1G nics yongjie
2015-11-11  9:04 yongjie
2015-11-11 14:46 ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).