* [dts] [DTS][PATCH] fix jumbo frame crc issue for fortville nics
@ 2015-11-13 7:35 Jingguo Fu
2015-11-13 9:14 ` Liu, Yong
0 siblings, 1 reply; 2+ messages in thread
From: Jingguo Fu @ 2015-11-13 7:35 UTC (permalink / raw)
To: dts; +Cc: Jingguo Fu
Changes to be committed:
modified: tests/TestSuite_jumboframes.py
Signed-off-by: Jingguo Fu <jingguox.fu@intel.com>
---
tests/TestSuite_jumboframes.py | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/tests/TestSuite_jumboframes.py b/tests/TestSuite_jumboframes.py
index d9261e6..a295624 100644
--- a/tests/TestSuite_jumboframes.py
+++ b/tests/TestSuite_jumboframes.py
@@ -93,10 +93,12 @@ class TestJumboframes(TestCase):
p1rx_err -= gp1rx_err
if received:
- #some nic like RRC always strip CRC, so it should be pktsize - 4
- size_equal = p0tx_bytes == p1rx_bytes and (p1rx_bytes == pktsize or p1rx_bytes == pktsize - 4)
- self.verify(p0tx_pkts == p1rx_pkts and size_equal,
- "packet pass assert error")
+ if self.nic in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single"]:
+ self.verify((p0tx_pkts == p1rx_pkts) and ((p0tx_bytes + 4) == pktsize) and (p1rx_bytes == pktsize),
+ "packet pass assert error")
+ else:
+ self.verify((p0tx_pkts == p1rx_pkts) and (p0tx_bytes == pktsize) and (p1rx_bytes == pktsize),
+ "packet pass assert error")
else:
#self.verify(p0tx_pkts == p1rx_pkts and (p1rx_err == 1 or p1rx_pkts == 0),
self.verify(p1rx_err == 1 or p0tx_pkts == 0, "packet drop assert error")
--
1.9.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dts] [DTS][PATCH] fix jumbo frame crc issue for fortville nics
2015-11-13 7:35 [dts] [DTS][PATCH] fix jumbo frame crc issue for fortville nics Jingguo Fu
@ 2015-11-13 9:14 ` Liu, Yong
0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2015-11-13 9:14 UTC (permalink / raw)
To: Jingguo Fu, dts
Applied. Thanks.
On 11/13/2015 03:35 PM, Jingguo Fu wrote:
> Changes to be committed:
> modified: tests/TestSuite_jumboframes.py
Take care, this should not be included in commit log.
> Signed-off-by: Jingguo Fu <jingguox.fu@intel.com>
> ---
> tests/TestSuite_jumboframes.py | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/tests/TestSuite_jumboframes.py b/tests/TestSuite_jumboframes.py
> index d9261e6..a295624 100644
> --- a/tests/TestSuite_jumboframes.py
> +++ b/tests/TestSuite_jumboframes.py
> @@ -93,10 +93,12 @@ class TestJumboframes(TestCase):
> p1rx_err -= gp1rx_err
>
> if received:
> - #some nic like RRC always strip CRC, so it should be pktsize - 4
> - size_equal = p0tx_bytes == p1rx_bytes and (p1rx_bytes == pktsize or p1rx_bytes == pktsize - 4)
> - self.verify(p0tx_pkts == p1rx_pkts and size_equal,
> - "packet pass assert error")
> + if self.nic in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single"]:
> + self.verify((p0tx_pkts == p1rx_pkts) and ((p0tx_bytes + 4) == pktsize) and (p1rx_bytes == pktsize),
> + "packet pass assert error")
> + else:
> + self.verify((p0tx_pkts == p1rx_pkts) and (p0tx_bytes == pktsize) and (p1rx_bytes == pktsize),
> + "packet pass assert error")
> else:
> #self.verify(p0tx_pkts == p1rx_pkts and (p1rx_err == 1 or p1rx_pkts == 0),
> self.verify(p1rx_err == 1 or p0tx_pkts == 0, "packet drop assert error")
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-13 9:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-13 7:35 [dts] [DTS][PATCH] fix jumbo frame crc issue for fortville nics Jingguo Fu
2015-11-13 9:14 ` Liu, Yong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).