test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [DTS][PATCH] fix result verify issue for crc in dpdk update
@ 2015-11-19  6:51 Jingguo Fu
  2015-11-19  7:18 ` Liu, Yong
  0 siblings, 1 reply; 2+ messages in thread
From: Jingguo Fu @ 2015-11-19  6:51 UTC (permalink / raw)
  To: dts; +Cc: Jingguo Fu

Signed-off-by: Jingguo Fu <jingguox.fu@intel.com>
---
 tests/TestSuite_pmd.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_pmd.py b/tests/TestSuite_pmd.py
index 29dec2b..740504f 100644
--- a/tests/TestSuite_pmd.py
+++ b/tests/TestSuite_pmd.py
@@ -407,13 +407,13 @@ class TestPmd(TestCase,IxiaPacketGenerator):
             	self.verify(p1rx_bytes == frame_size,
                         	"packet pass assert error, expected %d RX bytes, actual %d" % (frame_size, p1rx_bytes))
             else:
-            	self.verify(p1rx_bytes == frame_size - 4,
+            	self.verify(p1rx_bytes == frame_size,
                         	"packet pass assert error, expected %d RX bytes, actual %d" % (frame_size - 4, p1rx_bytes))
         else:
             self.verify(p1rx_bytes == frame_size,
                         "packet pass assert error, expected %d RX bytes, actual %d" % (frame_size, p1rx_bytes))
 
-        self.verify(p0tx_bytes == frame_size,
+        self.verify((p0tx_bytes + 4) == frame_size,
                     "packet pass assert error, expected %d TX bytes, actual %d" % (frame_size, p0tx_bytes))
 
         return out
-- 
1.9.3

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [DTS][PATCH] fix result verify issue for crc in dpdk update
  2015-11-19  6:51 [dts] [DTS][PATCH] fix result verify issue for crc in dpdk update Jingguo Fu
@ 2015-11-19  7:18 ` Liu, Yong
  0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2015-11-19  7:18 UTC (permalink / raw)
  To: Fu, JingguoX, dts

Hi Jingguo,
This fix may not work on other NICs, you can reference to function send_packet in shutdown_api suite.
The function also handled crc and vlan packet length in testpmd.

> -----Original Message-----
> From: Fu, JingguoX
> Sent: Thursday, November 19, 2015 2:52 PM
> To: dts@dpdk.org
> Cc: Liu, Yong; Xu, HuilongX; Fu, JingguoX
> Subject: [DTS][PATCH] fix result verify issue for crc in dpdk update
> 
> Signed-off-by: Jingguo Fu <jingguox.fu@intel.com>
> ---
>  tests/TestSuite_pmd.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_pmd.py b/tests/TestSuite_pmd.py
> index 29dec2b..740504f 100644
> --- a/tests/TestSuite_pmd.py
> +++ b/tests/TestSuite_pmd.py
> @@ -407,13 +407,13 @@ class TestPmd(TestCase,IxiaPacketGenerator):
>              	self.verify(p1rx_bytes == frame_size,
>                          	"packet pass assert error, expected %d RX
> bytes, actual %d" % (frame_size, p1rx_bytes))
>              else:
> -            	self.verify(p1rx_bytes == frame_size - 4,
> +            	self.verify(p1rx_bytes == frame_size,
>                          	"packet pass assert error, expected %d RX
> bytes, actual %d" % (frame_size - 4, p1rx_bytes))
>          else:
>              self.verify(p1rx_bytes == frame_size,
>                          "packet pass assert error, expected %d RX bytes,
> actual %d" % (frame_size, p1rx_bytes))
> 
> -        self.verify(p0tx_bytes == frame_size,
> +        self.verify((p0tx_bytes + 4) == frame_size,
>                      "packet pass assert error, expected %d TX bytes,
> actual %d" % (frame_size, p0tx_bytes))
> 
>          return out
> --
> 1.9.3

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-11-19  7:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-19  6:51 [dts] [DTS][PATCH] fix result verify issue for crc in dpdk update Jingguo Fu
2015-11-19  7:18 ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).