test suite reviews and discussions
 help / color / mirror / Atom feed
From: Lijuan Tu <lijuanx.a.tu@intel.com>
To: dts@dpdk.org
Subject: [dts] [PATCH]tests multiprocess: fix cmds error while using kill_all
Date: Fri, 27 Nov 2015 15:01:50 +0800	[thread overview]
Message-ID: <1448607710-26950-1-git-send-email-lijuanx.a.tu@intel.com> (raw)

Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
---
 tests/TestSuite_multiprocess.py | 31 +++++++++++++++++++------------
 1 file changed, 19 insertions(+), 12 deletions(-)

diff --git a/tests/TestSuite_multiprocess.py b/tests/TestSuite_multiprocess.py
index 7bc005d..e0a6f0e 100644
--- a/tests/TestSuite_multiprocess.py
+++ b/tests/TestSuite_multiprocess.py
@@ -73,7 +73,7 @@ class TestMultiprocess(TestCase, IxiaPacketGenerator):
         """
         Run before each test case.
         """
-        pass
+        self.kill_all()
 
     def test_multiprocess_simple_mpbasicoperation(self):
         """
@@ -106,9 +106,6 @@ class TestMultiprocess(TestCase, IxiaPacketGenerator):
         Load test of Simple MP application.
         """
 
-        self.dut.kill_all()
-        self.dut.send_expect("fg", "# ")
-
         self.dut.alt_session.send_expect("./examples/multi_process/simple_mp/simple_mp/%s/simple_mp -n 1 -c 3 --proc-type=primary" % self.target, "Finished Process Init", 100)
         time.sleep(20)
         self.dut.send_expect("./examples/multi_process/simple_mp/simple_mp/%s/simple_mp -n 1 -c C --proc-type=secondary" % self.target, "Finished Process Init", 100)
@@ -129,8 +126,6 @@ class TestMultiprocess(TestCase, IxiaPacketGenerator):
         Test use of Auto for Application Startup.
         """
 
-        self.dut.kill_all()
-
         # Send message from secondary to primary (auto process type)
         out = self.dut.send_expect("./examples/multi_process/simple_mp/simple_mp/%s/simple_mp -n 1 -c 3 --proc-type=auto " % self.target, "Finished Process Init", 100)
         self.verify("EAL: Auto-detected process type: PRIMARY" in out, "The type of process (PRIMARY) was not detected properly")
@@ -164,7 +159,6 @@ class TestMultiprocess(TestCase, IxiaPacketGenerator):
         Multiple processes without "--proc-type" flag.
         """
 
-        self.dut.kill_all()
         self.dut.alt_session.send_expect("./examples/multi_process/simple_mp/simple_mp/%s/simple_mp -n 1 -c 3 -m 64" % self.target, "Finished Process Init", 100)
         out = self.dut.send_expect("./examples/multi_process/simple_mp/simple_mp/%s/simple_mp -n 1 -c C" % self.target, "# ", 100)
 
@@ -177,7 +171,6 @@ class TestMultiprocess(TestCase, IxiaPacketGenerator):
         """
         Benchmark Multiprocess client-server performance.
         """
-        self.dut.kill_all()
         self.dut.send_expect("fg", "# ")
         dutPorts = self.dut.get_ports()
         txPort = self.tester.get_local_port(dutPorts[0])
@@ -247,16 +240,30 @@ class TestMultiprocess(TestCase, IxiaPacketGenerator):
         self.add_tcl_cmd("stream config -framesize %d" % (len + 18))
         self.add_tcl_cmd("ip set %d %d %d" % (self.chasId, port['card'], port['port']))
 
+    def kill_all(self):
+        """
+        Run after each test case.
+        """
+        try:
+            self.dut.kill_all(False)
+        except Exception as e:
+            msg = str(e)
+            self.logger.warning("session run cmds error")
+            self.logger.warning("**************************************")
+            self.logger.warning(msg)
+            self.logger.warning("**************************************")
+            self.logger.warning("choose alt_session to run cmds again")
+
+            self.dut.kill_all(True)
+
     def tear_down(self):
         """
         Run after each test case.
         """
-        pass
+        self.kill_all()
 
     def tear_down_all(self):
         """
         Run after each test suite.
         """
-        self.dut.kill_all()
-
-        pass
+        self.kill_all()
-- 
1.8.4.2

             reply	other threads:[~2015-11-27  7:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-27  7:01 Lijuan Tu [this message]
2015-11-27  8:50 ` Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1448607710-26950-1-git-send-email-lijuanx.a.tu@intel.com \
    --to=lijuanx.a.tu@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).