test suite reviews and discussions
 help / color / mirror / Atom feed
From: yongjie <yongjiex.gu@intel.com>
To: dts@dpdk.org
Cc: Gu yongjie <yongjiex.gu@intel.com>
Subject: [dts] [PATCH] change the verification of pktbytes in pmd cases
Date: Fri, 27 Nov 2015 15:09:33 +0800	[thread overview]
Message-ID: <1448608174-27198-1-git-send-email-yongjiex.gu@intel.com> (raw)

From: Gu yongjie <yongjiex.gu@intel.com>

Change the verification of pktbytes,because DPDK removes the crc bytes from byte counter.

Signed-off-by: Gu yongjie <yongjiex.gu@intel.com>
---
 tests/TestSuite_pmd.py |   20 ++++++--------------
 1 files changed, 6 insertions(+), 14 deletions(-)

diff --git a/tests/TestSuite_pmd.py b/tests/TestSuite_pmd.py
index 29dec2b..bfd5e03 100644
--- a/tests/TestSuite_pmd.py
+++ b/tests/TestSuite_pmd.py
@@ -299,7 +299,7 @@ class TestPmd(TestCase,IxiaPacketGenerator):
 
         for rxfreet_value in self.rxfreet_values:
 
-            self.pmdout.start_testpmd("all", "--coremask=%s --portmask=%s --nb-cores=2 --enable-rx-cksum --disable-hw-vlan --disable-rss --crc-strip --rxd=1024 --txd=1024 --rxfreet=%d" % (core_mask, port_mask, rxfreet_value))
+            self.pmdout.start_testpmd("all", "--coremask=%s --portmask=%s --nb-cores=2 --enable-rx-cksum --disable-hw-vlan --disable-rss --rxd=1024 --txd=1024 --rxfreet=%d" % (core_mask, port_mask, rxfreet_value))
             self.dut.send_expect("set fwd csum", "testpmd> ")
             self.dut.send_expect("start", "testpmd> ")
 
@@ -402,19 +402,11 @@ class TestPmd(TestCase,IxiaPacketGenerator):
         self.verify(p0tx_pkts == p1rx_pkts,
                     "packet pass assert error, %d RX packets, %d TX packets" % (p1rx_pkts, p0tx_pkts))
 
-        if checksum_test:
-            if self.nic in ["powerville", "springville", "kawela_4"]:
-            	self.verify(p1rx_bytes == frame_size,
-                        	"packet pass assert error, expected %d RX bytes, actual %d" % (frame_size, p1rx_bytes))
-            else:
-            	self.verify(p1rx_bytes == frame_size - 4,
-                        	"packet pass assert error, expected %d RX bytes, actual %d" % (frame_size - 4, p1rx_bytes))
-        else:
-            self.verify(p1rx_bytes == frame_size,
-                        "packet pass assert error, expected %d RX bytes, actual %d" % (frame_size, p1rx_bytes))
-
-        self.verify(p0tx_bytes == frame_size,
-                    "packet pass assert error, expected %d TX bytes, actual %d" % (frame_size, p0tx_bytes))
+        self.verify(p1rx_bytes == frame_size - 4,
+                    "packet pass assert error, expected %d RX bytes, actual %d" % (frame_size - 4, p1rx_bytes))
+
+        self.verify(p0tx_bytes == frame_size - 4,
+                    "packet pass assert error, expected %d TX bytes, actual %d" % (frame_size - 4, p0tx_bytes))
 
         return out
     
-- 
1.7.4.4

             reply	other threads:[~2015-11-27  7:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-27  7:09 yongjie [this message]
2015-11-27  7:09 ` [dts] [PATCH] change the verification of pktbytes in jumboframes cases yongjie
2015-11-27  8:10   ` Liu, Yong
2015-11-27  8:09 ` [dts] [PATCH] change the verification of pktbytes in pmd cases Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1448608174-27198-1-git-send-email-yongjiex.gu@intel.com \
    --to=yongjiex.gu@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).