test suite reviews and discussions
 help / color / mirror / Atom feed
From: Yong Liu <yong.liu@intel.com>
To: dts@dpdk.org
Subject: [dts] [PATCH 1/8] framework settings: rename nic_name_from_type to get_nic_name
Date: Sun, 13 Dec 2015 12:57:37 +0800	[thread overview]
Message-ID: <1449982664-4362-2-git-send-email-yong.liu@intel.com> (raw)
In-Reply-To: <1449982664-4362-1-git-send-email-yong.liu@intel.com>

From: Marvin Liu <yong.liu@intel.com>

This function will return nic name by pci type.

Signed-off-by: Marvin Liu <yong.liu@intel.com>

diff --git a/framework/checkCase.py b/framework/checkCase.py
index e7b22f1..94e6a4a 100644
--- a/framework/checkCase.py
+++ b/framework/checkCase.py
@@ -1,6 +1,6 @@
 import xlrd
 
-from settings import nic_name_from_type
+from settings import get_nic_name
 
 filter_file = r'./conf/dpdk_test_case_checklist.xls'
 filter_case = []
@@ -96,7 +96,7 @@ class check_case_skip():
     def check_nic(self, nic_type):
         if 'all' == nic_type[0].lower():
             return True
-        dut_nic_type = nic_name_from_type(self.dut.ports_info[0]['type'])
+        dut_nic_type = get_nic_name(self.dut.ports_info[0]['type'])
         if dut_nic_type in nic_type:
             return True
         else:
diff --git a/framework/settings.py b/framework/settings.py
index c99dcaa..0b658f2 100644
--- a/framework/settings.py
+++ b/framework/settings.py
@@ -40,6 +40,7 @@ FOLDERS = {
     'Configuration': 'conf',
     'Depends': 'dep',
     'Output': 'output',
+    'NicDriver': 'nics',
 }
 
 """
@@ -159,7 +160,7 @@ The log name seperater.
 LOG_NAME_SEP = '.'
 
 
-def nic_name_from_type(type):
+def get_nic_name(type):
     """
     strip nic code name by nic type
     """
diff --git a/framework/test_case.py b/framework/test_case.py
index 5013123..f601381 100644
--- a/framework/test_case.py
+++ b/framework/test_case.py
@@ -35,7 +35,7 @@ A base class for creating DTF test cases.
 
 import dts
 from exception import VerifyFailure
-from settings import DRIVERS, NICS, nic_name_from_type
+from settings import DRIVERS, NICS, get_nic_name
 
 
 class TestCase(object):
@@ -48,7 +48,7 @@ class TestCase(object):
         self.nics = []
         for portid in range(len(self.dut.ports_info)):
             nic_type = self.dut.ports_info[portid]['type']
-            self.nics.append(nic_name_from_type(nic_type))
+            self.nics.append(get_nic_name(nic_type))
         if len(self.nics):
             self.nic = self.nics[0]
         else:
-- 
1.9.3

  reply	other threads:[~2015-12-13  4:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-13  4:57 [dts] [RFC PATCH 0/8] support fm10k family nics Yong Liu
2015-12-13  4:57 ` Yong Liu [this message]
2015-12-13  4:57 ` [dts] [PATCH 2/8] framework crb: add function to retrieve port information Yong Liu
2015-12-13  4:57 ` [dts] [PATCH 3/8] framework: create independent foler for nic modules Yong Liu
2015-12-13  4:57 ` [dts] [PATCH 4/8] nics: add fm10k module for RedRockCanYou family nic Yong Liu
2015-12-13  4:57 ` [dts] [PATCH 5/8] framework: net device object get from net_device module Yong Liu
2015-12-13  4:57 ` [dts] [PATCH 6/8] framework dts: close netdevice related session after exit Yong Liu
2015-12-13  4:57 ` [dts] [PATCH 7/8] conf: add sample for RedRockCanYou family nic Yong Liu
2015-12-13  4:57 ` [dts] [PATCH 8/8] framework project_dpdk: add extra setup after bind driver Yong Liu
2015-12-14  1:34 ` [dts] [RFC PATCH 0/8] support fm10k family nics Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449982664-4362-2-git-send-email-yong.liu@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).