* [dts] [DTS][PATCH] change ringpmd test method , remove attach option
@ 2016-01-22 8:56 haifeng
2016-01-22 9:15 ` Liu, Yong
0 siblings, 1 reply; 2+ messages in thread
From: haifeng @ 2016-01-22 8:56 UTC (permalink / raw)
To: dts
Signed-off-by: haifeng <haifengx.tang@intel.com>
---
test_plans/unit_tests_ringpmd_test_plan.rst | 3 +--
tests/TestSuite_unit_tests_ringpmd.py | 6 +-----
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/test_plans/unit_tests_ringpmd_test_plan.rst b/test_plans/unit_tests_ringpmd_test_plan.rst
index 18f780c..31f703b 100644
--- a/test_plans/unit_tests_ringpmd_test_plan.rst
+++ b/test_plans/unit_tests_ringpmd_test_plan.rst
@@ -53,8 +53,7 @@ The steps to run the unit test manually are as follow::
# make -C ./app/test/
# ./app/test/test -n 1 -c ffff --vdev='eth_ring0,nodeaction=:0:CREATE'
- --vdev='eth_ring0,nodeaction=:0:ATTACH' --vdev='eth_ring1,nodeaction=:0:CREATE'
- --vdev='eth ring2,nodeaction=:0:CREATE' --vdev='eth_ring2,nodeaction=:0:ATTACH'
+ --vdev='eth_ring1,nodeaction=:0:CREATE' --vdev='eth ring2,nodeaction=:0:CREATE'
RTE>> ring_pmd_autotest
The final output of the test has to be "Test OK"
diff --git a/tests/TestSuite_unit_tests_ringpmd.py b/tests/TestSuite_unit_tests_ringpmd.py
index 7f88482..39d85b0 100644
--- a/tests/TestSuite_unit_tests_ringpmd.py
+++ b/tests/TestSuite_unit_tests_ringpmd.py
@@ -58,10 +58,8 @@ class TestUnitTestsRingPmd(TestCase):
Nothing to do here.
"""
self.ring_ports = [{'mode': 'tx', 'index': '0'},
- {'mode': 'rx', 'index': '0'},
{'mode': 'rxtx', 'index': '1'},
- {'mode': 'tx', 'index': '2'},
- {'mode': 'rx', 'index': '2'}]
+ {'mode': 'tx', 'index': '2'}]
def set_up(self):
"""
@@ -78,8 +76,6 @@ class TestUnitTestsRingPmd(TestCase):
for port in self.ring_ports:
if port['mode'] == 'tx':
dev_str += "--vdev='eth_ring%s,nodeaction=:0:CREATE' " % port['index']
- elif port['mode'] == 'rx':
- dev_str += "--vdev='eth_ring%s,nodeaction=:0:ATTACH' " % port['index']
else:
dev_str += "--vdev='eth_ring%s,nodeaction=:0:CREATE' " % port['index']
--
1.9.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dts] [DTS][PATCH] change ringpmd test method , remove attach option
2016-01-22 8:56 [dts] [DTS][PATCH] change ringpmd test method , remove attach option haifeng
@ 2016-01-22 9:15 ` Liu, Yong
0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2016-01-22 9:15 UTC (permalink / raw)
To: haifeng, dts
Applied with more comments.
On 01/22/2016 04:56 PM, haifeng wrote:
> Signed-off-by: haifeng <haifengx.tang@intel.com>
> ---
> test_plans/unit_tests_ringpmd_test_plan.rst | 3 +--
> tests/TestSuite_unit_tests_ringpmd.py | 6 +-----
> 2 files changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/test_plans/unit_tests_ringpmd_test_plan.rst b/test_plans/unit_tests_ringpmd_test_plan.rst
> index 18f780c..31f703b 100644
> --- a/test_plans/unit_tests_ringpmd_test_plan.rst
> +++ b/test_plans/unit_tests_ringpmd_test_plan.rst
> @@ -53,8 +53,7 @@ The steps to run the unit test manually are as follow::
>
> # make -C ./app/test/
> # ./app/test/test -n 1 -c ffff --vdev='eth_ring0,nodeaction=:0:CREATE'
> - --vdev='eth_ring0,nodeaction=:0:ATTACH' --vdev='eth_ring1,nodeaction=:0:CREATE'
> - --vdev='eth ring2,nodeaction=:0:CREATE' --vdev='eth_ring2,nodeaction=:0:ATTACH'
> + --vdev='eth_ring1,nodeaction=:0:CREATE' --vdev='eth ring2,nodeaction=:0:CREATE'
> RTE>> ring_pmd_autotest
>
> The final output of the test has to be "Test OK"
> diff --git a/tests/TestSuite_unit_tests_ringpmd.py b/tests/TestSuite_unit_tests_ringpmd.py
> index 7f88482..39d85b0 100644
> --- a/tests/TestSuite_unit_tests_ringpmd.py
> +++ b/tests/TestSuite_unit_tests_ringpmd.py
> @@ -58,10 +58,8 @@ class TestUnitTestsRingPmd(TestCase):
> Nothing to do here.
> """
> self.ring_ports = [{'mode': 'tx', 'index': '0'},
> - {'mode': 'rx', 'index': '0'},
> {'mode': 'rxtx', 'index': '1'},
> - {'mode': 'tx', 'index': '2'},
> - {'mode': 'rx', 'index': '2'}]
> + {'mode': 'tx', 'index': '2'}]
>
> def set_up(self):
> """
> @@ -78,8 +76,6 @@ class TestUnitTestsRingPmd(TestCase):
> for port in self.ring_ports:
> if port['mode'] == 'tx':
> dev_str += "--vdev='eth_ring%s,nodeaction=:0:CREATE' " % port['index']
> - elif port['mode'] == 'rx':
> - dev_str += "--vdev='eth_ring%s,nodeaction=:0:ATTACH' " % port['index']
> else:
> dev_str += "--vdev='eth_ring%s,nodeaction=:0:CREATE' " % port['index']
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-22 9:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-22 8:56 [dts] [DTS][PATCH] change ringpmd test method , remove attach option haifeng
2016-01-22 9:15 ` Liu, Yong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).