test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH]tests vf_vlan: update vm cases
@ 2016-02-26  2:29 xu,huilong
  2016-03-14  2:04 ` Liu, Yong
  0 siblings, 1 reply; 2+ messages in thread
From: xu,huilong @ 2016-02-26  2:29 UTC (permalink / raw)
  To: yong.liu, dts, yulong.pei, qian.q.xu

From: Lijuan Tu <lijuanx.a.tu@intel.com>

1. stop forwarding and then can start again
2. 'rx_vlan add 1 0' & 'tx_vlan set 0 %d' before testpmd send vlan packets
3. a little time wait after 'rx_vlan add %d 0'
4. fix vlan set strip on/off in for-cycle

Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com>
---
 tests/TestSuite_vf_vlan.py | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/tests/TestSuite_vf_vlan.py b/tests/TestSuite_vf_vlan.py
index 6bde6ca..29890aa 100644
--- a/tests/TestSuite_vf_vlan.py
+++ b/tests/TestSuite_vf_vlan.py
@@ -243,6 +243,7 @@ class TestVfVlan(TestCase):
         inst = sniff_packets(self.tester_intf0, timeout=5)
         self.vm0_testpmd.execute_cmd('set burst 1')
         self.vm0_testpmd.execute_cmd('start tx_first')
+        self.vm0_testpmd.execute_cmd('stop')
 
         # strip sniffered vlans
         pkts = load_sniff_packets(inst)
@@ -265,6 +266,7 @@ class TestVfVlan(TestCase):
         self.vm0_testpmd.execute_cmd('set verbose 1')
 
         for tx_vlan in tx_vlans:
+            self.vm0_testpmd.execute_cmd('rx_vlan add %d 0' % tx_vlan)
             self.vm0_testpmd.execute_cmd('tx_vlan set 0 %d' % tx_vlan)
             self.tx_and_check(tx_vlan=tx_vlan)
 
@@ -280,7 +282,7 @@ class TestVfVlan(TestCase):
         self.vm0_testpmd.start_testpmd(VM_CORES_MASK)
         self.vm0_testpmd.execute_cmd('set fwd rxonly')
         self.vm0_testpmd.execute_cmd('set verbose 1')
-        self.vm0_testpmd.execute_cmd('vlan set strip off 0')
+        self.vm0_testpmd.execute_cmd('vlan set strip on 0')
         self.vm0_testpmd.execute_cmd('start')
 
         # send packet without vlan
@@ -295,6 +297,7 @@ class TestVfVlan(TestCase):
 
         for rx_vlan in rx_vlans:
             self.vm0_testpmd.execute_cmd('rx_vlan add %d 0' % rx_vlan)
+            time.sleep(1)
             # send packet with same vlan
             out = self.send_and_getout(vlan=rx_vlan, pkt_type="VLAN_UDP")
             vlan_hex = hex(rx_vlan)
@@ -312,7 +315,7 @@ class TestVfVlan(TestCase):
                 "received 1 packets" not in out, "Received filtered vlan packet!!!")
 
         for rx_vlan in rx_vlans:
-            self.vm0_testpmd.execute_cmd('rx_vlan rm 0 %d' % random_vlan)
+            self.vm0_testpmd.execute_cmd('rx_vlan rm 0 %d' % rx_vlan)
 
         # send packet with vlan 0
         out = self.send_and_getout(vlan=0, pkt_type="VLAN_UDP")
@@ -341,11 +344,12 @@ class TestVfVlan(TestCase):
         self.vm0_testpmd.start_testpmd(VM_CORES_MASK)
         self.vm0_testpmd.execute_cmd('set fwd rxonly')
         self.vm0_testpmd.execute_cmd('set verbose 1')
-        self.vm0_testpmd.execute_cmd('vlan set strip on 0')
         self.vm0_testpmd.execute_cmd('start')
 
         for rx_vlan in rx_vlans:
+            self.vm0_testpmd.execute_cmd('vlan set strip on 0')
             self.vm0_testpmd.execute_cmd('rx_vlan add %d 0' % rx_vlan)
+            time.sleep(1)
             out = self.send_and_getout(vlan=rx_vlan, pkt_type="VLAN_UDP")
             # enable strip, vlan will be in mbuf
             vlan_hex = hex(rx_vlan)
-- 
2.5.0

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-14  2:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-26  2:29 [dts] [PATCH]tests vf_vlan: update vm cases xu,huilong
2016-03-14  2:04 ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).