[dts] [PATCH V1] update ixgbe nic tpid command

[dts] [PATCH V1] update ixgbe nic tpid command

[xu,huilong]

Signed-off-by: xu,huilong <huilongx.xu@intel.com>
---
 tests/TestSuite_dual_vlan.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_dual_vlan.py b/tests/TestSuite_dual_vlan.py
index 84552f5..a4ae23e 100644
--- a/tests/TestSuite_dual_vlan.py
+++ b/tests/TestSuite_dual_vlan.py
@@ -364,14 +364,15 @@ class TestDualVlan(TestCase):
         self.verify(self.nic not in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single", "hartwell"], "%s NIC not support tcpid " % self.nic)
 
         self.mode_config(filter="on", strip="on", qinq="on")
-        self.dut.send_expect("vlan set tpid 1234 %s" % dutRxPortId, "testpmd> ")
+        # nic only support inner model, except fortville nic
+        self.dut.send_expect("vlan set inner tpid 1234 %s" % dutRxPortId, "testpmd> ")
         self.vlan_send_packet(outvlan, invlan)
 
         out = self.get_tcpdump_package()
         self.verify("vlan %s" % outvlan in out, "vlan tpid disable error: " + out)
         self.verify("vlan %s" % invlan in out, "vlan tpid disable error: " + out)
 
-        self.dut.send_expect("vlan set tpid 0x8100 %s" % dutRxPortId, "testpmd> ")
+        self.dut.send_expect("vlan set inner tpid 0x8100 %s" % dutRxPortId, "testpmd> ")
         self.vlan_send_packet(outvlan, invlan)
 
         out = self.get_tcpdump_package()
-- 
1.9.3

Re: [dts] [PATCH V1] update ixgbe nic tpid command

[Liu, Yong]

Hi Huilong,
Look like this case only cover inner tpid, is there any case for outer tpid?
Please remember to update test plan simultaneously.

Thanks.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,huilong
> Sent: Friday, March 18, 2016 9:50 AM
> To: dts@dpdk.org
> Cc: Xu, HuilongX
> Subject: [dts] [PATCH V1] update ixgbe nic tpid command
> 
> Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> ---
>  tests/TestSuite_dual_vlan.py | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_dual_vlan.py b/tests/TestSuite_dual_vlan.py
> index 84552f5..a4ae23e 100644
> --- a/tests/TestSuite_dual_vlan.py
> +++ b/tests/TestSuite_dual_vlan.py
> @@ -364,14 +364,15 @@ class TestDualVlan(TestCase):
>          self.verify(self.nic not in ["fortville_eagle",
> "fortville_spirit", "fortville_spirit_single", "hartwell"], "%s NIC not
> support tcpid " % self.nic)
> 
>          self.mode_config(filter="on", strip="on", qinq="on")
> -        self.dut.send_expect("vlan set tpid 1234 %s" % dutRxPortId,
> "testpmd> ")
> +        # nic only support inner model, except fortville nic
> +        self.dut.send_expect("vlan set inner tpid 1234 %s" % dutRxPortId,
> "testpmd> ")
>          self.vlan_send_packet(outvlan, invlan)
> 
>          out = self.get_tcpdump_package()
>          self.verify("vlan %s" % outvlan in out, "vlan tpid disable error:
> " + out)
>          self.verify("vlan %s" % invlan in out, "vlan tpid disable error:
> " + out)
> 
> -        self.dut.send_expect("vlan set tpid 0x8100 %s" % dutRxPortId,
> "testpmd> ")
> +        self.dut.send_expect("vlan set inner tpid 0x8100 %s" %
> dutRxPortId, "testpmd> ")
>          self.vlan_send_packet(outvlan, invlan)
> 
>          out = self.get_tcpdump_package()
> --
> 1.9.3

Re: [dts] [PATCH V1] update ixgbe nic tpid command

[Xu, HuilongX]

Hi yong,
I will update test plan next version ASAP.
Thanks  a lot 

> -----Original Message-----
> From: Liu, Yong
> Sent: Friday, March 18, 2016 3:11 PM
> To: Xu, HuilongX; dts@dpdk.org
> Cc: Xu, HuilongX
> Subject: RE: [dts] [PATCH V1] update ixgbe nic tpid command
> 
> Hi Huilong,
> Look like this case only cover inner tpid, is there any case for outer
> tpid?
> Please remember to update test plan simultaneously.
> 
> Thanks.
> 
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,huilong
> > Sent: Friday, March 18, 2016 9:50 AM
> > To: dts@dpdk.org
> > Cc: Xu, HuilongX
> > Subject: [dts] [PATCH V1] update ixgbe nic tpid command
> >
> > Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> > ---
> >  tests/TestSuite_dual_vlan.py | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/TestSuite_dual_vlan.py
> b/tests/TestSuite_dual_vlan.py
> > index 84552f5..a4ae23e 100644
> > --- a/tests/TestSuite_dual_vlan.py
> > +++ b/tests/TestSuite_dual_vlan.py
> > @@ -364,14 +364,15 @@ class TestDualVlan(TestCase):
> >          self.verify(self.nic not in ["fortville_eagle",
> > "fortville_spirit", "fortville_spirit_single", "hartwell"], "%s NIC
> not
> > support tcpid " % self.nic)
> >
> >          self.mode_config(filter="on", strip="on", qinq="on")
> > -        self.dut.send_expect("vlan set tpid 1234 %s" % dutRxPortId,
> > "testpmd> ")
> > +        # nic only support inner model, except fortville nic
> > +        self.dut.send_expect("vlan set inner tpid 1234 %s" %
> dutRxPortId,
> > "testpmd> ")
> >          self.vlan_send_packet(outvlan, invlan)
> >
> >          out = self.get_tcpdump_package()
> >          self.verify("vlan %s" % outvlan in out, "vlan tpid disable
> error:
> > " + out)
> >          self.verify("vlan %s" % invlan in out, "vlan tpid disable
> error:
> > " + out)
> >
> > -        self.dut.send_expect("vlan set tpid 0x8100 %s" % dutRxPortId,
> > "testpmd> ")
> > +        self.dut.send_expect("vlan set inner tpid 0x8100 %s" %
> > dutRxPortId, "testpmd> ")
> >          self.vlan_send_packet(outvlan, invlan)
> >
> >          out = self.get_tcpdump_package()
> > --
> > 1.9.3