test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1 1/2] add netmap test plan
@ 2016-04-29  7:53 xu,gang
  2016-04-29  7:53 ` [dts] [PATCH V1 2/2] add netmap test code xu,gang
  2016-04-29 18:08 ` [dts] [PATCH V1 1/2] add netmap test plan Liu, Yong
  0 siblings, 2 replies; 4+ messages in thread
From: xu,gang @ 2016-04-29  7:53 UTC (permalink / raw)
  To: dts; +Cc: xu,gang

Signed-off-by: xu,gang <gangx.xu@intel.com>
---
 test_plans/netmap_compat_test_plan.rst | 125 +++++++++++++++++++++++++++++++++
 1 file changed, 125 insertions(+)
 create mode 100644 test_plans/netmap_compat_test_plan.rst

diff --git a/test_plans/netmap_compat_test_plan.rst b/test_plans/netmap_compat_test_plan.rst
new file mode 100644
index 0000000..96f2a2b
--- /dev/null
+++ b/test_plans/netmap_compat_test_plan.rst
@@ -0,0 +1,125 @@
+..  BSD LICENSE
+    Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
+    All rights reserved.
+
+    Redistribution and use in source and binary forms, with or without
+    modification, are permitted provided that the following conditions
+    are met:
+
+    * Redistributions of source code must retain the above copyright
+    notice, this list of conditions and the following disclaimer.
+    * Redistributions in binary form must reproduce the above copyright
+    notice, this list of conditions and the following disclaimer in
+    the documentation and/or other materials provided with the
+    distribution.
+    * Neither the name of Intel Corporation nor the names of its
+    contributors may be used to endorse or promote products derived
+    from this software without specific prior written permission.
+
+    THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+    "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+    LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+    A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+    OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+    SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+    LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+    DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+    THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+    (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+    OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+
+Netmap Compatibility Sample Application
+=======================================
+
+Introduction
+------------
+
+The Netmap compatibility library provides a minimal set of APIs to give programs written against the Netmap APIs
+the ability to be run, with minimal changes to their source code, using the DPDK to perform the actual packet I/O.
+
+Since Netmap applications use regular system calls, like ``open()``, ``ioctl()`` and
+``mmap()`` to communicate with the Netmap kernel module performing the packet I/O,
+the ``compat_netmap`` library provides a set of similar APIs to use in place of those system calls,
+effectively turning a Netmap application into a DPDK application.
+
+The provided library is currently minimal and doesn't support all the features that Netmap supports,
+but is enough to run simple applications, such as the bridge example detailed below.
+
+Knowledge of Netmap is required to understand the rest of this section.
+Please refer to the Netmap distribution for details about Netmap.
+
+
+Compiling the "bridge" Sample Application
+-----------------------------------------
+
+#.  Go to the example directory:
+
+    .. code-block:: console
+
+        export RTE_SDK=/path/to/rte_sdk
+        cd ${RTE_SDK}/examples/netmap_compat
+
+#.  Set the target (a default target is used if not specified). For example:
+
+    .. code-block:: console
+
+        export RTE_TARGET=x86_64-native-linuxapp-gcc
+
+    See the *DPDK Getting Started Guide for Linux* for possible ``RTE_TARGET`` values.
+
+#.  Build the application:
+
+    .. code-block:: console
+
+        make
+
+Running the "bridge" Sample Application
+---------------------------------------
+
+The application requires a single command line option:
+
+.. code-block:: console
+
+    ./build/bridge [EAL options] -- -i INTERFACE_A [-i INTERFACE_B]
+
+where,
+
+*   ``-i INTERFACE``: Interface (DPDK port number) to use.
+
+    If a single ``-i`` parameter is given, the interface will send back all the traffic it receives.
+    If two ``-i`` parameters are given, the two interfaces form a bridge,
+    where traffic received on one interface is replicated and sent to the other interface.
+
+For example, to run the application in a linuxapp environment using port 0 and 2:
+
+.. code-block:: console
+
+    ./build/bridge [EAL options] -- -i 0 -i 2
+
+Refer to the *DPDK Getting Started Guide for Linux* for general information on running applications and
+the Environment Abstraction Layer (EAL) options.
+
+Test Case1: netmap compat with one port 
+=======================================
+Run bridge with one port::
+        ./examples/netmap_compat/build/bridge -c 0x1e -n 4 -- -i 0
+waked up :
+        Port 0 now in Netmap mode
+        Bridge up and running!
+
+Send one packet on Port0,check this port receive packet. 
+It receive one packet that it send.
+
+Test Case2: netmap compat with two port
+=======================================
+Run bridge with one port::
+        ./examples/netmap_compat/build/bridge -c 0x1e -n 4 -- -i 0 -i 1
+waked up :
+        Port 0 now in Netmap mode
+        Port 1 now in Netmap mode
+        Bridge up and running!
+
+Send one packet on Port0,check the port1 receive packet.
+It receive one packet that the port0 send.
+
-- 
1.9.3

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dts] [PATCH V1 2/2] add netmap test code
  2016-04-29  7:53 [dts] [PATCH V1 1/2] add netmap test plan xu,gang
@ 2016-04-29  7:53 ` xu,gang
  2016-04-29 18:10   ` Liu, Yong
  2016-04-29 18:08 ` [dts] [PATCH V1 1/2] add netmap test plan Liu, Yong
  1 sibling, 1 reply; 4+ messages in thread
From: xu,gang @ 2016-04-29  7:53 UTC (permalink / raw)
  To: dts; +Cc: xu,gang

Signed-off-by: xu,gang <gangx.xu@intel.com>
---
 tests/TestSuite_netmap_compat.py | 143 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 143 insertions(+)
 create mode 100644 tests/TestSuite_netmap_compat.py

diff --git a/tests/TestSuite_netmap_compat.py b/tests/TestSuite_netmap_compat.py
new file mode 100644
index 0000000..facb169
--- /dev/null
+++ b/tests/TestSuite_netmap_compat.py
@@ -0,0 +1,143 @@
+#BSD LICENSE
+#
+# Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
+# All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+#
+#   * Redistributions of source code must retain the above copyright
+#     notice, this list of conditions and the following disclaimer.
+#   * Redistributions in binary form must reproduce the above copyright
+#     notice, this list of conditions and the following disclaimer in
+#     the documentation and/or other materials provided with the
+#     distribution.
+#   * Neither the name of Intel Corporation nor the names of its
+#     contributors may be used to endorse or promote products derived
+#     from this software without specific prior written permission.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+
+"""
+DPDK Test suite.
+Test Netmap_compat.
+"""
+
+import dts
+import string
+import time
+import re
+from test_case import TestCase
+from plotting import Plotting 
+from settings import HEADER_SIZE   
+from etgen import IxiaPacketGenerator
+from packet import Packet, sniff_packets, load_sniff_packets
+
+class TestNetmapCompat(TestCase):
+
+    def set_up_all(self):
+        """
+        Run at the start of each test suite.
+        """
+        self.dut_ports = self.dut.get_ports(self.nic)
+        self.verify(len(self.dut_ports) >= 2, "Insufficient ports")
+        cores = self.dut.get_core_list("1S/4C/1T")
+        self.coremask = dts.create_mask(cores)
+        #self.portmask = dts.create_mask(self.dut_ports[:2])
+
+        self.path = "./examples/netmap_compat/build/bridge" 
+
+        # build sample app  
+        out = self.dut.build_dpdk_apps("./examples/netmap_compat")
+        self.verify("Error" not in out, "compilation error 1") 
+        self.verify("No such file" not in out, "compilation error 2")
+         
+    def set_up(self):
+        """
+        Run before each test case.
+        """
+        pass
+
+    def test_netmap_compat_oneport(self):
+        """
+        Verify netmap compatibility with one port 
+        """ 
+        cmd = self.path + " -c %s -n %d -- -i %s" % (self.coremask,self.dut.get_memory_channels(),self.dut_ports[0])
+      
+        #start netmap_compat with one port
+        #import pdb
+        #pdb.set_trace()
+        self.dut.send_expect(cmd,"Port %s now in Netmap mode" % self.dut_ports[0],60)
+
+        self.rxItf = self.tester.get_interface(self.tester.get_local_port(self.dut_ports[0]))
+
+        self.inst = sniff_packets(self.rxItf)
+
+        self.scapy_send_package()
+
+        out = self.get_tcpdump_package()
+        mac = self.dut.get_mac_address(self.dut_ports[0])
+        self.verify(mac in out, "Wrong: can't get <%s> package" % mac)
+         
+    def test_netmap_compat_twoport(self):
+        """
+        Verify netmap compatibility with two port
+        """
+        cmd = self.path + " -c %s -n %d -- -i %s -i %s" % (self.coremask,self.dut.get_memory_channels(),self.dut_ports[0],self.dut_ports[1])
+
+        #start netmap_compat with two port
+        self.dut.send_expect(cmd,"Port %s now in Netmap mode" % self.dut_ports[0], 60)
+       
+        self.rxItf = self.tester.get_interface(self.tester.get_local_port(self.dut_ports[1]))
+        self.inst = sniff_packets(self.rxItf)
+
+        self.scapy_send_package()
+
+        out = self.get_tcpdump_package()
+        mac = self.dut.get_mac_address(self.dut_ports[0])
+        self.verify(mac in out, "Wrong: can't get <%s> package" % mac)
+    def scapy_send_package(self):
+        """
+        Send a packet to port  
+        """
+        txport = self.tester.get_local_port(self.dut_ports[0])
+        mac = self.dut.get_mac_address(self.dut_ports[0])
+        txItf = self.tester.get_interface(txport)
+        self.tester.scapy_append('sendp([Ether(dst="%s")/IP()/UDP()/Raw(\'X\'*18)], iface="%s")' % (mac, txItf))
+        self.tester.scapy_execute()
+
+
+    def get_tcpdump_package(self):  
+        pkts = load_sniff_packets(self.inst)
+        dsts = []  
+        for packet in pkts:  
+            dst = packet.strip_element_layer2("dst")  
+            dsts.append(dst)
+        return dsts  
+         
+    def tear_down(self):
+        """
+        Run after each test case.
+        """
+        self.dut.kill_all()
+        time.sleep(2)
+        pass
+
+    def tear_down_all(self):
+        """
+        Run after each test suite.
+        """
+        pass
+
-- 
1.9.3

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1 1/2] add netmap test plan
  2016-04-29  7:53 [dts] [PATCH V1 1/2] add netmap test plan xu,gang
  2016-04-29  7:53 ` [dts] [PATCH V1 2/2] add netmap test code xu,gang
@ 2016-04-29 18:08 ` Liu, Yong
  1 sibling, 0 replies; 4+ messages in thread
From: Liu, Yong @ 2016-04-29 18:08 UTC (permalink / raw)
  To: Xu, GangX, dts; +Cc: Xu, GangX

Gang, few comments below.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,gang
> Sent: Friday, April 29, 2016 12:54 AM
> To: dts@dpdk.org
> Cc: Xu, GangX
> Subject: [dts] [PATCH V1 1/2] add netmap test plan
> 
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
>  test_plans/netmap_compat_test_plan.rst | 125
> +++++++++++++++++++++++++++++++++
>  1 file changed, 125 insertions(+)
>  create mode 100644 test_plans/netmap_compat_test_plan.rst
> 
> diff --git a/test_plans/netmap_compat_test_plan.rst
> b/test_plans/netmap_compat_test_plan.rst
> new file mode 100644
> index 0000000..96f2a2b
> --- /dev/null
> +++ b/test_plans/netmap_compat_test_plan.rst
> @@ -0,0 +1,125 @@
> +..  BSD LICENSE
> +    Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
> +    All rights reserved.

Please update the copyright time period, it should be 2010-2016.

> +
> +    Redistribution and use in source and binary forms, with or without
> +    modification, are permitted provided that the following conditions
> +    are met:
> +
> +    * Redistributions of source code must retain the above copyright
> +    notice, this list of conditions and the following disclaimer.
> +    * Redistributions in binary form must reproduce the above copyright
> +    notice, this list of conditions and the following disclaimer in
> +    the documentation and/or other materials provided with the
> +    distribution.
> +    * Neither the name of Intel Corporation nor the names of its
> +    contributors may be used to endorse or promote products derived
> +    from this software without specific prior written permission.
> +
> +    THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> +    "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> +    LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
> +    A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
> +    OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
> +    SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
> +    LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
> +    DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
> +    THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> +    (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> +    OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> +
> +
> +Netmap Compatibility Sample Application
> +=======================================
> +
> +Introduction
> +------------
> +
> +The Netmap compatibility library provides a minimal set of APIs to give
> programs written against the Netmap APIs
> +the ability to be run, with minimal changes to their source code, using
> the DPDK to perform the actual packet I/O.
> +
> +Since Netmap applications use regular system calls, like ``open()``,
> ``ioctl()`` and
> +``mmap()`` to communicate with the Netmap kernel module performing the
> packet I/O,
> +the ``compat_netmap`` library provides a set of similar APIs to use in
> place of those system calls,
> +effectively turning a Netmap application into a DPDK application.
> +
> +The provided library is currently minimal and doesn't support all the
> features that Netmap supports,
> +but is enough to run simple applications, such as the bridge example
> detailed below.
> +
> +Knowledge of Netmap is required to understand the rest of this section.
> +Please refer to the Netmap distribution for details about Netmap.
> +
> +
> +Compiling the "bridge" Sample Application
> +-----------------------------------------
> +
> +#.  Go to the example directory:
> +
> +    .. code-block:: console
> +
> +        export RTE_SDK=/path/to/rte_sdk
> +        cd ${RTE_SDK}/examples/netmap_compat
> +
> +#.  Set the target (a default target is used if not specified). For
> example:
> +
> +    .. code-block:: console
> +
> +        export RTE_TARGET=x86_64-native-linuxapp-gcc
> +
> +    See the *DPDK Getting Started Guide for Linux* for possible
> ``RTE_TARGET`` values.
> +
> +#.  Build the application:
> +
> +    .. code-block:: console
> +
> +        make
> +
Just plain text is enough, please remove rst format indicator. 

> +Running the "bridge" Sample Application
> +---------------------------------------
> +
> +The application requires a single command line option:
> +
> +.. code-block:: console
> +
> +    ./build/bridge [EAL options] -- -i INTERFACE_A [-i INTERFACE_B]
> +
> +where,
> +
> +*   ``-i INTERFACE``: Interface (DPDK port number) to use.
> +
> +    If a single ``-i`` parameter is given, the interface will send back
> all the traffic it receives.
> +    If two ``-i`` parameters are given, the two interfaces form a bridge,
> +    where traffic received on one interface is replicated and sent to the
> other interface.
> +
> +For example, to run the application in a linuxapp environment using port
> 0 and 2:
> +
> +.. code-block:: console
> +
> +    ./build/bridge [EAL options] -- -i 0 -i 2
> +
> +Refer to the *DPDK Getting Started Guide for Linux* for general
> information on running applications and
> +the Environment Abstraction Layer (EAL) options.
> +
> +Test Case1: netmap compat with one port
> +=======================================
> +Run bridge with one port::
> +        ./examples/netmap_compat/build/bridge -c 0x1e -n 4 -- -i 0
> +waked up :
> +        Port 0 now in Netmap mode
> +        Bridge up and running!
> +
> +Send one packet on Port0,check this port receive packet.
> +It receive one packet that it send.
> +
> +Test Case2: netmap compat with two port
> +=======================================
> +Run bridge with one port::
> +        ./examples/netmap_compat/build/bridge -c 0x1e -n 4 -- -i 0 -i 1
> +waked up :
> +        Port 0 now in Netmap mode
> +        Port 1 now in Netmap mode
> +        Bridge up and running!
> +
> +Send one packet on Port0,check the port1 receive packet.
> +It receive one packet that the port0 send.
> +
> --
> 1.9.3

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1 2/2] add netmap test code
  2016-04-29  7:53 ` [dts] [PATCH V1 2/2] add netmap test code xu,gang
@ 2016-04-29 18:10   ` Liu, Yong
  0 siblings, 0 replies; 4+ messages in thread
From: Liu, Yong @ 2016-04-29 18:10 UTC (permalink / raw)
  To: Xu, GangX, dts; +Cc: Xu, GangX

Thanks gang, please remove debug code in this patch.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,gang
> Sent: Friday, April 29, 2016 12:54 AM
> To: dts@dpdk.org
> Cc: Xu, GangX
> Subject: [dts] [PATCH V1 2/2] add netmap test code
> 
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
>  tests/TestSuite_netmap_compat.py | 143
> +++++++++++++++++++++++++++++++++++++++
>  1 file changed, 143 insertions(+)
>  create mode 100644 tests/TestSuite_netmap_compat.py
> 
> diff --git a/tests/TestSuite_netmap_compat.py
> b/tests/TestSuite_netmap_compat.py
> new file mode 100644
> index 0000000..facb169
> --- /dev/null
> +++ b/tests/TestSuite_netmap_compat.py
> @@ -0,0 +1,143 @@
> +#BSD LICENSE
> +#
> +# Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
> +# All rights reserved.
> +#
> +# Redistribution and use in source and binary forms, with or without
> +# modification, are permitted provided that the following conditions
> +# are met:
> +#
> +#   * Redistributions of source code must retain the above copyright
> +#     notice, this list of conditions and the following disclaimer.
> +#   * Redistributions in binary form must reproduce the above copyright
> +#     notice, this list of conditions and the following disclaimer in
> +#     the documentation and/or other materials provided with the
> +#     distribution.
> +#   * Neither the name of Intel Corporation nor the names of its
> +#     contributors may be used to endorse or promote products derived
> +#     from this software without specific prior written permission.
> +#
> +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
> +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
> +# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
> +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
> +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
> +# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
> +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> +
> +
> +"""
> +DPDK Test suite.
> +Test Netmap_compat.
> +"""
> +
> +import dts
> +import string
> +import time
> +import re
> +from test_case import TestCase
> +from plotting import Plotting
> +from settings import HEADER_SIZE
> +from etgen import IxiaPacketGenerator
> +from packet import Packet, sniff_packets, load_sniff_packets
> +
> +class TestNetmapCompat(TestCase):
> +
> +    def set_up_all(self):
> +        """
> +        Run at the start of each test suite.
> +        """
> +        self.dut_ports = self.dut.get_ports(self.nic)
> +        self.verify(len(self.dut_ports) >= 2, "Insufficient ports")
> +        cores = self.dut.get_core_list("1S/4C/1T")
> +        self.coremask = dts.create_mask(cores)
> +        #self.portmask = dts.create_mask(self.dut_ports[:2])
> +
> +        self.path = "./examples/netmap_compat/build/bridge"
> +
> +        # build sample app
> +        out = self.dut.build_dpdk_apps("./examples/netmap_compat")
> +        self.verify("Error" not in out, "compilation error 1")
> +        self.verify("No such file" not in out, "compilation error 2")
> +
> +    def set_up(self):
> +        """
> +        Run before each test case.
> +        """
> +        pass
> +
> +    def test_netmap_compat_oneport(self):
> +        """
> +        Verify netmap compatibility with one port
> +        """
> +        cmd = self.path + " -c %s -n %d -- -i %s" %
> (self.coremask,self.dut.get_memory_channels(),self.dut_ports[0])
> +
> +        #start netmap_compat with one port
> +        #import pdb
> +        #pdb.set_trace()

Please remove debug code from submitted patch.

> +        self.dut.send_expect(cmd,"Port %s now in Netmap mode" %
> self.dut_ports[0],60)
> +
> +        self.rxItf =
> self.tester.get_interface(self.tester.get_local_port(self.dut_ports[0]))
> +
> +        self.inst = sniff_packets(self.rxItf)
> +
> +        self.scapy_send_package()
> +
> +        out = self.get_tcpdump_package()
> +        mac = self.dut.get_mac_address(self.dut_ports[0])
> +        self.verify(mac in out, "Wrong: can't get <%s> package" % mac)
> +
> +    def test_netmap_compat_twoport(self):
> +        """
> +        Verify netmap compatibility with two port
> +        """
> +        cmd = self.path + " -c %s -n %d -- -i %s -i %s" %
> (self.coremask,self.dut.get_memory_channels(),self.dut_ports[0],self.dut_p
> orts[1])
> +
> +        #start netmap_compat with two port
> +        self.dut.send_expect(cmd,"Port %s now in Netmap mode" %
> self.dut_ports[0], 60)
> +
> +        self.rxItf =
> self.tester.get_interface(self.tester.get_local_port(self.dut_ports[1]))
> +        self.inst = sniff_packets(self.rxItf)
> +
> +        self.scapy_send_package()
> +
> +        out = self.get_tcpdump_package()
> +        mac = self.dut.get_mac_address(self.dut_ports[0])
> +        self.verify(mac in out, "Wrong: can't get <%s> package" % mac)
> +    def scapy_send_package(self):
> +        """
> +        Send a packet to port
> +        """
> +        txport = self.tester.get_local_port(self.dut_ports[0])
> +        mac = self.dut.get_mac_address(self.dut_ports[0])
> +        txItf = self.tester.get_interface(txport)
> +
> self.tester.scapy_append('sendp([Ether(dst="%s")/IP()/UDP()/Raw(\'X\'*18)],
> iface="%s")' % (mac, txItf))
> +        self.tester.scapy_execute()
> +
> +
> +    def get_tcpdump_package(self):
> +        pkts = load_sniff_packets(self.inst)
> +        dsts = []
> +        for packet in pkts:
> +            dst = packet.strip_element_layer2("dst")
> +            dsts.append(dst)
> +        return dsts
> +
> +    def tear_down(self):
> +        """
> +        Run after each test case.
> +        """
> +        self.dut.kill_all()
> +        time.sleep(2)
> +        pass
> +
> +    def tear_down_all(self):
> +        """
> +        Run after each test suite.
> +        """
> +        pass
> +
> --
> 1.9.3

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-04-29 18:10 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-29  7:53 [dts] [PATCH V1 1/2] add netmap test plan xu,gang
2016-04-29  7:53 ` [dts] [PATCH V1 2/2] add netmap test code xu,gang
2016-04-29 18:10   ` Liu, Yong
2016-04-29 18:08 ` [dts] [PATCH V1 1/2] add netmap test plan Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).