test suite reviews and discussions
 help / color / mirror / Atom feed
From: Ding Heng <hengx.ding@intel.com>
To: dts@dpdk.org
Cc: Ding Heng <hengx.ding@intel.com>
Subject: [dts]  testcase: fix some bugs for performance case
Date: Mon, 13 Jun 2016 17:01:34 +0800	[thread overview]
Message-ID: <1465808494-3196-1-git-send-email-hengx.ding@intel.com> (raw)

checksum_offload: set verbose will affect testpmd performance, delete it.
link_flow_control: self.pause_frame_loss_test() return value is tuple now, need
to make some change to adapt this change.

Signed-off-by: Ding Heng <hengx.ding@intel.com>

diff --git a/tests/TestSuite_checksum_offload.py b/tests/TestSuite_checksum_offload.py
index 7dc8ddc..26bbe25 100644
--- a/tests/TestSuite_checksum_offload.py
+++ b/tests/TestSuite_checksum_offload.py
@@ -305,7 +305,6 @@ class TestChecksumOffload(TestCase):
             self.pmdout.start_testpmd(
                 lcore, "--portmask=%s" % self.portMask, socket=self.ports_socket)
 
-            self.dut.send_expect("set verbose 1", "testpmd> ")
             self.dut.send_expect("set fwd csum", "testpmd> ")
             if mode == "hw":
                 self.checksum_enablehw(self.dut_ports[0])
diff --git a/tests/TestSuite_link_flowctrl.py b/tests/TestSuite_link_flowctrl.py
index 11c1795..533e427 100644
--- a/tests/TestSuite_link_flowctrl.py
+++ b/tests/TestSuite_link_flowctrl.py
@@ -335,7 +335,7 @@ class TestLinkFlowctrl(TestCase):
         Disable link flow control and PAUSE frame forwarding
         """
 
-        result = self.pause_frame_loss_test(rx_flow_control='on',
+        result,_,_ = self.pause_frame_loss_test(rx_flow_control='on',
                                             tx_flow_control='on',
                                             pause_frame_fwd='on')
 
@@ -349,7 +349,7 @@ class TestLinkFlowctrl(TestCase):
         Disable link flow control and enable PAUSE frame forwarding
         """
 
-        result = self.pause_frame_loss_test(rx_flow_control='on',
+        result,_,_ = self.pause_frame_loss_test(rx_flow_control='on',
                                             tx_flow_control='on',
                                             pause_frame_fwd='off')
 
@@ -363,7 +363,7 @@ class TestLinkFlowctrl(TestCase):
         Enable only rx link flow control
         """
 
-        result = self.pause_frame_loss_test(rx_flow_control='on',
+        result,_,_ = self.pause_frame_loss_test(rx_flow_control='on',
                                             tx_flow_control='on',
                                             pause_frame_fwd='off')
 
@@ -377,7 +377,7 @@ class TestLinkFlowctrl(TestCase):
         Enable link flow control and disable PAUSE frame forwarding
         """
 
-        result = self.pause_frame_loss_test(rx_flow_control='off',
+        result,_,_ = self.pause_frame_loss_test(rx_flow_control='off',
                                             tx_flow_control='off',
                                             pause_frame_fwd='on')
 
@@ -391,7 +391,7 @@ class TestLinkFlowctrl(TestCase):
         Disable link flow control and PAUSE frame forwarding
         """
 
-        result = self.pause_frame_loss_test(rx_flow_control='off',
+        result,_,_ = self.pause_frame_loss_test(rx_flow_control='off',
                                             tx_flow_control='off',
                                             pause_frame_fwd='off')
 
@@ -405,7 +405,7 @@ class TestLinkFlowctrl(TestCase):
         Disable link flow control and PAUSE frame forwarding
         """
 
-        result = self.pause_frame_loss_test(rx_flow_control='off',
+        result,_,_ = self.pause_frame_loss_test(rx_flow_control='off',
                                             tx_flow_control='on',
                                             pause_frame_fwd='off')
 
-- 
1.9.3

                 reply	other threads:[~2016-06-13  9:01 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1465808494-3196-1-git-send-email-hengx.ding@intel.com \
    --to=hengx.ding@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).