test suite reviews and discussions
 help / color / mirror / Atom feed
From: Marvin Liu <yong.liu@intel.com>
To: dts@dpdk.org
Cc: Marvin Liu <yong.liu@intel.com>
Subject: [dts] [PATCH] framework dts: fix failure when no commands input from user
Date: Thu, 23 Jun 2016 14:14:35 +0800	[thread overview]
Message-ID: <1466662475-25666-1-git-send-email-yong.liu@intel.com> (raw)

When parameter commands is not inputed by user, dts should skip handling
the commands parameter.

Signed-off-by: Marvin Liu <yong.liu@intel.com>

diff --git a/framework/dts.py b/framework/dts.py
index 06e2952..611c0dc 100644
--- a/framework/dts.py
+++ b/framework/dts.py
@@ -189,6 +189,9 @@ def dts_parse_commands(commands):
     """
     Parse command information from dts arguments
     """
+    if commands is None:
+        return
+
     args_format = {"shell": 0,
                    "crb": 1,
                    "stage": 2,
@@ -196,6 +199,7 @@ def dts_parse_commands(commands):
                    "max_num": 4}
     global dts_commands
     cmd_fmt = r"\[(.*)\]"
+
     for command in commands:
         args = command.split(':')
         if len(args) != args_format['max_num']:
-- 
1.9.3

                 reply	other threads:[~2016-06-23  6:14 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466662475-25666-1-git-send-email-yong.liu@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).