test suite reviews and discussions
 help / color / mirror / Atom feed
From: Rami Rosen <rami.rosen@intel.com>
To: yong.liu@intel.com
Cc: dts@dpdk.org, Rami Rosen <rami.rosen@intel.com>
Subject: [dts] [PATCH] framework: avoid error on import pxssh.
Date: Sun, 26 Jun 2016 20:58:22 +0300	[thread overview]
Message-ID: <1466963902-23114-1-git-send-email-rami.rosen@intel.com> (raw)

This patch adds "from pexpect" to the "import pxsh" call. In newer versions
(higher than 4) of python-pexpect, not having "from expect" will cause the 
following error: "ImportError: No module named pxssh".
See also: https://github.com/pexpect/pexpect/issues/302

Signed-off-by: Rami Rosen <rami.rosen@intel.com>
---
 framework/ssh_pexpect.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/framework/ssh_pexpect.py b/framework/ssh_pexpect.py
index 96c4409..f0348b6 100644
--- a/framework/ssh_pexpect.py
+++ b/framework/ssh_pexpect.py
@@ -1,6 +1,6 @@
 import time
 import pexpect
-import pxssh
+from pexpect import pxssh
 from debugger import ignore_keyintr, aware_keyintr
 from exception import TimeoutException, SSHConnectionException, SSHSessionDeadException
 from utils import RED, GREEN
-- 
2.7.4

             reply	other threads:[~2016-06-26 17:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-26 17:58 Rami Rosen [this message]
2016-06-29  1:01 ` Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466963902-23114-1-git-send-email-rami.rosen@intel.com \
    --to=rami.rosen@intel.com \
    --cc=dts@dpdk.org \
    --cc=yong.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).