test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH] framework: avoid error on import pxssh.
@ 2016-06-26 17:58 Rami Rosen
  2016-06-29  1:01 ` Liu, Yong
  0 siblings, 1 reply; 2+ messages in thread
From: Rami Rosen @ 2016-06-26 17:58 UTC (permalink / raw)
  To: yong.liu; +Cc: dts, Rami Rosen

This patch adds "from pexpect" to the "import pxsh" call. In newer versions
(higher than 4) of python-pexpect, not having "from expect" will cause the 
following error: "ImportError: No module named pxssh".
See also: https://github.com/pexpect/pexpect/issues/302

Signed-off-by: Rami Rosen <rami.rosen@intel.com>
---
 framework/ssh_pexpect.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/framework/ssh_pexpect.py b/framework/ssh_pexpect.py
index 96c4409..f0348b6 100644
--- a/framework/ssh_pexpect.py
+++ b/framework/ssh_pexpect.py
@@ -1,6 +1,6 @@
 import time
 import pexpect
-import pxssh
+from pexpect import pxssh
 from debugger import ignore_keyintr, aware_keyintr
 from exception import TimeoutException, SSHConnectionException, SSHSessionDeadException
 from utils import RED, GREEN
-- 
2.7.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH] framework: avoid error on import pxssh.
  2016-06-26 17:58 [dts] [PATCH] framework: avoid error on import pxssh Rami Rosen
@ 2016-06-29  1:01 ` Liu, Yong
  0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2016-06-29  1:01 UTC (permalink / raw)
  To: Rami Rosen; +Cc: dts

Thanks Rami, applied.

On 06/27/2016 01:58 AM, Rami Rosen wrote:
> This patch adds "from pexpect" to the "import pxsh" call. In newer versions
> (higher than 4) of python-pexpect, not having "from expect" will cause the
> following error: "ImportError: No module named pxssh".
> See also: https://github.com/pexpect/pexpect/issues/302
>
> Signed-off-by: Rami Rosen <rami.rosen@intel.com>
> ---
>   framework/ssh_pexpect.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/framework/ssh_pexpect.py b/framework/ssh_pexpect.py
> index 96c4409..f0348b6 100644
> --- a/framework/ssh_pexpect.py
> +++ b/framework/ssh_pexpect.py
> @@ -1,6 +1,6 @@
>   import time
>   import pexpect
> -import pxssh
> +from pexpect import pxssh
>   from debugger import ignore_keyintr, aware_keyintr
>   from exception import TimeoutException, SSHConnectionException, SSHSessionDeadException
>   from utils import RED, GREEN

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-06-29  0:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-26 17:58 [dts] [PATCH] framework: avoid error on import pxssh Rami Rosen
2016-06-29  1:01 ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).