test suite reviews and discussions
 help / color / mirror / Atom feed
From: Yufen Mo <yufengx.mo@intel.com>
To: dts@dpdk.org
Cc: yufengmx <yufengx.mo@intel.com>
Subject: [dts] [PATCH V2]Ethtool: update automation testing script
Date: Wed, 27 Jul 2016 14:41:52 +0800	[thread overview]
Message-ID: <1469601712-4962-2-git-send-email-yufengx.mo@intel.com> (raw)
In-Reply-To: <1469601712-4962-1-git-send-email-yufengx.mo@intel.com>

From: yufengmx <yufengx.mo@intel.com>

*. close eeprom test case on FVL for FVL series firmware not supported
*. reset ring parameter after ring parameter is used
*. set testing content the same user space ethtool dumped

Signed-off-by: yufengmx <yufengx.mo@intel.com>
---
 tests/TestSuite_userspace_ethtool.py | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py
index c718a58..26044a3 100644
--- a/tests/TestSuite_userspace_ethtool.py
+++ b/tests/TestSuite_userspace_ethtool.py
@@ -128,8 +128,8 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
             return 1518
 
     def resize_linux_eeprom_file(self, dpdk_eeprom_file, linux_eeprom_file):
-        basePath = self.dut.base_dir
-        with open( basePath + dpdk_eeprom_file, 'rb') as fpDpdk:
+        basePath = os.sep + "root" + self.dut.base_dir[1:] + os.sep
+        with open( basePath + os.sep + dpdk_eeprom_file, 'rb') as fpDpdk:
             dpdk_bytes = fpDpdk.read()
             dpdk_length = len(dpdk_bytes)
 
@@ -220,7 +220,10 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
 
         portsinfo = []
         ori_drivers = []
-
+        
+        if self.nic.startswith("fortville"):
+            return
+        
         for portid in range(len(self.ports)):
             self.dut.send_expect("regs %d regs_%d.bin" % (portid, portid), "EthApp>")
             portinfo = {'portid': portid, 'reg_file': 'regs_%d.bin' % portid}
@@ -300,8 +303,8 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
         """
         Test ethtool app ring parameter getting and setting
         """
-        self.dut.send_expect(self.cmd, "EthApp>", 60)
         for index in range(len(self.ports)):
+            self.dut.send_expect(self.cmd, "EthApp>", 60)
             port = self.ports[index]
             ori_rx_pkts, ori_tx_pkts = self.strip_portstats(port)
             _, rx_max, _, tx_max = self.strip_ringparam(index)
@@ -315,8 +318,7 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
             pkt.send_pkt(tx_port=intf)
             rx_pkts, tx_pkts = self.strip_portstats(index)
             self.verify(rx_pkts == ori_rx_pkts + 1, "Failed to forward after ring parameter changed")
-
-        self.dut.send_expect("quit", "# ")
+            self.dut.send_expect("quit", "# ")
 
     def test_ethtool_vlan(self):
         """
-- 
1.9.3

  reply	other threads:[~2016-07-27  6:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-27  6:41 Yufen Mo
2016-07-27  6:41 ` Yufen Mo [this message]
2016-07-27  9:30   ` Liu, Yong
  -- strict thread matches above, loose matches on Subject: below --
2016-07-27  3:57 Yufen Mo
2016-07-27  3:57 ` Yufen Mo
2016-07-27  4:27   ` Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1469601712-4962-2-git-send-email-yufengx.mo@intel.com \
    --to=yufengx.mo@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).