* [dts] [dts 1/2][PATCH V1] set dpdk log level to debug level
@ 2016-08-18 2:31 xu,huilong
2016-08-18 2:31 ` [dts] [dts 2/2][PATCH V1] update coremask test case xu,huilong
2016-08-18 7:31 ` [dts] [dts 1/2][PATCH V1] set dpdk log level to debug level Liu, Yong
0 siblings, 2 replies; 6+ messages in thread
From: xu,huilong @ 2016-08-18 2:31 UTC (permalink / raw)
To: dts; +Cc: xu,huilong
Signed-off-by: xu,huilong <huilongx.xu@intel.com>
---
framework/project_dpdk.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py
index 4e44793..6ea8fb4 100644
--- a/framework/project_dpdk.py
+++ b/framework/project_dpdk.py
@@ -133,6 +133,8 @@ class DPDKdut(Dut):
Set default RX/TX PMD function, now only take effect on ixgbe.
"""
[arch, machine, env, toolchain] = self.target.split('-')
+ self.send_expect("sed -i -e 's/CONFIG_RTE_LOG_LEVEL=.*$/"
+ + "CONFIG_RTE_LOG_LEVEL=RTE_LOG_DEBUG/' config/common_base", "# ", 30)
if dts.rx_mode is None:
mode = 'default'
else:
--
1.9.3
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dts] [dts 2/2][PATCH V1] update coremask test case
2016-08-18 2:31 [dts] [dts 1/2][PATCH V1] set dpdk log level to debug level xu,huilong
@ 2016-08-18 2:31 ` xu,huilong
2016-08-18 7:31 ` [dts] [dts 1/2][PATCH V1] set dpdk log level to debug level Liu, Yong
1 sibling, 0 replies; 6+ messages in thread
From: xu,huilong @ 2016-08-18 2:31 UTC (permalink / raw)
To: dts; +Cc: xu,huilong
update list:
1. set log leavel to debug leavel when setup dpdk app
2. skip core 0 when run all core mask.
Signed-off-by: xu,huilong <huilongx.xu@intel.com>
---
tests/TestSuite_coremask.py | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tests/TestSuite_coremask.py b/tests/TestSuite_coremask.py
index 4f6f4bd..1fa30e1 100644
--- a/tests/TestSuite_coremask.py
+++ b/tests/TestSuite_coremask.py
@@ -17,7 +17,7 @@ from test_case import TestCase
# Test class.
#
-command_line = """./%s/app/test -c %s -n %d"""
+command_line = """./%s/app/test -c %s -n %d --log-level 8"""
class TestCoremask(TestCase):
@@ -79,11 +79,11 @@ class TestCoremask(TestCase):
out = self.dut.send_expect(command, "RTE>>", 10)
- self.verify("EAL: Master lcore 0 is ready" in out,
- "Core 0 not ready")
+ self.verify("EAL: Master lcore 1 is ready" in out,
+ "Core 1 not ready")
- self.verify("EAL: Detected lcore 0 as core" in out,
- "Core 0 not detected")
+ self.verify("EAL: Detected lcore 1 as core" in out,
+ "Core 1 not detected")
for core in self.all_cores[1:]:
self.verify("EAL: lcore %s is ready" % core in out,
@@ -99,7 +99,7 @@ class TestCoremask(TestCase):
Check coremask parsing for more cores than available.
"""
- command_line = """./%s/app/test -c %s -n %d|tee out"""
+ command_line = """./%s/app/test -c %s -n %d --log-level 8|tee out"""
# Default big coremask value 128
big_coremask_size = 128
--
1.9.3
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dts] [dts 1/2][PATCH V1] set dpdk log level to debug level
2016-08-18 2:31 [dts] [dts 1/2][PATCH V1] set dpdk log level to debug level xu,huilong
2016-08-18 2:31 ` [dts] [dts 2/2][PATCH V1] update coremask test case xu,huilong
@ 2016-08-18 7:31 ` Liu, Yong
2016-08-18 8:24 ` Xu, HuilongX
1 sibling, 1 reply; 6+ messages in thread
From: Liu, Yong @ 2016-08-18 7:31 UTC (permalink / raw)
To: Xu, HuilongX, dts; +Cc: Xu, HuilongX
Huilong,
Please move the configuration file change into core_mask suite.
We'd better not change any code in dpdk, DTS should validate default dpdk code.
If some suites require special setting, it should be included in the test suite.
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,huilong
> Sent: Thursday, August 18, 2016 10:32 AM
> To: dts@dpdk.org
> Cc: Xu, HuilongX
> Subject: [dts] [dts 1/2][PATCH V1] set dpdk log level to debug level
>
> Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> ---
> framework/project_dpdk.py | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py
> index 4e44793..6ea8fb4 100644
> --- a/framework/project_dpdk.py
> +++ b/framework/project_dpdk.py
> @@ -133,6 +133,8 @@ class DPDKdut(Dut):
> Set default RX/TX PMD function, now only take effect on ixgbe.
> """
> [arch, machine, env, toolchain] = self.target.split('-')
> + self.send_expect("sed -i -e 's/CONFIG_RTE_LOG_LEVEL=.*$/"
> + + "CONFIG_RTE_LOG_LEVEL=RTE_LOG_DEBUG/'
> config/common_base", "# ", 30)
> if dts.rx_mode is None:
> mode = 'default'
> else:
> --
> 1.9.3
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dts] [dts 1/2][PATCH V1] set dpdk log level to debug level
2016-08-18 7:31 ` [dts] [dts 1/2][PATCH V1] set dpdk log level to debug level Liu, Yong
@ 2016-08-18 8:24 ` Xu, HuilongX
2016-08-19 1:13 ` Liu, Yong
0 siblings, 1 reply; 6+ messages in thread
From: Xu, HuilongX @ 2016-08-18 8:24 UTC (permalink / raw)
To: Liu, Yong, dts
Hi yong,
Dpdk package default highest log level is INFO(The value is 7).
So we should reset compile switch for update log level to DEBUG(The value is 8).
When we run dpdk app the default log is INFO, unless we set EAL parameter --log-level.
Thanks a lot
> -----Original Message-----
> From: Liu, Yong
> Sent: Thursday, August 18, 2016 3:32 PM
> To: Xu, HuilongX; dts@dpdk.org
> Cc: Xu, HuilongX
> Subject: RE: [dts] [dts 1/2][PATCH V1] set dpdk log level to debug level
>
> Huilong,
> Please move the configuration file change into core_mask suite.
> We'd better not change any code in dpdk, DTS should validate default
> dpdk code.
> If some suites require special setting, it should be included in the
> test suite.
>
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,huilong
> > Sent: Thursday, August 18, 2016 10:32 AM
> > To: dts@dpdk.org
> > Cc: Xu, HuilongX
> > Subject: [dts] [dts 1/2][PATCH V1] set dpdk log level to debug level
> >
> > Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> > ---
> > framework/project_dpdk.py | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py
> > index 4e44793..6ea8fb4 100644
> > --- a/framework/project_dpdk.py
> > +++ b/framework/project_dpdk.py
> > @@ -133,6 +133,8 @@ class DPDKdut(Dut):
> > Set default RX/TX PMD function, now only take effect on ixgbe.
> > """
> > [arch, machine, env, toolchain] = self.target.split('-')
> > + self.send_expect("sed -i -e 's/CONFIG_RTE_LOG_LEVEL=.*$/"
> > + + "CONFIG_RTE_LOG_LEVEL=RTE_LOG_DEBUG/'
> > config/common_base", "# ", 30)
> > if dts.rx_mode is None:
> > mode = 'default'
> > else:
> > --
> > 1.9.3
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dts] [dts 1/2][PATCH V1] set dpdk log level to debug level
2016-08-18 8:24 ` Xu, HuilongX
@ 2016-08-19 1:13 ` Liu, Yong
2016-08-19 5:24 ` Xu, HuilongX
0 siblings, 1 reply; 6+ messages in thread
From: Liu, Yong @ 2016-08-19 1:13 UTC (permalink / raw)
To: Xu, HuilongX, dts
Huilong, I have known this. What I mean is that not change default configuration for all suites. It may cause unexpected results.
You can change configuration for certain test suite just in the suite. There're lots samples like ieee1588.
Thanks
> -----Original Message-----
> From: Xu, HuilongX
> Sent: Thursday, August 18, 2016 4:24 PM
> To: Liu, Yong; dts@dpdk.org
> Subject: RE: [dts] [dts 1/2][PATCH V1] set dpdk log level to debug level
>
> Hi yong,
> Dpdk package default highest log level is INFO(The value is 7).
> So we should reset compile switch for update log level to DEBUG(The value
> is 8).
> When we run dpdk app the default log is INFO, unless we set EAL parameter
> --log-level.
> Thanks a lot
>
> > -----Original Message-----
> > From: Liu, Yong
> > Sent: Thursday, August 18, 2016 3:32 PM
> > To: Xu, HuilongX; dts@dpdk.org
> > Cc: Xu, HuilongX
> > Subject: RE: [dts] [dts 1/2][PATCH V1] set dpdk log level to debug level
> >
> > Huilong,
> > Please move the configuration file change into core_mask suite.
> > We'd better not change any code in dpdk, DTS should validate default
> > dpdk code.
> > If some suites require special setting, it should be included in the
> > test suite.
> >
> > > -----Original Message-----
> > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,huilong
> > > Sent: Thursday, August 18, 2016 10:32 AM
> > > To: dts@dpdk.org
> > > Cc: Xu, HuilongX
> > > Subject: [dts] [dts 1/2][PATCH V1] set dpdk log level to debug level
> > >
> > > Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> > > ---
> > > framework/project_dpdk.py | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py
> > > index 4e44793..6ea8fb4 100644
> > > --- a/framework/project_dpdk.py
> > > +++ b/framework/project_dpdk.py
> > > @@ -133,6 +133,8 @@ class DPDKdut(Dut):
> > > Set default RX/TX PMD function, now only take effect on ixgbe.
> > > """
> > > [arch, machine, env, toolchain] = self.target.split('-')
> > > + self.send_expect("sed -i -e 's/CONFIG_RTE_LOG_LEVEL=.*$/"
> > > + + "CONFIG_RTE_LOG_LEVEL=RTE_LOG_DEBUG/'
> > > config/common_base", "# ", 30)
> > > if dts.rx_mode is None:
> > > mode = 'default'
> > > else:
> > > --
> > > 1.9.3
> > >
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dts] [dts 1/2][PATCH V1] set dpdk log level to debug level
2016-08-19 1:13 ` Liu, Yong
@ 2016-08-19 5:24 ` Xu, HuilongX
0 siblings, 0 replies; 6+ messages in thread
From: Xu, HuilongX @ 2016-08-19 5:24 UTC (permalink / raw)
To: Liu, Yong, dts
Hi yong,
Thanks a lot for your comments, I will send V2 patch ASAP.
> -----Original Message-----
> From: Liu, Yong
> Sent: Friday, August 19, 2016 9:13 AM
> To: Xu, HuilongX; dts@dpdk.org
> Subject: RE: [dts] [dts 1/2][PATCH V1] set dpdk log level to debug level
>
> Huilong, I have known this. What I mean is that not change default
> configuration for all suites. It may cause unexpected results.
> You can change configuration for certain test suite just in the suite.
> There're lots samples like ieee1588.
>
> Thanks
> > -----Original Message-----
> > From: Xu, HuilongX
> > Sent: Thursday, August 18, 2016 4:24 PM
> > To: Liu, Yong; dts@dpdk.org
> > Subject: RE: [dts] [dts 1/2][PATCH V1] set dpdk log level to debug
> level
> >
> > Hi yong,
> > Dpdk package default highest log level is INFO(The value is 7).
> > So we should reset compile switch for update log level to DEBUG(The
> value
> > is 8).
> > When we run dpdk app the default log is INFO, unless we set EAL
> parameter
> > --log-level.
> > Thanks a lot
> >
> > > -----Original Message-----
> > > From: Liu, Yong
> > > Sent: Thursday, August 18, 2016 3:32 PM
> > > To: Xu, HuilongX; dts@dpdk.org
> > > Cc: Xu, HuilongX
> > > Subject: RE: [dts] [dts 1/2][PATCH V1] set dpdk log level to debug
> level
> > >
> > > Huilong,
> > > Please move the configuration file change into core_mask suite.
> > > We'd better not change any code in dpdk, DTS should validate default
> > > dpdk code.
> > > If some suites require special setting, it should be included in the
> > > test suite.
> > >
> > > > -----Original Message-----
> > > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,huilong
> > > > Sent: Thursday, August 18, 2016 10:32 AM
> > > > To: dts@dpdk.org
> > > > Cc: Xu, HuilongX
> > > > Subject: [dts] [dts 1/2][PATCH V1] set dpdk log level to debug
> level
> > > >
> > > > Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> > > > ---
> > > > framework/project_dpdk.py | 2 ++
> > > > 1 file changed, 2 insertions(+)
> > > >
> > > > diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py
> > > > index 4e44793..6ea8fb4 100644
> > > > --- a/framework/project_dpdk.py
> > > > +++ b/framework/project_dpdk.py
> > > > @@ -133,6 +133,8 @@ class DPDKdut(Dut):
> > > > Set default RX/TX PMD function, now only take effect on
> ixgbe.
> > > > """
> > > > [arch, machine, env, toolchain] = self.target.split('-')
> > > > + self.send_expect("sed -i -e 's/CONFIG_RTE_LOG_LEVEL=.*$/"
> > > > + + "CONFIG_RTE_LOG_LEVEL=RTE_LOG_DEBUG/'
> > > > config/common_base", "# ", 30)
> > > > if dts.rx_mode is None:
> > > > mode = 'default'
> > > > else:
> > > > --
> > > > 1.9.3
> > > >
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-08-19 5:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-18 2:31 [dts] [dts 1/2][PATCH V1] set dpdk log level to debug level xu,huilong
2016-08-18 2:31 ` [dts] [dts 2/2][PATCH V1] update coremask test case xu,huilong
2016-08-18 7:31 ` [dts] [dts 1/2][PATCH V1] set dpdk log level to debug level Liu, Yong
2016-08-18 8:24 ` Xu, HuilongX
2016-08-19 1:13 ` Liu, Yong
2016-08-19 5:24 ` Xu, HuilongX
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).