test suite reviews and discussions
 help / color / mirror / Atom feed
From: "xu,huilong" <huilongx.xu@intel.com>
To: dts@dpdk.org
Cc: "xu,huilong" <huilongx.xu@intel.com>
Subject: [dts] [PATCH V1] fix niantic ethtool -i not support issue
Date: Tue,  7 Mar 2017 14:45:13 +0800	[thread overview]
Message-ID: <1488869113-6242-1-git-send-email-huilongx.xu@intel.com> (raw)

The virtual nic by kni on niantic nic, it only support ethool and ethool -k operation.

Signed-off-by: xu,huilong <huilongx.xu@intel.com>
---
 tests/TestSuite_kni.py | 23 +++++++++++++----------
 1 file changed, 13 insertions(+), 10 deletions(-)

diff --git a/tests/TestSuite_kni.py b/tests/TestSuite_kni.py
index 0825903..0e4211a 100644
--- a/tests/TestSuite_kni.py
+++ b/tests/TestSuite_kni.py
@@ -664,6 +664,19 @@ class TestKni(TestCase):
                         "ethtool not supported")
             self.verify("Operation not supported" not in out,
                         "ethtool not supported")
+            
+            # Request features status
+            out = self.dut.send_expect("ethtool -k %s" % virtual_interface, "# ")
+            self.verify(("Features for %s" % virtual_interface in out) or
+                        ("Offload parameters for %s" %
+                         virtual_interface in out),
+                        "'ethtool -k' not supported")
+            self.verify("Operation not supported" not in out,
+                        "'ethtool -k' not supported")
+            
+            if self.nic == 'niantic':
+               # niantic nic only support ethtool and ethtool -k operation
+                continue
 
             # Request driver information
             out = self.dut.send_expect("ethtool -i %s" % virtual_interface,
@@ -688,16 +701,6 @@ class TestKni(TestCase):
                         "'ethtool -S' not supported")
             self.verify("Operation not supported" not in out,
                         "ethtool '-S' not supported")
-
-            # Request features status
-            out = self.dut.send_expect("ethtool -k %s" % virtual_interface, "# ")
-            self.verify(("Features for %s" % virtual_interface in out) or
-                        ("Offload parameters for %s" %
-                         virtual_interface in out),
-                        "'ethtool -k' not supported")
-            self.verify("Operation not supported" not in out,
-                        "'ethtool -k' not supported")
-
             # Request ring parameters
             out = self.dut.send_expect("ethtool -g %s" % virtual_interface,
                                        "# ")
-- 
1.9.3

             reply	other threads:[~2017-03-07  6:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-07  6:45 xu,huilong [this message]
2017-03-08  8:06 ` Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1488869113-6242-1-git-send-email-huilongx.xu@intel.com \
    --to=huilongx.xu@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).