From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 856D25A44 for ; Fri, 12 May 2017 09:43:14 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP; 12 May 2017 00:43:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,328,1491289200"; d="scan'208";a="85928946" Received: from unknown (HELO dpdk-fedora20.icx.intel.com) ([10.240.176.135]) by orsmga002.jf.intel.com with ESMTP; 12 May 2017 00:43:13 -0700 From: "xu,huilong" To: dts@dpdk.org Cc: "xu,huilong" Date: Fri, 12 May 2017 15:44:27 +0800 Message-Id: <1494575072-44798-7-git-send-email-huilongx.xu@intel.com> X-Mailer: git-send-email 1.9.3 In-Reply-To: <1494575072-44798-1-git-send-email-huilongx.xu@intel.com> References: <1494575072-44798-1-git-send-email-huilongx.xu@intel.com> Subject: [dts] [PATCH V2] fix user space ethtool failed case X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 May 2017 07:43:15 -0000 1. update user space ethtool compile error, becauese the example path update in dpdk already 2. kernel space ethtool dump nic eeprom file size differnet dpdk user space ethtool, so should cat out dpdk ethtool dump nic eeprom file and the file size same with kernel ethtool. then use file md5 check the file is same Signed-off-by: xu,huilong --- tests/TestSuite_userspace_ethtool.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py index 937a9e5..36ff104 100644 --- a/tests/TestSuite_userspace_ethtool.py +++ b/tests/TestSuite_userspace_ethtool.py @@ -61,7 +61,7 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator): self.verify("Error" not in out, "compilation error 1") self.verify("No such file" not in out, "compilation error 2") - path = "./examples/ethtool/ethtool-app/ethtool-app/%s/ethtool" % self.target + path = "./examples/ethtool/ethtool-app/%s/ethtool" % self.target self.cmd = "%s -c f -n %d" % (path, self.dut.get_memory_channels()) # pause frame basic configuration @@ -370,7 +370,9 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator): self.dut.send_expect("ethtool --eeprom-dump %s raw on > %s" % (intf, ethtool_eeprom), "# ") # wait for file ready time.sleep(2) - portinfo['ethtool_eeprom'] = ethtool_eeprom + dpdk_eeprom_size = int(self.dut.send_expect('ls -all %s' % portinfo['eeprom_file'], '# ').split(' ')[4].strip()) + self.dut.send_expect('dd if=%s of=%s bs=%d count=1' % (ethtool_eeprom, "ethtool_eeprom_%d_cat.bin" % index, dpdk_eeprom_size), "#") + portinfo['ethtool_eeprom'] = "ethtool_eeprom_%d_cat.bin" % index # bind to original driver portinfo['net_dev'].bind_driver(portinfo['ori_driver']) @@ -499,8 +501,10 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator): for index in range(len(self.ports)): port = self.ports[index] ori_rx_pkts, _ = self.strip_portstats(index) + time.sleep(10) # stop port self.dut.send_expect("stop %d" % index, "EthApp>") + time.sleep(10) # check packet not forwarded when port is stop pkt = Packet() tester_port = self.tester.get_local_port(port) -- 1.9.3