test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH v1] framework crb: login CRB by username and password
@ 2017-07-26  5:53 Marvin Liu
  0 siblings, 0 replies; only message in thread
From: Marvin Liu @ 2017-07-26  5:53 UTC (permalink / raw)
  To: dts; +Cc: Marvin Liu

There's no default username or password for CRB. These kind of
information should be configured.

Signed-off-by: Marvin Liu <yong.liu@intel.com>

diff --git a/framework/crb.py b/framework/crb.py
index bf07345..00f418d 100644
--- a/framework/crb.py
+++ b/framework/crb.py
@@ -61,11 +61,13 @@ class Crb(object):
 
         self.logger = getLogger(name)
         self.session = SSHConnection(self.get_ip_address(), name,
+                                     self.get_username(),
                                      self.get_password())
         self.session.init_log(self.logger)
         self.alt_session = SSHConnection(
             self.get_ip_address(),
             name + '_alt',
+            self.get_username(),
             self.get_password())
         self.alt_session.init_log(self.logger)
 
@@ -88,7 +90,9 @@ class Crb(object):
         Create new session for addtional useage. This session will not enable log.
         """
         logger = getLogger(name)
-        session = SSHConnection(self.get_ip_address(), name,
+        session = SSHConnection(self.get_ip_address(),
+                                name,
+                                self.get_username(),
                                 self.get_password())
         session.init_log(logger)
         self.sessions.append(session)
@@ -103,7 +107,8 @@ class Crb(object):
                 save_session.close()
                 logger = getLogger(save_session.name)
                 logger.logger_exit()
-            self.sessions.remove(save_session)
+                self.sessions.remove(save_session)
+                break
 
     def reconnect_session(self, alt_session=False):
         """
@@ -121,11 +126,12 @@ class Crb(object):
             session = SSHConnection(
                 self.get_ip_address(),
                 self.name + '_alt',
+                self.get_username(),
                 self.get_password())
             self.alt_session = session
         else:
             session = SSHConnection(self.get_ip_address(), self.name,
-                                    self.get_password())
+                                    self.get_username(), self.get_password())
             self.session = session
 
         session.init_log(self.logger)
-- 
1.9.3

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-07-26  5:55 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-26  5:53 [dts] [PATCH v1] framework crb: login CRB by username and password Marvin Liu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).