From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by dpdk.org (Postfix) with ESMTP id C209A330D for ; Mon, 7 Aug 2017 13:38:50 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E073415A2; Mon, 7 Aug 2017 04:38:49 -0700 (PDT) Received: from localhost.localdomain.com (unknown [10.169.40.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 511563F540; Mon, 7 Aug 2017 04:38:49 -0700 (PDT) From: Herbert Guan To: dts@dpdk.org, yong.liu@intel.com Cc: Herbert Guan Date: Mon, 7 Aug 2017 19:38:36 +0800 Message-Id: <1502105916-5947-1-git-send-email-herbert.guan@arm.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1502075816-1328-1-git-send-email-herbert.guan@arm.com> References: <1502075816-1328-1-git-send-email-herbert.guan@arm.com> Subject: [dts] [PATCH v3] framework: wait 10 seconds after testpmd starts to ensure link is up X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Aug 2017 11:38:51 -0000 It'll take some time for links up after testpmd is started for non-fiber test beds. Before that "testpmd>" will be prompted but test shall not start until links are up. It's been tested that waiting 10 seconds can resolve this issue on both fiber and non-fiber test beds. Signed-off-by: Herbert Guan --- framework/pmd_output.py | 3 +++ tests/TestSuite_dynamic_config.py | 2 ++ tests/TestSuite_queue_start_stop.py | 1 + 3 files changed, 6 insertions(+) diff --git a/framework/pmd_output.py b/framework/pmd_output.py index 260f42c..2d1e3d7 100644 --- a/framework/pmd_output.py +++ b/framework/pmd_output.py @@ -31,6 +31,7 @@ import os import re +from time import sleep from settings import TIMEOUT, PROTOCOL_PACKET_SIZE, get_nic_driver from utils import create_mask @@ -119,6 +120,8 @@ class PmdOutput(): command += " --disable-hw-vlan-filter" out = self.dut.send_expect(command, "testpmd> ", 120) self.command = command + # wait 10s to ensure links getting up before test start. + sleep(10) return out def execute_cmd(self, pmd_cmd, expected='testpmd> ', timeout=TIMEOUT, diff --git a/tests/TestSuite_dynamic_config.py b/tests/TestSuite_dynamic_config.py index b4ddede..699c303 100644 --- a/tests/TestSuite_dynamic_config.py +++ b/tests/TestSuite_dynamic_config.py @@ -37,6 +37,7 @@ Test the dynamic driver configuration feature. """ import utils +import time from test_case import TestCase @@ -122,6 +123,7 @@ class TestDynamicConfig(TestCase): cmd += " --disable-hw-vlan-filter" self.dut.send_expect("%s" % cmd, "testpmd> ", 120) + time.sleep(5) self.dut.send_expect("start", "testpmd> ", 120) diff --git a/tests/TestSuite_queue_start_stop.py b/tests/TestSuite_queue_start_stop.py index d1df66b..cc031f5 100644 --- a/tests/TestSuite_queue_start_stop.py +++ b/tests/TestSuite_queue_start_stop.py @@ -131,6 +131,7 @@ class TestQueueStartStop(TestCase): #dpdk start try: self.dut.send_expect("./app/test-pmd/testpmd -c 0xf -n 4 -- -i --portmask=0x1 --port-topology=loop", "testpmd>", 120) + time.sleep(5) self.dut.send_expect("set fwd mac", "testpmd>") self.dut.send_expect("start", "testpmd>") self.check_forwarding([0, 0], self.nic) -- 1.8.3.1