[dts] [PATCH V1] tests/generic_filter: fix testpmd not support 128 queues

[dts] [PATCH V1] tests/generic_filter: fix testpmd not support 128 queues

[lu,peipei]

due to testpmd support 64 queues by default,so test the case need to modify ixgbe_ethdev.h.

Signed-off-by: lu,peipei <peipeix.lu@intel.com>
---
 tests/TestSuite_generic_filter.py | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_generic_filter.py b/tests/TestSuite_generic_filter.py
index c42ec5a..42287aa 100644
--- a/tests/TestSuite_generic_filter.py
+++ b/tests/TestSuite_generic_filter.py
@@ -690,8 +690,9 @@ class TestGeneric_filter(TestCase):
 
     def test_128_queues(self):
         # testpmd can't support assign queue to received package, so can't test
-        self.verify(False, "testpmd not support assign queue 127 received package")
-        if self.nic == "niantic":
+        if self.kdriver == "ixgbe":
+	    self.dut.send_expect("sed -i -e 's/#define IXGBE_NONE_MODE_TX_NB_QUEUES 64$/#define IXGBE_NONE_MODE_TX_NB_QUEUES 128/' drivers/net/ixgbe/ixgbe_ethdev.h", "# ",30)
+	    self.dut.build_install_dpdk(self.target)
             global valports
             total_mbufs = self.request_mbufs(128) * len(valports)
             self.pmdout.start_testpmd(
@@ -825,3 +826,5 @@ class TestGeneric_filter(TestCase):
         Run after each test case.
         """
         self.dut.kill_all()
+	self.dut.send_expect("sed -i -e 's/#define IXGBE_NONE_MODE_TX_NB_QUEUES 64$/#define IXGBE_NONE_MODE_TX_NB_QUEUES 128/' drivers/net/ixgbe/ixgbe_ethdev.h", "# ",30)
+	self.dut.build_install_dpdk(self.target)
-- 
1.9.3

Re: [dts] [PATCH V1] tests/generic_filter: fix testpmd not support 128 queues

[Liu, Yong]

Applied, please take core your description. Root cause is that ixgbe 
driver rather than testpmd can not support 128 queues.

On 08/29/2017 09:09 AM, lu,peipei wrote:
> due to testpmd support 64 queues by default,so test the case need to modify ixgbe_ethdev.h.
>
> Signed-off-by: lu,peipei<peipeix.lu@intel.com>
> ---
>   tests/TestSuite_generic_filter.py | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)

[dts] [PATCH V1] tests/generic_filter: fix testpmd not support 128 queues

[lu,peipei]

due to testpmd support 64 queues by default,so test the case need to modify ixgbe_ethdev.h.

Signed-off-by: lu,peipei <peipeix.lu@intel.com>
---
 tests/TestSuite_generic_filter.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_generic_filter.py b/tests/TestSuite_generic_filter.py
index c42ec5a..508b9cb 100644
--- a/tests/TestSuite_generic_filter.py
+++ b/tests/TestSuite_generic_filter.py
@@ -690,8 +690,10 @@ class TestGeneric_filter(TestCase):
 
     def test_128_queues(self):
         # testpmd can't support assign queue to received package, so can't test
-        self.verify(False, "testpmd not support assign queue 127 received package")
+        #self.verify(False, "testpmd not support assign queue 127 received package")
         if self.nic == "niantic":
+	    self.dut.send_expect("sed -i -e 's/#define IXGBE_NONE_MODE_TX_NB_QUEUES 64$/#define IXGBE_NONE_MODE_TX_NB_QUEUES 128/' drivers/net/ixgbe/ixgbe_ethdev.h", "# ",30)
+	    self.dut.build_install_dpdk(self.target)
             global valports
             total_mbufs = self.request_mbufs(128) * len(valports)
             self.pmdout.start_testpmd(
@@ -825,3 +827,4 @@ class TestGeneric_filter(TestCase):
         Run after each test case.
         """
         self.dut.kill_all()
+	self.dut.send_expect("sed -i -e 's/#define IXGBE_NONE_MODE_TX_NB_QUEUES 128$/#define IXGBE_NONE_MODE_TX_NB_QUEUES 64/' drivers/net/ixgbe/ixgbe_ethdev.h", "# ",30)
-- 
1.9.3

Re: [dts] [PATCH V1] tests/generic_filter: fix testpmd not support 128 queues

[Liu, Yong]

Peipei, 
Some comments below.

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lu,peipei
> Sent: Monday, August 28, 2017 1:51 PM
> To: dts@dpdk.org
> Cc: Lu, PeipeiX <peipeix.lu@intel.com>
> Subject: [dts] [PATCH V1] tests/generic_filter: fix testpmd not support
> 128 queues
> 
> due to testpmd support 64 queues by default,so test the case need to
> modify ixgbe_ethdev.h.
> 
> Signed-off-by: lu,peipei <peipeix.lu@intel.com>
> ---
>  tests/TestSuite_generic_filter.py | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_generic_filter.py
> b/tests/TestSuite_generic_filter.py
> index c42ec5a..508b9cb 100644
> --- a/tests/TestSuite_generic_filter.py
> +++ b/tests/TestSuite_generic_filter.py
> @@ -690,8 +690,10 @@ class TestGeneric_filter(TestCase):
> 
>      def test_128_queues(self):
>          # testpmd can't support assign queue to received package, so
> can't test
> -        self.verify(False, "testpmd not support assign queue 127 received
> package")
> +        #self.verify(False, "testpmd not support assign queue 127
> received package")

Please just remove this line, there's no reference value in this comment.

>          if self.nic == "niantic":
> +	    self.dut.send_expect("sed -i -e 's/#define
> IXGBE_NONE_MODE_TX_NB_QUEUES 64$/#define IXGBE_NONE_MODE_TX_NB_QUEUES
> 128/' drivers/net/ixgbe/ixgbe_ethdev.h", "# ",30)

It's better to use self.kdriver for checking, because of some NICs like "sageville" still need to the same modification.

> +	    self.dut.build_install_dpdk(self.target)
>              global valports
>              total_mbufs = self.request_mbufs(128) * len(valports)
>              self.pmdout.start_testpmd(
> @@ -825,3 +827,4 @@ class TestGeneric_filter(TestCase):
>          Run after each test case.
>          """
>          self.dut.kill_all()
> +	self.dut.send_expect("sed -i -e 's/#define
> IXGBE_NONE_MODE_TX_NB_QUEUES 128$/#define IXGBE_NONE_MODE_TX_NB_QUEUES
> 64/' drivers/net/ixgbe/ixgbe_ethdev.h", "# ",30)

Please add dpdk build here after changed to default value.

> --
> 1.9.3

[dts] [PATCH V1] tests/generic_filter: fix testpmd not support 128 queues

[lu,peipei]

due to testpmd support 64 queues by default,so test the case need to modify ixgbe_ethdev.h.

Signed-off-by: lu,peipei <peipeix.lu@intel.com>
---
 tests/TestSuite_generic_filter.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_generic_filter.py b/tests/TestSuite_generic_filter.py
index c42ec5a..a8eb2d9 100644
--- a/tests/TestSuite_generic_filter.py
+++ b/tests/TestSuite_generic_filter.py
@@ -55,6 +55,8 @@ class TestGeneric_filter(TestCase):
 
         Generic filter Prerequistites
         """
+	self.dut.send_expect("sed -i -e 's/#define IXGBE_NONE_MODE_TX_NB_QUEUES 64$/#define IXGBE_NONE_MODE_TX_NB_QUEUES 128/' drivers/net/ixgbe/ixgbe_ethdev.h", "# ",30)
+	self.dut.build_install_dpdk(self.target)
 
         # Based on h/w type, choose how many ports to use
         ports = self.dut.get_ports(self.nic)
@@ -690,7 +692,7 @@ class TestGeneric_filter(TestCase):
 
     def test_128_queues(self):
         # testpmd can't support assign queue to received package, so can't test
-        self.verify(False, "testpmd not support assign queue 127 received package")
+        #self.verify(False, "testpmd not support assign queue 127 received package")
         if self.nic == "niantic":
             global valports
             total_mbufs = self.request_mbufs(128) * len(valports)
@@ -825,3 +827,4 @@ class TestGeneric_filter(TestCase):
         Run after each test case.
         """
         self.dut.kill_all()
+	self.dut.send_expect("sed -i -e 's/#define IXGBE_NONE_MODE_TX_NB_QUEUES 128$/#define IXGBE_NONE_MODE_TX_NB_QUEUES 64/' drivers/net/ixgbe/ixgbe_ethdev.h", "# ",30)
-- 
1.9.3

Re: [dts] [PATCH V1] tests/generic_filter: fix testpmd not support 128 queues

[Xu, Qian Q]

Thanks Peipei, do we need build again when we quit this case? 

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lu,peipei
> Sent: Friday, August 25, 2017 4:36 PM
> To: dts@dpdk.org
> Cc: Lu, PeipeiX <peipeix.lu@intel.com>
> Subject: [dts] [PATCH V1] tests/generic_filter: fix testpmd not support 128
> queues
> 
> due to testpmd support 64 queues by default,so test the case need to modify
> ixgbe_ethdev.h.
> 
> Signed-off-by: lu,peipei <peipeix.lu@intel.com>
> ---
>  tests/TestSuite_generic_filter.py | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_generic_filter.py b/tests/TestSuite_generic_filter.py
> index c42ec5a..a8eb2d9 100644
> --- a/tests/TestSuite_generic_filter.py
> +++ b/tests/TestSuite_generic_filter.py
> @@ -55,6 +55,8 @@ class TestGeneric_filter(TestCase):
> 
>          Generic filter Prerequistites
>          """
> +	self.dut.send_expect("sed -i -e 's/#define
> IXGBE_NONE_MODE_TX_NB_QUEUES 64$/#define
> IXGBE_NONE_MODE_TX_NB_QUEUES 128/' drivers/net/ixgbe/ixgbe_ethdev.h",
> "# ",30)
> +	self.dut.build_install_dpdk(self.target)
> 
>          # Based on h/w type, choose how many ports to use
>          ports = self.dut.get_ports(self.nic) @@ -690,7 +692,7 @@ class
> TestGeneric_filter(TestCase):
> 
>      def test_128_queues(self):
>          # testpmd can't support assign queue to received package, so can't test
> -        self.verify(False, "testpmd not support assign queue 127 received package")
> +        #self.verify(False, "testpmd not support assign queue 127
> + received package")
>          if self.nic == "niantic":
>              global valports
>              total_mbufs = self.request_mbufs(128) * len(valports) @@ -825,3 +827,4
> @@ class TestGeneric_filter(TestCase):
>          Run after each test case.
>          """
>          self.dut.kill_all()
> +	self.dut.send_expect("sed -i -e 's/#define
> +IXGBE_NONE_MODE_TX_NB_QUEUES 128$/#define
> IXGBE_NONE_MODE_TX_NB_QUEUES
> +64/' drivers/net/ixgbe/ixgbe_ethdev.h", "# ",30)
> --
> 1.9.3

Re: [dts] [PATCH V1] tests/generic_filter: fix testpmd not support 128 queues

[Liu, Yong]

Peipei,
Look like your patch only aimed for 8259x nics. If that please add judgement that check self.kdriver is ixgbe first and then do these changes.
It will waste some time if we are running test over other types of Nics.

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lu,peipei
> Sent: Friday, August 25, 2017 4:36 PM
> To: dts@dpdk.org
> Cc: Lu, PeipeiX <peipeix.lu@intel.com>
> Subject: [dts] [PATCH V1] tests/generic_filter: fix testpmd not support
> 128 queues
> 
> due to testpmd support 64 queues by default,so test the case need to
> modify ixgbe_ethdev.h.
> 
> Signed-off-by: lu,peipei <peipeix.lu@intel.com>
> ---
>  tests/TestSuite_generic_filter.py | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_generic_filter.py
> b/tests/TestSuite_generic_filter.py
> index c42ec5a..a8eb2d9 100644
> --- a/tests/TestSuite_generic_filter.py
> +++ b/tests/TestSuite_generic_filter.py
> @@ -55,6 +55,8 @@ class TestGeneric_filter(TestCase):
> 
>          Generic filter Prerequistites
>          """
> +	self.dut.send_expect("sed -i -e 's/#define
> IXGBE_NONE_MODE_TX_NB_QUEUES 64$/#define IXGBE_NONE_MODE_TX_NB_QUEUES
> 128/' drivers/net/ixgbe/ixgbe_ethdev.h", "# ",30)
> +	self.dut.build_install_dpdk(self.target)
> 
>          # Based on h/w type, choose how many ports to use
>          ports = self.dut.get_ports(self.nic)
> @@ -690,7 +692,7 @@ class TestGeneric_filter(TestCase):
> 
>      def test_128_queues(self):
>          # testpmd can't support assign queue to received package, so
> can't test
> -        self.verify(False, "testpmd not support assign queue 127 received
> package")
> +        #self.verify(False, "testpmd not support assign queue 127
> received package")
>          if self.nic == "niantic":
>              global valports
>              total_mbufs = self.request_mbufs(128) * len(valports)
> @@ -825,3 +827,4 @@ class TestGeneric_filter(TestCase):
>          Run after each test case.
>          """
>          self.dut.kill_all()
> +	self.dut.send_expect("sed -i -e 's/#define
> IXGBE_NONE_MODE_TX_NB_QUEUES 128$/#define IXGBE_NONE_MODE_TX_NB_QUEUES
> 64/' drivers/net/ixgbe/ixgbe_ethdev.h", "# ",30)
> --
> 1.9.3