test suite reviews and discussions
 help / color / mirror / Atom feed
From: Fangfang Wei <fangfangx.wei@intel.com>
To: dts@dpdk.org
Cc: Fangfangx Wei <fangfangx.wei@intel.com>
Subject: [dts] [PATCH V1] tests/veb: fix rx and tx packet error
Date: Wed, 27 Sep 2017 14:11:19 +0800	[thread overview]
Message-ID: <1506492679-27897-1-git-send-email-fangfangx.wei@intel.com> (raw)

From: Fangfangx Wei <fangfangx.wei@intel.com>

It has some io packets at beginning of starting testpmd, this case is to
verify pf or vf can receive correct packet number from tester.
So calculating rx and tx packet with start packet and end packet is correct.

Signed-off-by: Fangfangx Wei <fangfangx.wei@intel.com>
---
 tests/TestSuite_veb_switch.py | 25 +++++++++++++++----------
 1 file changed, 15 insertions(+), 10 deletions(-)

diff --git a/tests/TestSuite_veb_switch.py b/tests/TestSuite_veb_switch.py
index 01a5366..4c74e8f 100644
--- a/tests/TestSuite_veb_switch.py
+++ b/tests/TestSuite_veb_switch.py
@@ -394,29 +394,34 @@ class TestVEBSwitching(TestCase):
         self.session_secondary.send_expect("start", "testpmd>")
         time.sleep(2)
 
+        vf0_start_rx_stats = self.veb_get_pmd_stats("second", 0, "rx")
+        pf_start_tx_stats = self.veb_get_pmd_stats("first", 0, "tx")
         self.send_packet(self.vf0_mac, self.tester_itf)
         time.sleep(2)
         self.session_secondary.send_expect("stop", "testpmd>", 2)
         self.dut.send_expect("stop", "testpmd>", 2)
-        vf0_rx_stats = self.veb_get_pmd_stats("second", 0, "rx")
-        pf_tx_stats = self.veb_get_pmd_stats("first", 0, "tx")
-        self.verify(pf_tx_stats[0] == 0, "PF received unexpected packet")
-        self.verify(vf0_rx_stats[0] == 1, "no packet was received by VF0")
+        vf0_end_rx_stats = self.veb_get_pmd_stats("second", 0, "rx")
+        pf_end_tx_stats = self.veb_get_pmd_stats("first", 0, "tx")
+        self.verify(pf_end_tx_stats[0] - pf_start_tx_stats[0] == 0, "PF received unexpected packet")
+        self.verify(vf0_end_rx_stats[0] - vf0_start_rx_stats[0] == 1, "no packet was received by VF0")
  
         self.dut.send_expect("start", "testpmd>")
         time.sleep(2)
         self.session_secondary.send_expect("start", "testpmd>")
         time.sleep(2)
+        vf0_start_rx_stats = self.veb_get_pmd_stats("second", 0, "rx")
+        pf_start_tx_stats = self.veb_get_pmd_stats("first", 0, "tx")
+        pf_start_rx_stats = self.veb_get_pmd_stats("first", 0, "rx")
         self.send_packet(self.pf_mac_address, self.tester_itf)
         time.sleep(2)
         self.session_secondary.send_expect("stop", "testpmd>", 2)
         self.dut.send_expect("stop", "testpmd>", 2)
-        vf0_rx_stats = self.veb_get_pmd_stats("second", 0, "rx")
-        pf_tx_stats = self.veb_get_pmd_stats("first", 0, "tx")
-        pf_rx_stats = self.veb_get_pmd_stats("first", 0, "rx")
-        self.verify(pf_tx_stats[0] == 1, "no packet was sent by VF0")
-        self.verify(pf_rx_stats[0] == 1, "no packet was received by VF0")
-        self.verify(vf0_rx_stats[0] == 1, "no packet was received by VF0")
+        vf0_end_rx_stats = self.veb_get_pmd_stats("second", 0, "rx")
+        pf_end_tx_stats = self.veb_get_pmd_stats("first", 0, "tx")
+        pf_end_rx_stats = self.veb_get_pmd_stats("first", 0, "rx")
+        self.verify(pf_end_tx_stats[0] - pf_start_tx_stats[0] == 1, "no packet was sent by VF0")
+        self.verify(pf_end_rx_stats[0] - pf_start_rx_stats[0] == 1, "no packet was received by VF0")
+        self.verify(vf0_end_rx_stats[0] - vf0_start_rx_stats[0] == 0, "VF0 received unexpected packet")
         self.session_secondary.send_expect("quit", "# ")
         time.sleep(2)
         self.dut.send_expect("quit", "# ")
-- 
2.7.5

             reply	other threads:[~2017-09-27  6:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-27  6:11 Fangfang Wei [this message]
2017-09-30 10:26 ` Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1506492679-27897-1-git-send-email-fangfangx.wei@intel.com \
    --to=fangfangx.wei@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).