test suite reviews and discussions
 help / color / mirror / Atom feed
From: "xu,huilong" <huilongx.xu@intel.com>
To: dts@dpdk.org
Cc: "xu,huilong" <huilongx.xu@intel.com>
Subject: [dts] [PATCH V1] remove repeating check nic type
Date: Wed, 27 Sep 2017 17:07:44 +0800	[thread overview]
Message-ID: <1506503265-29342-5-git-send-email-huilongx.xu@intel.com> (raw)
In-Reply-To: <1506503265-29342-1-git-send-email-huilongx.xu@intel.com>

remove dead code, because the test suite only support fortville nic, and check nic type
in setup_all function already. So check nic type is repeating when set reta_num.

Signed-off-by: xu,huilong <huilongx.xu@intel.com>
---
 tests/TestSuite_fortville_rss_granularity_config.py | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/tests/TestSuite_fortville_rss_granularity_config.py b/tests/TestSuite_fortville_rss_granularity_config.py
index fed48e0..665ee20 100644
--- a/tests/TestSuite_fortville_rss_granularity_config.py
+++ b/tests/TestSuite_fortville_rss_granularity_config.py
@@ -82,10 +82,7 @@ class TestFortvilleRssGranularityConfig(TestCase):
                     "fortville_spirit_single", "fortville_25g"],
                     "NIC Unsupported: " + str(self.nic))
         global reta_num
-        if self.nic in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single"]:
-            reta_num = 512
-        else:
-            self.verify(False, "NIC Unsupported:%s" % str(self.nic))
+        reta_num = 512
         ports = self.dut.get_ports(self.nic)
         self.verify(len(ports) >= 1, "Not enough ports available")
 
-- 
1.9.3

  parent reply	other threads:[~2017-09-27  9:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-27  9:07 [dts] [PATCH V1] fix fortville_25g dual vlan failed case xu,huilong
2017-09-27  9:07 ` [dts] [PATCH V1] fix rss key size case failed xu,huilong
2017-09-30 10:42   ` Liu, Yong
2017-09-30 11:03   ` Liu, Yong
2017-09-27  9:07 ` [dts] [PATCH V1] fix skeleton test " xu,huilong
2017-09-30 11:39   ` Liu, Yong
2017-09-27  9:07 ` [dts] [PATCH V1] fix update_system " xu,huilong
2017-09-30 11:56   ` Liu, Yong
2017-09-27  9:07 ` xu,huilong [this message]
2017-09-30 11:45   ` [dts] [PATCH V1] remove repeating check nic type Liu, Yong
2017-09-27  9:07 ` [dts] [PATCH V1] update fortville_25g check case list xu,huilong
2017-09-30 12:13   ` Liu, Yong
2017-09-30 10:35 ` [dts] [PATCH V1] fix fortville_25g dual vlan failed case Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1506503265-29342-5-git-send-email-huilongx.xu@intel.com \
    --to=huilongx.xu@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).