test suite reviews and discussions
 help / color / mirror / Atom feed
From: Fangfang Wei <fangfangx.wei@intel.com>
To: dts@dpdk.org
Cc: Fangfangx Wei <fangfangx.wei@intel.com>
Subject: [dts] [PATCH V1] tests/sriov_kvm: update negative input commands
Date: Tue, 24 Oct 2017 16:16:06 +0800	[thread overview]
Message-ID: <1508832966-18917-1-git-send-email-fangfangx.wei@intel.com> (raw)

From: Fangfangx Wei <fangfangx.wei@intel.com>

DPDK-3807: developer said the rule-id can be any value which is set by user.
So setting the invalid rule-id as 256 to test negative input commands.
Because in dpdk the mirror rule-id is uint8_t.

Remove command "set port 0 mirror-rule 2 vlan-mirror 9 dst-pool 1 on".
It's not a invalid command for vlan-mirror is supported now.

Signed-off-by: Fangfangx Wei <fangfangx.wei@intel.com>
---
 tests/TestSuite_sriov_kvm.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/TestSuite_sriov_kvm.py b/tests/TestSuite_sriov_kvm.py
index 8424b22..440306c 100644
--- a/tests/TestSuite_sriov_kvm.py
+++ b/tests/TestSuite_sriov_kvm.py
@@ -1263,8 +1263,7 @@ class TestSriovKvm(TestCase):
                         "set port 0 vf 34 rxmode ROPE on",
                         "mac_addr add port 0 vf 65 00:55:44:33:22:11",
                         "mac_addr add port 5 vf 0 00:55:44:88:22:11",
-                        "set port 0 mirror-rule 0xf uplink-mirror dst-pool 1 on",
-                        "set port 0 mirror-rule 2 vlan-mirror 9 dst-pool 1 on",
+                        "set port 0 mirror-rule 256 uplink-mirror dst-pool 1 on",
                         "set port 0 mirror-rule 0 downlink-mirror 0xf dst-pool 2 off",
                         "reset port 0 mirror-rule 4",
                         "reset port 0xff mirror-rule 0"]:
-- 
2.7.5

             reply	other threads:[~2017-10-24  8:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-24  8:16 Fangfang Wei [this message]
2017-10-30  9:23 ` Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1508832966-18917-1-git-send-email-fangfangx.wei@intel.com \
    --to=fangfangx.wei@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).