test suite reviews and discussions
 help / color / mirror / Atom feed
From: Fangfang Wei <fangfangx.wei@intel.com>
To: dts@dpdk.org
Cc: Fangfangx Wei <fangfangx.wei@intel.com>
Subject: [dts] [PATCH V1] tests/vf_vlan: Remove useless codes
Date: Mon,  6 Nov 2017 11:03:02 +0800	[thread overview]
Message-ID: <1509937382-35135-1-git-send-email-fangfangx.wei@intel.com> (raw)

From: Fangfangx Wei <fangfangx.wei@intel.com>

Reference to DPDK-4036: VF vlan strip is supported from i40e kernel driver
2.1.26.
So remove useless codes.

Signed-off-by: Fangfangx Wei <fangfangx.wei@intel.com>
---
 tests/TestSuite_vf_vlan.py | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/tests/TestSuite_vf_vlan.py b/tests/TestSuite_vf_vlan.py
index ab64a15..aae3b6d 100644
--- a/tests/TestSuite_vf_vlan.py
+++ b/tests/TestSuite_vf_vlan.py
@@ -393,14 +393,8 @@ class TestVfVlan(TestCase):
             out = self.send_and_getout(vlan=rx_vlan, pkt_type="VLAN_UDP")
             self.verify(
                 "received 1 packets" in out, "Not received vlan packet as expected!!!")
-            nic_type = self.vm_dut_0.ports_info[0]['type']
-            nic_name = get_nic_name(nic_type)
-            if nic_name in ['fvl10g_vf', 'fortpark_TLV_vf']:
-                self.verify("VLAN tci=%s" %
-                            vlan_hex in out, "Failed to disable strip vlan!!!")
-            else:
-                self.verify(
-                    "PKT_RX_VLAN_STRIPPED" not in out, "Failed to disable strip vlan!!!")
+            self.verify(
+                "PKT_RX_VLAN_STRIPPED" not in out, "Failed to disable strip vlan!!!")
 
         self.vm0_testpmd.quit()
 
-- 
2.7.5

             reply	other threads:[~2017-11-06  3:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-06  3:03 Fangfang Wei [this message]
2017-11-13  9:23 ` Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1509937382-35135-1-git-send-email-fangfangx.wei@intel.com \
    --to=fangfangx.wei@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).