From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f68.google.com (mail-lf0-f68.google.com [209.85.215.68]) by dpdk.org (Postfix) with ESMTP id 907AA2B9E for ; Fri, 1 Dec 2017 22:22:07 +0100 (CET) Received: by mail-lf0-f68.google.com with SMTP id l81so13149345lfl.6 for ; Fri, 01 Dec 2017 13:22:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=sI9rhOagUt6O1Adofn28HcO7Mf0WU6kkTaYMlemGD0w=; b=kNYI7he2lEhJ242VjptD76oZdPB/lCfm6Gq2ItwfHC+zLCu+d5wd++k5s54ZIsRskm Siz9lhaTgCHq/zojkEAnUTfoearMcBUwbcgoHJO/QhnLORJnjhZzHGb/DequqktxSafW aYF6xnvsa2n396o2IUVTu5Qbr0qX1KxbfWyNk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=sI9rhOagUt6O1Adofn28HcO7Mf0WU6kkTaYMlemGD0w=; b=Z9Sa8CDSMTLXll67CEgGQXdPGarGLqKU/grCxvUV9RS2AMHNin/hFUjes9p5+dl3Xz vjcgpsCVcCzCM2xg7zq14ilG6f5zGvgm6XA5RZ9mCgJhp3f0B0xOk0rqxpitt+8PYBrD VwCgq6sCzJGGBMnbCN8YCyqhyLElZALzOXfbR6CtRdYK1pwN7CqaTZ791r3DXYgXRNqn Cp2Ec8XXeA8+Jp6I4JuVZbFrnLzxUuo29noA6xeEUq9tGeBEDG9pTS0Xi1BKizaHSrmW x11vH53TRFXpTgGgO5snQJpFFnAtDMSUXqFcU+7C2bH7Aprfwq7m6V/DfhjwSzKIzgt9 a1sA== X-Gm-Message-State: AJaThX4NtjZYmivyD71yiMEMGBq/MV53fikQlSaiMWiVakTSdksanr6c SKfunjhXEczUBqMcQnK8GWaxQhl4Xbo= X-Google-Smtp-Source: AGs4zMbNxlDG6JyWoAraZAsHySMJkv/R/MCqlOP+R0GYorzPW84nTagRtUMkOh9rajOIFe+mTBqXbQ== X-Received: by 10.46.69.67 with SMTP id s64mr5710149lja.94.1512163327102; Fri, 01 Dec 2017 13:22:07 -0800 (PST) Received: from rad-H81M-S1.semihalf.local (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id w62sm1478571lje.59.2017.12.01.13.22.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 01 Dec 2017 13:22:06 -0800 (PST) From: Radoslaw Biernacki To: dts@dpdk.org, yong.liu@intel.com, aczubak@caviumnetworks.com Cc: herbert.guan@linaro.org, Radoslaw Biernacki Date: Fri, 1 Dec 2017 22:20:51 +0100 Message-Id: <1512163254-31552-2-git-send-email-radoslaw.biernacki@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512163254-31552-1-git-send-email-radoslaw.biernacki@linaro.org> References: <1512163254-31552-1-git-send-email-radoslaw.biernacki@linaro.org> Subject: [dts] [PATCH 1/4] framework/crb: Fixing ThunderX ethernet controler detection X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Dec 2017 21:22:07 -0000 Asking for link speed for ThunderX Ethernet controller is not reliable since driver report error when the link is down. In fact we dont need to ask for link speed as Ethernet controllers can be easily identified by device name from lspci. The mapping will fuhrer filter out the PF and VF interfaces which does not have the interface name assigned. Fixes: 150716d93f5e ("framework crb: Appending only 10G devices for cavium") Signed-off-by: Radoslaw Biernacki --- framework/crb.py | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/framework/crb.py b/framework/crb.py index dd29a8b..36b1ffe 100644 --- a/framework/crb.py +++ b/framework/crb.py @@ -268,20 +268,13 @@ class Crb(object): Look for the NIC's information (PCI Id and card type). """ out = self.send_expect( - "lspci -Dnn | grep -i eth", "# ", alt_session=True) + "lspci -Dnn | grep -i 'Ethernet controller'", "# ", alt_session=True) rexp = r"([\da-f]{4}:[\da-f]{2}:[\da-f]{2}.\d{1}) .*Eth.*?ernet .*?([\da-f]{4}:[\da-f]{4})" pattern = re.compile(rexp) match = pattern.findall(out) self.pci_devices_info = [] for i in range(len(match)): - #check if device is cavium and check its linkspeed, append only if it is 10G - if "177d:" in match[i][1]: - linkspeed = "10000" - nic_linkspeed = self.send_command("cat /sys/bus/pci/devices/%s/net/*/speed" % match[i][0]) - if nic_linkspeed == linkspeed: - self.pci_devices_info.append((match[i][0], match[i][1])) - else: - self.pci_devices_info.append((match[i][0], match[i][1])) + self.pci_devices_info.append((match[i][0], match[i][1])) def pci_devices_information_uncached_freebsd(self): """ -- 2.7.4