test suite reviews and discussions
 help / color / mirror / Atom feed
From: Jogarao Nartu <njogarao@caviumnetworks.com>
To: yong.liu@intel.com
Cc: dts@dpdk.org, jerin.jacob@caviumnetworks.com,
	Jogarao Nartu <njogarao@caviumnetworks.com>
Subject: [dts] [dpdk-dts] [PATCH] framework/etgen: fix incorrect number of arguments
Date: Mon,  4 Dec 2017 20:10:50 +0530	[thread overview]
Message-ID: <1512398450-27403-1-git-send-email-njogarao@caviumnetworks.com> (raw)

SSHConnection used in IxiaPacketGenerator takes 4 arguments i.e. host,
session_name, username and password.Currently only 3 arguments are being
passed while ssh object is being initilized in IxiaPacketGenerator.
Pass the missing username agrument by including self.tester.get_username().

Fixes: 4792d001d5b5 ("framework: Add login password support")

Signed-off-by: Jogarao Nartu <njogarao@caviumnetworks.com>
---
 framework/etgen.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/framework/etgen.py b/framework/etgen.py
index 1114453..4c0b6e2 100644
--- a/framework/etgen.py
+++ b/framework/etgen.py
@@ -140,7 +140,7 @@ class IxiaPacketGenerator(SSHConnection):
         self.NAME = 'ixia'
         self.logger = getLogger(self.NAME)
         super(IxiaPacketGenerator, self).__init__(self.get_ip_address(),
-                                                  self.NAME,
+                                                  self.NAME, self.tester.get_username(),
                                                   self.get_password())
         super(IxiaPacketGenerator, self).init_log(self.logger)
 
-- 
2.7.4

             reply	other threads:[~2017-12-04 14:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-04 14:40 Jogarao Nartu [this message]
2017-12-05 10:03 ` Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1512398450-27403-1-git-send-email-njogarao@caviumnetworks.com \
    --to=njogarao@caviumnetworks.com \
    --cc=dts@dpdk.org \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=yong.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).