test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH] tests/vxlan: correct the attribute name of UDP object
@ 2017-12-15  5:58 Herbert Guan
  2018-01-03 16:00 ` Liu, Yong
  0 siblings, 1 reply; 2+ messages in thread
From: Herbert Guan @ 2017-12-15  5:58 UTC (permalink / raw)
  To: dts; +Cc: Herbert Guan

outer[UDP] does not have attributes of 'dst'/'src', but has 'dport'
'sport' instead.  This patch corrects this typo.

Signed-off-by: Herbert Guan <herbert.guan@arm.com>
---
 tests/TestSuite_vxlan.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_vxlan.py b/tests/TestSuite_vxlan.py
index 7c70e30..b1f6f10 100644
--- a/tests/TestSuite_vxlan.py
+++ b/tests/TestSuite_vxlan.py
@@ -168,8 +168,8 @@ class VxlanTestConfig(object):
             outer[outer_l3.name].src = self.outer_ip_src
             outer[outer_l3.name].dst = self.outer_ip_dst
 
-        outer[UDP].src = self.outer_udp_src
-        outer[UDP].dst = self.outer_udp_dst
+        outer[UDP].sport = self.outer_udp_src
+        outer[UDP].dport = self.outer_udp_dst
 
         if self.outer_ip_invalid == 1:
             outer[outer_l3.name].chksum = 0
-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH] tests/vxlan: correct the attribute name of UDP object
  2017-12-15  5:58 [dts] [PATCH] tests/vxlan: correct the attribute name of UDP object Herbert Guan
@ 2018-01-03 16:00 ` Liu, Yong
  0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2018-01-03 16:00 UTC (permalink / raw)
  To: Herbert Guan, dts

Thanks, Herbert. Applied.

On 12/15/2017 01:58 PM, Herbert Guan wrote:
> outer[UDP] does not have attributes of 'dst'/'src', but has 'dport'
> 'sport' instead.  This patch corrects this typo.
>
> Signed-off-by: Herbert Guan<herbert.guan@arm.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-01-03  8:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-15  5:58 [dts] [PATCH] tests/vxlan: correct the attribute name of UDP object Herbert Guan
2018-01-03 16:00 ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).